From patchwork Sun May 29 02:22:44 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Rientjes X-Patchwork-Id: 827182 Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p4T2RHAo010863 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 29 May 2011 02:27:38 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by bombadil.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QQVeb-00075V-NM; Sun, 29 May 2011 02:22:57 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QQVeZ-0006rb-EO; Sun, 29 May 2011 02:22:55 +0000 Received: from smtp-out.google.com ([216.239.44.51]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QQVeV-0006r1-IV for linux-arm-kernel@lists.infradead.org; Sun, 29 May 2011 02:22:52 +0000 Received: from wpaz17.hot.corp.google.com (wpaz17.hot.corp.google.com [172.24.198.81]) by smtp-out.google.com with ESMTP id p4T2MmfP023507 for ; Sat, 28 May 2011 19:22:48 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1306635769; bh=PAP9sv8pV+h0H1egWAQWvZcGCuw=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=bqpX/TnVG9Px0AeYZNXbTi8NLb+NKx7En3wiGuP/1vc2puGcEZAYQExlkJ7T6ApEh JW30dOEpyVNIqq0g/M3aA== Received: from pwi9 (pwi9.prod.google.com [10.241.219.9]) by wpaz17.hot.corp.google.com with ESMTP id p4T2Mkgb028266 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Sat, 28 May 2011 19:22:47 -0700 Received: by pwi9 with SMTP id 9so1289232pwi.38 for ; Sat, 28 May 2011 19:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=domainkey-signature:date:from:x-x-sender:to:cc:subject:in-reply-to :message-id:references:user-agent:mime-version:content-type; bh=yqZQid+xWCt5nIrmM4y11uvPl3q4X71bnAafwXE+GOE=; b=nuaCkBCEPpKte0K8S1H9zoRT0NtRWeD8sPpDjAfGJifMvl4IzyE1Uk2Si/DGAQDMKs b8ThlVnhvj29DfqtV5Kw== DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; b=rM+fOMhMpdd8LKccbJle5AN8NAIqLgVGS84gxXXYucdNC9owYHnq9R8Mrp9aT8tzc7 X8qRVy1ARTHO2sY9KP+w== Received: by 10.68.21.129 with SMTP id v1mr1459459pbe.413.1306635766419; Sat, 28 May 2011 19:22:46 -0700 (PDT) Received: from chino.kir.corp.google.com (chino.kir.corp.google.com [172.31.6.12]) by mx.google.com with ESMTPS id w5sm1725569pbh.77.2011.05.28.19.22.45 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 28 May 2011 19:22:45 -0700 (PDT) Date: Sat, 28 May 2011 19:22:44 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Russell King - ARM Linux Subject: Re: IrDA driver fails on PXA255 In-Reply-To: <20110528234614.GV24876@n2100.arm.linux.org.uk> Message-ID: References: <20110528205701.GA1788@doriath.ww600.siemens.net> <20110528234614.GV24876@n2100.arm.linux.org.uk> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 X-System-Of-Record: true X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110528_222251_965578_86ADF1E8 X-CRM114-Status: GOOD ( 34.05 ) X-Spam-Score: -2.4 (--) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-2.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [216.239.44.51 listed in list.dnswl.org] -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Nicolas Pitre , Samuel Ortiz , Eric Miao , Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Sun, 29 May 2011 02:27:38 +0000 (UTC) On Sun, 29 May 2011, Russell King - ARM Linux wrote: > > The driver is attempting to allocate DMA memory and you have > > CONFIG_ZONE_DMA disabled, which is the only reason you would get this > > warning. If the allocation did not fail as a result of a197b59ae6e8, the > > page allocator may return any memory in a higher zone that the driver may > > not be expecting. If you had never noticed a problem before, it may be > > possible that the driver doesn't actually have any zone restrictions and > > GFP_DMA can be removed, but this code is pretty old. Otherwise, it'll > > need to depend on ZONE_DMA in the Kconfig. > > > > Let's cc Nicolas and Russell as well. > > Ouch. We're probably going to have a pile of work to do to check that > the DMA masks on all our devices are correct for the unrestricted case > then. That's probably going to be a very _big_ patch. > There are probably a lot of drivers that are requesting DMA but don't explicitly require its support. ARM has always been one of the exceptions when it comes to enabling CONFIG_ZONE_DMA, most archs do by default (x86 _just_ made it configurable during this merge window), so this probably isn't the last report you'll get now that it fails the allocation and emits a warning. $ grep -r GFP_DMA drivers/* | wc -l 299 arm, pxa2xx: enable DMA support for pxa2xx IRDA interface The pxa2xx-ir driver allocates with GFP_DMA, so it must always have ZONE_DMA. Reported-by: Dmitry Eremin-Solenikov Signed-off-by: David Rientjes --- drivers/net/irda/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/irda/Kconfig b/drivers/net/irda/Kconfig --- a/drivers/net/irda/Kconfig +++ b/drivers/net/irda/Kconfig @@ -374,6 +374,7 @@ config VIA_FIR config PXA_FICP tristate "Intel PXA2xx Internal FICP" depends on ARCH_PXA && IRDA + select ZONE_DMA help Say Y or M here if you want to build support for the PXA2xx built-in IRDA interface which can support both SIR and FIR.