diff mbox

[v3,for,3.10] Introduce a Marvell EBU MBus driver

Message ID alpine.DEB.2.02.1303302040001.13473@vroombuntu (mailing list archive)
State New, archived
Headers show

Commit Message

Neil Greatorex March 30, 2013, 8:41 p.m. UTC 
On Sat, 30 Mar 2013, Jason Cooper wrote:

> On Thu, Mar 28, 2013 at 10:27:28PM +0000, Neil Greatorex wrote:
> ...
>> -- >8 --
>> Subject: [PATCH] bus: mvebu-mbus: Restore checking for coherency fabric
>>  hardware
>>
>> The new mvebu-mbus driver was not checking the device tree for
>> coherency fabric hardware and hence was not setting the hw_io_coherency
>> flag in mbus_state. This prevented the mvsdio driver from operating
>> correctly. This patch restores the check.
>
> Neil,
>
> If I could get you to put a Signed-off-by: on this, I'll queue it up so
> folks can test it more easily.
>
> thx,
>
> Jason.
>

Jason,

Thanks. I've included it below.

Cheers,
Neil


Subject: [PATCH] bus: mvebu-mbus: Restore checking for coherency fabric
  hardware

The new mvebu-mbus driver was not checking the device tree for
coherency fabric hardware and hence was not setting the hw_io_coherency
flag in mbus_state. This prevented the mvsdio driver from operating
correctly. This patch restores the check.

Signed-off-by: Neil Greatorex <neil@fatboyfat.co.uk>
---
  drivers/bus/mvebu-mbus.c |    3 +++
  1 file changed, 3 insertions(+)

  		mvebu_mbus_disable_window(mbus, win);

Comments

Jason Cooper March 30, 2013, 9:14 p.m. UTC | #1 
On Sat, Mar 30, 2013 at 08:41:20PM +0000, Neil Greatorex wrote:
...
> Subject: [PATCH] bus: mvebu-mbus: Restore checking for coherency fabric
>  hardware
> 
> The new mvebu-mbus driver was not checking the device tree for
> coherency fabric hardware and hence was not setting the hw_io_coherency
> flag in mbus_state. This prevented the mvsdio driver from operating
> correctly. This patch restores the check.
> 
> Signed-off-by: Neil Greatorex <neil@fatboyfat.co.uk>
> ---
>  drivers/bus/mvebu-mbus.c |    3 +++
>  1 file changed, 3 insertions(+)

Applied to mvebu/drivers

thx,

Jason.
diff mbox

Patch

diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 586d03e..a0250c6 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -858,6 +858,9 @@  int __init mvebu_mbus_init(const char *soc, 
phys_addr_t mbuswins_phys_base,
  		return -ENOMEM;
  	}

+	if (of_find_compatible_node(NULL, NULL, 
"marvell,coherency-fabric"))
+		mbus->hw_io_coherency = 1;
+
  	for (win = 0; win < mbus->soc->num_wins; win++)