From patchwork Sat Mar 30 20:41:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Greatorex X-Patchwork-Id: 2368051 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id D246E3FD40 for ; Sat, 30 Mar 2013 20:44:11 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UM2an-0006ML-AF; Sat, 30 Mar 2013 20:41:37 +0000 Received: from mail-we0-x234.google.com ([2a00:1450:400c:c03::234]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UM2ai-0006Lj-K0 for linux-arm-kernel@lists.infradead.org; Sat, 30 Mar 2013 20:41:34 +0000 Received: by mail-we0-f180.google.com with SMTP id r5so982439wey.25 for ; Sat, 30 Mar 2013 13:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fatboyfat.co.uk; s=google; h=x-received:date:from:x-x-sender:to:cc:subject:in-reply-to :message-id:references:user-agent:mime-version:content-type; bh=uJunsZAP8orOnfjbJER/bpE0eeOzzKVGikydoslVjyg=; b=RKQZA/zCDUfOUaNFXPzudAJNMdmtRUJfGh3NoyNquRyxVIlQ0sPnmByaI9BNISq/3H EAccWTr79q44NuZH7nnrcG2C6Bmy4ZXdgJy+ZExL/az769pEwGnz64u4178wRDqQO5Tr +OjyBhUh2poMz1w4cFt3DHaxjsSwsJtne255E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:x-x-sender:to:cc:subject:in-reply-to :message-id:references:user-agent:mime-version:content-type :x-gm-message-state; bh=uJunsZAP8orOnfjbJER/bpE0eeOzzKVGikydoslVjyg=; b=clzhPmvJlzLyfCkBW0gcwI2rz/Ni2WXTsPWfYu0moRhhVRBJ836Je9LOdUgloZfywE dWrdgSe3IGc64X2gaTEcgpC8dz+YTuhAlZzHmNVffL6IrV7pVIwWoytV/mcNbMCeSk+P CbaYgeFO1H4GZBcqlVN0KRzFK00BqL6HC6vH1NzfFOeEuP+iJRtvEbDQuONeZ4yZkGDH N0xft2qAHIS0ta09N3tpZ9n2sICQ7sT4AxfXmteRYmJTVukn1lxR9zkgzjsY3Arv5KuQ afk/TL0ehxZRzHaHQxWre2+0C0IK2qVa/J5dyvO9eLYjaVEA5u3QqK4Rq8GKuGDvio3N nuJw== X-Received: by 10.180.182.36 with SMTP id eb4mr3681884wic.8.1364676090357; Sat, 30 Mar 2013 13:41:30 -0700 (PDT) Received: from vroombuntu.lan ([151.230.237.226]) by mx.google.com with ESMTPS id bk1sm5777114wib.2.2013.03.30.13.41.28 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 30 Mar 2013 13:41:29 -0700 (PDT) Date: Sat, 30 Mar 2013 20:41:20 +0000 (GMT) From: Neil Greatorex X-X-Sender: neil@vroombuntu To: Jason Cooper Subject: Re: [PATCH v3 for 3.10] Introduce a Marvell EBU MBus driver In-Reply-To: <20130330202109.GU13280@titan.lakedaemon.net> Message-ID: References: <1363885160-6870-1-git-send-email-thomas.petazzoni@free-electrons.com> <201303211730.23247.arnd@arndb.de> <20130321184641.GB13280@titan.lakedaemon.net> <20130328083306.3c2a23de@skate> <20130330202109.GU13280@titan.lakedaemon.net> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQnQp05W8cL8tpAbwTNQ3LrkuajVxZb24DjxOKnEpNKrWIzeQ4CPlwpU8z83kQ7cr+Q0LoD2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130330_164133_104114_5092CB56 X-CRM114-Status: GOOD ( 17.49 ) X-Spam-Score: -2.0 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 KHOP_BIG_TO_CC Sent to 10+ recipients instaed of Bcc or a list -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Thomas Petazzoni , Lior Amsalem , Arnd Bergmann , Andrew Lunn , Maen Suleiman , Ezequiel Garcia , Olof Johansson , Gregory Clement , linux-arm-kernel , Sebastian Hesselbarth X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Sat, 30 Mar 2013, Jason Cooper wrote: > On Thu, Mar 28, 2013 at 10:27:28PM +0000, Neil Greatorex wrote: > ... >> -- >8 -- >> Subject: [PATCH] bus: mvebu-mbus: Restore checking for coherency fabric >> hardware >> >> The new mvebu-mbus driver was not checking the device tree for >> coherency fabric hardware and hence was not setting the hw_io_coherency >> flag in mbus_state. This prevented the mvsdio driver from operating >> correctly. This patch restores the check. > > Neil, > > If I could get you to put a Signed-off-by: on this, I'll queue it up so > folks can test it more easily. > > thx, > > Jason. > Jason, Thanks. I've included it below. Cheers, Neil Subject: [PATCH] bus: mvebu-mbus: Restore checking for coherency fabric hardware The new mvebu-mbus driver was not checking the device tree for coherency fabric hardware and hence was not setting the hw_io_coherency flag in mbus_state. This prevented the mvsdio driver from operating correctly. This patch restores the check. Signed-off-by: Neil Greatorex --- drivers/bus/mvebu-mbus.c | 3 +++ 1 file changed, 3 insertions(+) mvebu_mbus_disable_window(mbus, win); diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c index 586d03e..a0250c6 100644 --- a/drivers/bus/mvebu-mbus.c +++ b/drivers/bus/mvebu-mbus.c @@ -858,6 +858,9 @@ int __init mvebu_mbus_init(const char *soc, phys_addr_t mbuswins_phys_base, return -ENOMEM; } + if (of_find_compatible_node(NULL, NULL, "marvell,coherency-fabric")) + mbus->hw_io_coherency = 1; + for (win = 0; win < mbus->soc->num_wins; win++)