From patchwork Tue Jan 6 20:32:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Walmsley X-Patchwork-Id: 5576921 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 854DCBF6C3 for ; Tue, 6 Jan 2015 20:34:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A47742024C for ; Tue, 6 Jan 2015 20:34:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 236682021A for ; Tue, 6 Jan 2015 20:34:30 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y8ao5-0007lq-8I; Tue, 06 Jan 2015 20:32:49 +0000 Received: from utopia.booyaka.com ([74.50.51.50]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y8anz-0007bM-RB for linux-arm-kernel@lists.infradead.org; Tue, 06 Jan 2015 20:32:44 +0000 Received: (qmail 23845 invoked by uid 1019); 6 Jan 2015 20:32:22 -0000 Date: Tue, 6 Jan 2015 20:32:22 +0000 (UTC) From: Paul Walmsley To: Mark Rutland Subject: Re: [PATCH 4/4] arm64: fix missing asm/io.h include in kernel/smp_spin_table.c In-Reply-To: <20150106103404.GB4858@leverpostej> Message-ID: References: <20150106014554.27249.89116.stgit@dusk.lan> <20150106015220.27249.74970.stgit@dusk.lan> <20150106103404.GB4858@leverpostej> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150106_123244_037949_1A6A67CC X-CRM114-Status: GOOD ( 11.77 ) X-Spam-Score: -0.0 (/) Cc: Catalin Marinas , Will Deacon , Paul Walmsley , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Mark, On Tue, 6 Jan 2015, Mark Rutland wrote: > Nit: please move between the include of asm/cputype and asm/smp_plat.h, > so as to keep the list in alphabetical order. Done. Updated patch below. Thanks for the review, - Paul From: Paul Walmsley Date: Mon, 5 Jan 2015 17:38:42 -0700 Subject: [PATCH 4/4] arm64: fix missing asm/io.h include in kernel/smp_spin_table.c On next-20150105, defconfig compilation breaks with: arch/arm64/kernel/smp_spin_table.c:80:2: error: implicit declaration of function ‘ioremap_cache’ [-Werror=implicit-function-declaration] arch/arm64/kernel/smp_spin_table.c:92:2: error: implicit declaration of function ‘writeq_relaxed’ [-Werror=implicit-function-declaration] arch/arm64/kernel/smp_spin_table.c:101:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] Fix by including asm/io.h, which contains definitions or prototypes for these macros or functions. This second version incorporates a comment from Mark Rutland to keep the includes in alphabetical order by filename. Signed-off-by: Paul Walmsley Cc: Paul Walmsley Cc: Catalin Marinas Cc: Will Deacon Acked-by: Mark Rutland --- arch/arm64/kernel/smp_spin_table.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/smp_spin_table.c b/arch/arm64/kernel/smp_spin_table.c index 4f93c67e63de..14944e5b28da 100644 --- a/arch/arm64/kernel/smp_spin_table.c +++ b/arch/arm64/kernel/smp_spin_table.c @@ -25,6 +25,7 @@ #include #include #include +#include #include extern void secondary_holding_pen(void);