From patchwork Tue Feb 16 12:14:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 8324671 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A3D63C02AA for ; Tue, 16 Feb 2016 12:16:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BE39C20260 for ; Tue, 16 Feb 2016 12:16:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDFEF20295 for ; Tue, 16 Feb 2016 12:16:32 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aVeX7-00058t-MB; Tue, 16 Feb 2016 12:15:09 +0000 Received: from smtp02.citrix.com ([66.165.176.63]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aVeX4-0004UT-8t for linux-arm-kernel@lists.infradead.org; Tue, 16 Feb 2016 12:15:07 +0000 X-IronPort-AV: E=Sophos;i="5.22,455,1449532800"; d="scan'208";a="338414568" Date: Tue, 16 Feb 2016 12:14:14 +0000 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Arnd Bergmann Subject: Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select In-Reply-To: <2801550.oZPkqjv8nW@wuerfel> Message-ID: References: <1455278707-2008263-1-git-send-email-arnd@arndb.de> <2801550.oZPkqjv8nW@wuerfel> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 X-DLP: MIA1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160216_041506_515062_71AA4A46 X-CRM114-Status: GOOD ( 17.09 ) X-Spam-Score: -4.2 (----) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, xen-devel@lists.xensource.com, Konrad Rzeszutek Wilk , Stefano Stabellini , Andrew Jones , linux-kernel@vger.kernel.org, Tomi Valkeinen , David Vrabel , boris.ostrovsky@oracle.com, Jean-Christophe Plagniol-Villard , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 16 Feb 2016, Arnd Bergmann wrote: > On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote: > > > > > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > > index 8ea45a5cd806..fd3d6fd290a9 100644 > > > --- a/drivers/video/fbdev/Kconfig > > > +++ b/drivers/video/fbdev/Kconfig > > > @@ -2241,6 +2241,7 @@ config FB_VIRTUAL > > > config XEN_FBDEV_FRONTEND > > > tristate "Xen virtual frame buffer support" > > > depends on FB && XEN > > > + depends on INPUT || !INPUT_MISC > > > select FB_SYS_FILLRECT > > > select FB_SYS_COPYAREA > > > select FB_SYS_IMAGEBLIT > > > > This looks very hackish. Couldn't we just do the following? > > > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > index 8ea45a5..3c15f6d 100644 > > --- a/drivers/video/fbdev/Kconfig > > +++ b/drivers/video/fbdev/Kconfig > > @@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND > > select FB_SYS_IMAGEBLIT > > select FB_SYS_FOPS > > select FB_DEFERRED_IO > > - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC > > + select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC) > > select XEN_XENBUS_FRONTEND > > default y > > help > > > > No, that doesn't solve the problem: > > If XEN_FBDEV_FRONTEND=y, INPUT=m and INPUT_MISC=y, we would still > get INPUT_XEN_KBDDEV_FRONTEND=y, which cannot work because of INPUT=m. > > INPUT_MISC already depends on INPUT, so your change has no effect > at all. Please correct me if I am wrong, but the difference is that with this change if INPUT=m, then the build system would ask the user whether she wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of unconditionally set INPUT_XEN_KBDDEV_FRONTEND=y. However it is true that if the users chooses INPUT_XEN_KBDDEV_FRONTEND=y, then the problem persists. Maybe we also need: Do you have a kernel config with INPUT=m that I can use to test with? diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index 1f2337a..303df24 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -721,7 +721,7 @@ config INPUT_CMA3000_I2C config INPUT_XEN_KBDDEV_FRONTEND tristate "Xen virtual keyboard and mouse support" - depends on XEN + depends on XEN && INPUT default y select XEN_XENBUS_FRONTEND help