diff mbox

mmc: sdhci-xenon: fix device_node_continue.cocci warnings

Message ID alpine.DEB.2.20.1612092006080.1960@hadrien (mailing list archive)
State New, archived
Headers show

Commit Message

Julia Lawall Dec. 9, 2016, 7:08 p.m. UTC 
Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.

Generated by: scripts/coccinelle/iterators/device_node_continue.cocci

CC: Hu Ziji <huziji@marvell.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please check on this.  I have only seen the code shown below, but the rule
normally has a lot false positive rate.

url:
https://github.com/0day-ci/linux/commits/Gregory-CLEMENT/mmc-Add-support-to-Marvell-Xenon-SD-Host-Controller/20161210-002602
base:
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago


Please take the patch only if it's a positive warning. Thanks!

 sdhci-xenon.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Hu Ziji Dec. 12, 2016, 6:10 a.m. UTC | #1 
Hi Julia,

On 2016/12/10 3:08, Julia Lawall wrote:
> Device node iterators put the previous value of the index variable, so an
> explicit put causes a double put.
> 
> Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
> 
> CC: Hu Ziji <huziji@marvell.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
> Please check on this.  I have only seen the code shown below, but the rule
> normally has a lot false positive rate.
> 

	Thank you.
	It seems that the check is right. I will correct it.

	Thank you.

Best regards,
Hu Ziji

> url:
> https://github.com/0day-ci/linux/commits/Gregory-CLEMENT/mmc-Add-support-to-Marvell-Xenon-SD-Host-Controller/20161210-002602
> base:
> :::::: branch date: 2 hours ago
> :::::: commit date: 2 hours ago
> 
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  sdhci-xenon.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/mmc/host/sdhci-xenon.c
> +++ b/drivers/mmc/host/sdhci-xenon.c
> @@ -423,7 +423,6 @@ static int xenon_child_node_of_parse(str
>  				      MMC_CAP2_NO_SD |
>  				      MMC_CAP2_NO_SDIO;
>  		}
> -		of_node_put(child);
>  	}
> 
>  	return 0;
>
diff mbox

Patch

--- a/drivers/mmc/host/sdhci-xenon.c
+++ b/drivers/mmc/host/sdhci-xenon.c
@@ -423,7 +423,6 @@  static int xenon_child_node_of_parse(str
 				      MMC_CAP2_NO_SD |
 				      MMC_CAP2_NO_SDIO;
 		}
-		of_node_put(child);
 	}

 	return 0;