From patchwork Sat Apr 6 14:02:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 2401721 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) by patchwork1.kernel.org (Postfix) with ESMTP id 77CDF3FD40 for ; Sat, 6 Apr 2013 14:03:09 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UOThq-0001jH-7e; Sat, 06 Apr 2013 14:02:58 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UOThn-0002o1-Ms; Sat, 06 Apr 2013 14:02:55 +0000 Received: from mail-qe0-f44.google.com ([209.85.128.44]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UOThk-0002ng-Lv for linux-arm-kernel@lists.infradead.org; Sat, 06 Apr 2013 14:02:53 +0000 Received: by mail-qe0-f44.google.com with SMTP id i11so634408qej.3 for ; Sat, 06 Apr 2013 07:02:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type:x-gm-message-state; bh=tpIAnmH4i9uvlA6f1BsXss1erda0dTPqUFnJySx5lXo=; b=iWb42anugrPq/ydNEoqAzLKyYFoJFG8JDWWq60J+K15wXpP/TVztARZWgy9w3ose4F AFsPIyBlKfkd4VArJhwrq/yZlSKCewY6yolNcvcYpof7GSS1LdOLNybXN1UDWTLglwGq Bj+Wmwmqgegbw6wIh2NdNbKcyn5wD3ibd4Pr2wETXpqcC9ijVxS8N9mI2NgPB7IoZaZz 543nIIDiSJeeokKKJElLQqEfEPajBdVqrVG+cbGqH2eyU1ILNMiuowTSvyF4hsf7kBQ1 p+bMttaIc+dyXoheOtWgPbaYZCJ/uPUjRlFai2QHZmZDBBSRre+GSKEioNSS/8HYky30 N1oA== X-Received: by 10.229.103.85 with SMTP id j21mr488861qco.65.1365256971071; Sat, 06 Apr 2013 07:02:51 -0700 (PDT) Received: from xanadu.home (modemcable139.65-203-24.mc.videotron.ca. [24.203.65.139]) by mx.google.com with ESMTPS id i4sm16482544qai.5.2013.04.06.07.02.49 (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 06 Apr 2013 07:02:50 -0700 (PDT) Date: Sat, 6 Apr 2013 10:02:48 -0400 (EDT) From: Nicolas Pitre To: Olof Johansson Subject: Re: [PATCH v4 15/15] ARM: vexpress: Select multi-cluster SMP operation if required In-Reply-To: <20130405224819.GB14308@quad.lixom.net> Message-ID: References: <1360041732-17936-1-git-send-email-nicolas.pitre@linaro.org> <1360041732-17936-16-git-send-email-nicolas.pitre@linaro.org> <20130405224819.GB14308@quad.lixom.net> User-Agent: Alpine 2.03 (LFD 1266 2009-07-14) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQlo+Nytk1lxO0NI+tjZE/bHt88/I6QCiplxfgKn8vTvizWbLcIX+5E+vucYGZLSCPlfAgZ5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130406_100252_815603_A7601A48 X-CRM114-Status: GOOD ( 23.76 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.128.44 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Dave Martin , lorenzo.pieralisi@arm.com, pawel.moll@arm.com, Catalin Marinas , Will Deacon , santosh.shilimkar@ti.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Fri, 5 Apr 2013, Olof Johansson wrote: > On Tue, Feb 05, 2013 at 12:22:12AM -0500, Nicolas Pitre wrote: > > From: Jon Medhurst > > > > Signed-off-by: Jon Medhurst > > Signed-off-by: Nicolas Pitre > > Reviewed-by: Santosh Shilimkar > > --- > > arch/arm/mach-vexpress/core.h | 2 ++ > > arch/arm/mach-vexpress/platsmp.c | 12 ++++++++++++ > > arch/arm/mach-vexpress/v2m.c | 2 +- > > 3 files changed, 15 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/mach-vexpress/core.h b/arch/arm/mach-vexpress/core.h > > index f134cd4a85..3a761fd76c 100644 > > --- a/arch/arm/mach-vexpress/core.h > > +++ b/arch/arm/mach-vexpress/core.h > > @@ -6,6 +6,8 @@ > > > > void vexpress_dt_smp_map_io(void); > > > > +void vexpress_smp_init_ops(void); > > + > > extern struct smp_operations vexpress_smp_ops; > > > > extern void vexpress_cpu_die(unsigned int cpu); > > diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c > > index c5d70de9bb..667344b479 100644 > > --- a/arch/arm/mach-vexpress/platsmp.c > > +++ b/arch/arm/mach-vexpress/platsmp.c > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -206,3 +207,14 @@ struct smp_operations __initdata vexpress_smp_ops = { > > .cpu_die = vexpress_cpu_die, > > #endif > > }; > > + > > +void __init vexpress_smp_init_ops(void) > > +{ > > + struct smp_operations *ops = &vexpress_smp_ops; > > +#ifdef CONFIG_CLUSTER_PM > > + extern struct smp_operations mcpm_smp_ops; > > Seems appropriate to put this prototype in a header file instead. > > > + if(of_find_compatible_node(NULL, NULL, "arm,cci")) > > Another checkpatch error on if() whitespace. > > Also, while bindings haven't been ironed out, checking for whether the > node/device is enabled or disabled could be appropriate here? Right. I've amended this patch slightly so to: 1) Keep the default .smp = &vexpress_smp_ops and only perform an override in vexpress_smp_init_ops() when appropriate. This should remove one potential issue with Xen support that was highlighted recently. 2) Add a mcpm_smp_set_ops() instead of installing mcpm_smp_ops directly for better abstraction. 3) Added a comment about and checked for the CCI node being enabled. That results in the patch below. Given those are minor changes, I kept the existing review tags. From: Jon Medhurst Date: Wed, 30 Jan 2013 09:12:55 +0000 Subject: [PATCH] ARM: vexpress: Select multi-cluster SMP operation if required Signed-off-by: Jon Medhurst Signed-off-by: Nicolas Pitre Reviewed-by: Santosh Shilimkar Acked-by: Pawel Moll diff --git a/arch/arm/common/mcpm_platsmp.c b/arch/arm/common/mcpm_platsmp.c index 34f236af09..cc82040877 100644 --- a/arch/arm/common/mcpm_platsmp.c +++ b/arch/arm/common/mcpm_platsmp.c @@ -85,3 +85,8 @@ struct smp_operations __initdata mcpm_smp_ops = { .cpu_die = mcpm_cpu_die, #endif }; + +void __init mcpm_smp_set_ops(void) +{ + smp_set_ops(&mcpm_smp_ops); +} diff --git a/arch/arm/include/asm/mcpm_entry.h b/arch/arm/include/asm/mcpm_entry.h index 814623e6a1..34dfb86ff5 100644 --- a/arch/arm/include/asm/mcpm_entry.h +++ b/arch/arm/include/asm/mcpm_entry.h @@ -190,5 +190,7 @@ int __mcpm_cluster_state(unsigned int cluster); int __init mcpm_sync_init( void (*power_up_setup)(unsigned int affinity_level)); +void __init mcpm_smp_set_ops(void); + #endif /* ! __ASSEMBLY__ */ #endif diff --git a/arch/arm/mach-vexpress/core.h b/arch/arm/mach-vexpress/core.h index f134cd4a85..3a761fd76c 100644 --- a/arch/arm/mach-vexpress/core.h +++ b/arch/arm/mach-vexpress/core.h @@ -6,6 +6,8 @@ void vexpress_dt_smp_map_io(void); +void vexpress_smp_init_ops(void); + extern struct smp_operations vexpress_smp_ops; extern void vexpress_cpu_die(unsigned int cpu); diff --git a/arch/arm/mach-vexpress/platsmp.c b/arch/arm/mach-vexpress/platsmp.c index dc1ace55d5..06317bc714 100644 --- a/arch/arm/mach-vexpress/platsmp.c +++ b/arch/arm/mach-vexpress/platsmp.c @@ -12,9 +12,11 @@ #include #include #include +#include #include #include +#include #include #include @@ -203,3 +205,18 @@ struct smp_operations __initdata vexpress_smp_ops = { .cpu_die = vexpress_cpu_die, #endif }; + +void __init vexpress_smp_init_ops(void) +{ +#ifdef CONFIG_MCPM + /* + * The best way to detect a multi-cluster configuration at the moment + * is to look for the presence of a CCI in the system. + * Override the default vexpress_smp_ops if so. + */ + struct device_node *node; + node = of_find_compatible_node(NULL, NULL, "arm,cci"); + if (node && of_device_is_available(node)) + mcpm_smp_set_ops(); +#endif +} diff --git a/arch/arm/mach-vexpress/v2m.c b/arch/arm/mach-vexpress/v2m.c index 915683cb67..16b42c10e0 100644 --- a/arch/arm/mach-vexpress/v2m.c +++ b/arch/arm/mach-vexpress/v2m.c @@ -476,6 +476,7 @@ static const char * const v2m_dt_match[] __initconst = { DT_MACHINE_START(VEXPRESS_DT, "ARM-Versatile Express") .dt_compat = v2m_dt_match, .smp = smp_ops(vexpress_smp_ops), + .smp_init = smp_init_ops(vexpress_smp_init_ops), .map_io = v2m_dt_map_io, .init_early = v2m_dt_init_early, .init_irq = irqchip_init,