From patchwork Wed Jul 17 22:34:11 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 2829043 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CFD14C0AB2 for ; Wed, 17 Jul 2013 22:34:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 01243201C6 for ; Wed, 17 Jul 2013 22:34:49 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04B33201B7 for ; Wed, 17 Jul 2013 22:34:48 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UzaIy-0006vd-K7; Wed, 17 Jul 2013 22:34:40 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UzaIv-0001rr-Et; Wed, 17 Jul 2013 22:34:37 +0000 Received: from mail-qa0-f53.google.com ([209.85.216.53]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UzaIs-0001r3-Ry for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2013 22:34:35 +0000 Received: by mail-qa0-f53.google.com with SMTP id g10so1395698qah.19 for ; Wed, 17 Jul 2013 15:34:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version:content-type:x-gm-message-state; bh=JuJjIqqDHbLyfGd261JCDmQHQUH5mHYBWWGfuCi6hO8=; b=YtKaR48IoqcQHVa8sUmUYEQvM8hPqfsLEtkBve0cir4LX3j00qjecir2E3Upr553lh jeLabEBUQljyG3rNt10gRexl5lrBG7NRo2wsY2S87+9Qm+TWdV4/kbFfJQVhP9P7zzcd 8DOqr41rQ1dJCA11g+tfSS5DqfeWWN5bNMCd2tnWTEbxKGMpVBrHtRiaKkH1eLGZuoId 78BCbK9gZuNkdAIzeapA9CHz4VIi5C+zFIPPDAN/uQyJzmUCrJALbbEk696cOBWdT4wh XFtkIgY1OQO7pflkCH6S6SgN8j9q7jGFJHiWtFwoS8rdKFe5eKA+WtFrjUbnh27fPMyr gQTA== X-Received: by 10.49.15.130 with SMTP id x2mr10153394qec.47.1374100453296; Wed, 17 Jul 2013 15:34:13 -0700 (PDT) Received: from xanadu.home (modemcable044.209-83-70.mc.videotron.ca. [70.83.209.44]) by mx.google.com with ESMTPSA id 15sm13066471qaa.9.2013.07.17.15.34.11 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 17 Jul 2013 15:34:12 -0700 (PDT) Date: Wed, 17 Jul 2013 18:34:11 -0400 (EDT) From: Nicolas Pitre To: Stephen Boyd Subject: Re: [PATCH] irqchip: gic: Don't complain in gic_get_cpumask() if UP system In-Reply-To: <51E71249.4050200@codeaurora.org> Message-ID: References: <1373067573-29946-1-git-send-email-sboyd@codeaurora.org> <20130712111322.GC3213@e102654-lin.cambridge.arm.com> <20130712121023.GB27430@codeaurora.org> <51E71249.4050200@codeaurora.org> User-Agent: Alpine 2.03 (LFD 1266 2009-07-14) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQlckb7tu3UYczCBBmzy0RmpdDQriqcWlLQ5dlB4bwUwKnhnl3QpsHJz5IWTmTqI/iK26Oou X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130717_183434_974403_78FE6D2A X-CRM114-Status: GOOD ( 12.84 ) X-Spam-Score: -2.6 (--) Cc: Russell King , Javi Merino , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, 17 Jul 2013, Stephen Boyd wrote: > On 07/12/13 05:10, Stephen Boyd wrote: > > On 07/12, Javi Merino wrote: > >> I agree, we should drop the check. It's annoying in uniprocessors and > >> unlikely to be found in the real world unless your gic entry in the dt > >> is wrong. And that's a likely outcome in the real world. > >> > > Ok. How about this? > > Any comments? What about this instead: Nicolas diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index 19ceaa60e0..86d21bc6cb 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -368,7 +368,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic) break; } - if (!mask) + if (is_smp() && !mask) pr_crit("GIC CPU mask not found - kernel will fail to boot.\n"); return mask;