From patchwork Tue Jan 6 21:27:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Pitre X-Patchwork-Id: 5577491 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E83529F357 for ; Tue, 6 Jan 2015 21:29:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2709F20225 for ; Tue, 6 Jan 2015 21:29:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50791201BC for ; Tue, 6 Jan 2015 21:29:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y8bf8-0004MW-Al; Tue, 06 Jan 2015 21:27:38 +0000 Received: from mail-qa0-f52.google.com ([209.85.216.52]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y8bez-00045m-Hp for linux-arm-kernel@lists.infradead.org; Tue, 06 Jan 2015 21:27:30 +0000 Received: by mail-qa0-f52.google.com with SMTP id v10so186931qac.11 for ; Tue, 06 Jan 2015 13:27:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=wTpLBZZs69LVPmsYs7J2lnSj24GZGJR9xPaCy1V2y88=; b=PkrLQ+/qF+cWgMfxNorBbje7kODYQXGfOta/3DC9tGqn7rcbVEpnFRoUjyDaui70OI 4PscUD2YGux1PcBHv/6xia0bNZ2KytVILYUKjaPgdLvn2Yw3ufT9QeuYQ/ahUlV/nCvO 5+Wtj0yyijfop7BaR8P/mXuyEBYDJfssk9ouhGxpRGEux5LF8sJgJw98wmCC0ubyGKDJ f6AkCkkvV0PGRVEKYSk+5MP/Hl8KILOhibX3VMHKJ3VxugY5H7sAzpysjPRq/2l9ES6N oOhizpMtF2sYP7iM2V4i6W/+blo0aa1DiaZ1aP6PAYURvcmkLCw2KpFfBoKmVt4TkuOO AIzQ== X-Gm-Message-State: ALoCoQm7lsFKOZbJti1jrwTRoBPzQAaBOXNBoSNy7I/iTIWk2WZd3TJRLKU/8Z+uemlgL+o6vz98 X-Received: by 10.140.29.97 with SMTP id a88mr147769563qga.69.1420579628288; Tue, 06 Jan 2015 13:27:08 -0800 (PST) Received: from xanadu.home (modemcable142.180-131-66.mc.videotron.ca. [66.131.180.142]) by mx.google.com with ESMTPSA id w9sm38599274qab.18.2015.01.06.13.27.06 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 06 Jan 2015 13:27:07 -0800 (PST) Date: Tue, 6 Jan 2015 16:27:05 -0500 (EST) From: Nicolas Pitre To: Arnd Bergmann Subject: Re: [PATCH] Revert 9fc2105aeaaf56b0cf75296a84702d0f9e64437b to fix pyaudio (and probably more) In-Reply-To: Message-ID: References: <20150104190123.GA20153@amd> <20150105121126.GA10116@arm.com> <1923550.h5Fs9u5gUy@wuerfel> User-Agent: Alpine 2.11 (LFD 23 2013-08-11) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150106_132729_705591_2F4104C5 X-CRM114-Status: GOOD ( 20.15 ) X-Spam-Score: -0.7 (/) Cc: Marc Zyngier , Russell King - ARM Linux , Will Deacon , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 6 Jan 2015, Nicolas Pitre wrote: > On Tue, 6 Jan 2015, Arnd Bergmann wrote: > > > I think we still build RPC with gcc -march=armv3. Is that a problem > > with this patch? > > It is. > > Tangential question: does anyone still own a working RPC? > > For sure we no longer support the RPC unless it is fitted with a SA110. > And IIRC the reason why -march=armv3 is used in that case has to do with > the RPC memory bus not able to accommodate the SA110's LDRH/STRH > instructions. However it should be able to execute UMULL regardless. > > Now I could add ".arch armv7-a" in the file to make it compile for RPC. > I can't just make it ".arch armv4" as this prevents Thumb2 compilation > for that file. > > Other ideas? I settled on the following: That'll make things easier to sort out in the context of $tangential_question. Nicolas diff --git a/arch/arm/lib/Makefile b/arch/arm/lib/Makefile index 0573faab96..0eb8de1c6f 100644 --- a/arch/arm/lib/Makefile +++ b/arch/arm/lib/Makefile @@ -40,7 +40,10 @@ else lib-y += io-readsw-armv4.o io-writesw-armv4.o endif -lib-$(CONFIG_ARCH_RPC) += ecard.o io-acorn.o floppydma.o +ifeq ($(CONFIG_ARCH_RPC),y) + lib-y += ecard.o io-acorn.o floppydma.o + AFLAGS_delay-loop.o += -march=armv4 +endif $(obj)/csumpartialcopy.o: $(obj)/csumpartialcopygeneric.S $(obj)/csumpartialcopyuser.o: $(obj)/csumpartialcopygeneric.S