| Message ID | alpine.LNX.2.00.1106201035590.18991@swampdragon.chaosbits.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Jusper/Linus/All, On Mon, Jun 20, 2011 at 11:40 AM, Jesper Juhl <jj@chaosbits.net> wrote: > Remove the duplicate inclusion of linux/leds.h from > arch/arm/mach-s3c2410/h1940-bluetooth.c that was added by commit 50e2d10d. > > Signed-off-by: Jesper Juhl <jj@chaosbits.net> > --- > h1940-bluetooth.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-s3c2410/h1940-bluetooth.c b/arch/arm/mach-s3c2410/h1940-bluetooth.c > index 2c126bb..a5eeb62 100644 > --- a/arch/arm/mach-s3c2410/h1940-bluetooth.c > +++ b/arch/arm/mach-s3c2410/h1940-bluetooth.c > @@ -18,7 +18,6 @@ > #include <linux/leds.h> > #include <linux/gpio.h> > #include <linux/rfkill.h> > -#include <linux/leds.h> > > #include <mach/regs-gpio.h> > #include <mach/hardware.h> > > -- Some time ago I already sent a patch to handle all the headers duplication corrections. Please check this: https://lkml.org/lkml/2011/6/16/301 It should handle all the cases you described at: https://lkml.org/lkml/2011/6/20/72 https://lkml.org/lkml/2011/6/20/78 https://lkml.org/lkml/2011/6/20/75 I didn't receive any comments and still can see that it's not in mainline Linus' tree. Thanks, Vitaliy
Hello. On 20-06-2011 12:40, Jesper Juhl wrote: > Remove the duplicate inclusion of linux/leds.h from > arch/arm/mach-s3c2410/h1940-bluetooth.c that was added by commit 50e2d10d. Pelase also specify that commit's summary in parens. > Signed-off-by: Jesper Juhl<jj@chaosbits.net> WBR, Sergei
On Mon, 20 Jun 2011, Sergei Shtylyov wrote: > Hello. > > On 20-06-2011 12:40, Jesper Juhl wrote: > > > Remove the duplicate inclusion of linux/leds.h from > > arch/arm/mach-s3c2410/h1940-bluetooth.c that was added by commit 50e2d10d. > > Pelase also specify that commit's summary in parens. > Anyone can just do a "git show 50e2d10d" to read it. But sure, here's a new patch description: Remove the duplicate inclusion of linux/leds.h from arch/arm/mach-s3c2410/h1940-bluetooth.c that was added by commit 50e2d10d (ARM: S3C2410: H1940: Use leds-gpio driver for LEDs managing). > > Signed-off-by: Jesper Juhl<jj@chaosbits.net> > > WBR, Sergei >
On Mon, 20 Jun 2011, Vitaliy Ivanov wrote: [...] > Some time ago I already sent a patch to handle all the headers > duplication corrections. Please check this: > > https://lkml.org/lkml/2011/6/16/301 > > It should handle all the cases you described at: > > https://lkml.org/lkml/2011/6/20/72 > https://lkml.org/lkml/2011/6/20/78 > https://lkml.org/lkml/2011/6/20/75 > > I didn't receive any comments and still can see that it's not in > mainline Linus' tree. > Ok, I was not aware of that patch. I'll take a look at it later when I have some more time.
On Mon, Jun 20, 2011 at 12:34:37PM +0200, Jesper Juhl wrote: > On Mon, 20 Jun 2011, Sergei Shtylyov wrote: > > > Hello. > > > > On 20-06-2011 12:40, Jesper Juhl wrote: > > > > > Remove the duplicate inclusion of linux/leds.h from > > > arch/arm/mach-s3c2410/h1940-bluetooth.c that was added by commit 50e2d10d. > > > > Pelase also specify that commit's summary in parens. > > > > Anyone can just do a "git show 50e2d10d" to read it. But sure, here's a > new patch description: Anyone with git can. Those without git can't (eg, because they're using some other tool for source management.) This is why Linus requires commit IDs to be followed by their summary. Please ensure that you always include the summary along with the git commit id.
diff --git a/arch/arm/mach-s3c2410/h1940-bluetooth.c b/arch/arm/mach-s3c2410/h1940-bluetooth.c index 2c126bb..a5eeb62 100644 --- a/arch/arm/mach-s3c2410/h1940-bluetooth.c +++ b/arch/arm/mach-s3c2410/h1940-bluetooth.c @@ -18,7 +18,6 @@ #include <linux/leds.h> #include <linux/gpio.h> #include <linux/rfkill.h> -#include <linux/leds.h> #include <mach/regs-gpio.h> #include <mach/hardware.h>
Remove the duplicate inclusion of linux/leds.h from arch/arm/mach-s3c2410/h1940-bluetooth.c that was added by commit 50e2d10d. Signed-off-by: Jesper Juhl <jj@chaosbits.net> --- h1940-bluetooth.c | 1 - 1 file changed, 1 deletion(-)