From patchwork Sun Feb 5 10:00:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Ulli Kroll X-Patchwork-Id: 9556037 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F230E602B1 for ; Sun, 5 Feb 2017 10:02:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E0CEA2684F for ; Sun, 5 Feb 2017 10:02:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D36C51FF12; Sun, 5 Feb 2017 10:02:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7DC561FF12 for ; Sun, 5 Feb 2017 10:02:12 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1caJe5-0001qY-8w; Sun, 05 Feb 2017 10:02:09 +0000 Received: from mail-wm0-f68.google.com ([74.125.82.68]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1caJe2-0001eO-CM for linux-arm-kernel@lists.infradead.org; Sun, 05 Feb 2017 10:02:08 +0000 Received: by mail-wm0-f68.google.com with SMTP id v77so14948551wmv.0 for ; Sun, 05 Feb 2017 02:01:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=dXm/3r/DcLAsVW2ZornIT+pGpL7r8jcxafjbeVigStA=; b=QXI3/l+DrXdUIXWtOvXNFGJesiuDI90WVQIeDIC/+Jq7F/d5xw68Vn4FLVPKbuahoR e6YZPSBml8ThhlutSIaBsvKX7v50SEkESkIfArheiDEFhYUi6uCIsxicLe82G6HUQLgi xO//URuOG7Lvw94kN/YrwQllDsNrfnZbVCS5t29oLuC1eFt5aCEbijIBZyMyeteAPTDj s5u0fWoOajrIClgxVEAcjNO7LqxV/lFlKpFt/+Vi2Mdn6Cm0oC+XbqAalzWX19hhKj5t yWifxMT3vL6hcn7Y7AEVYSWxB/4O/u9PkX19gs+hf1iOiSwN9KNnu0iawRuOcYRHQnRF 7flg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=dXm/3r/DcLAsVW2ZornIT+pGpL7r8jcxafjbeVigStA=; b=efPiGnMDlH0OQzdAwpYRB8M18XeK3OgVcDQ3aWIfhUeWslINcvS+6OCAJMOPvhucdB fP2kUMyzWOTCLScHQMaJk75kzmssdDqhuZqrScMeZPHISihpEb2SBPkrSrXIDYvQ1z0N LPuLvL+cZ/WVSm+v48mnFXU7+DxBq6yk+gSai3hlMolQleoxsUXVi6N4CF6RT1pzIdeA Z//8zal63yzVk1WX+SH4UUrr4vD0iO34UZf2Ipmu6wJ6jOUcsTuzCM3BwcETvfedckwp NmLjfpkGrCmr7hsBxYdNWzZNfUxfRptzesIgMCuy1oxL4UsfwJsYKlmXJLWXAI+Q/jKM 6yrA== X-Gm-Message-State: AIkVDXIilKLPp8N5FFw4LfYL8a7ln750xbttAq3+UK2H2CYMwFpzJQ1oFe0FPaFSMpA3Hw== X-Received: by 10.223.146.196 with SMTP id 62mr4603118wrn.199.1486288844672; Sun, 05 Feb 2017 02:00:44 -0800 (PST) Received: from localhost (cable-78-34-25-212.netcologne.de. [78.34.25.212]) by smtp.gmail.com with ESMTPSA id z134sm6652362wmc.20.2017.02.05.02.00.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 05 Feb 2017 02:00:44 -0800 (PST) Date: Sun, 5 Feb 2017 11:00:41 +0100 (CET) From: Hans Ulli Kroll X-X-Sender: elektroman@T420s To: Linus Walleij Subject: Re: [PATCH 2/4] PCI: add driver for Cortina Gemini Host Bridge In-Reply-To: <20170128204839.18330-2-linus.walleij@linaro.org> Message-ID: References: <20170128204839.18330-1-linus.walleij@linaro.org> <20170128204839.18330-2-linus.walleij@linaro.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170205_020206_578926_94C81BF8 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: openwrt-devel@openwrt.org, Florian Fainelli , Paulius Zaleckas , linux-pci@vger.kernel.org, Hans Ulli Kroll , Bjorn Helgaas , Janos Laube , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Linus while debugging my boot issues on my NAS 4220, I saw this warning irq: type mismatch, failed to map hwirq-26 for /soc/interrupt-controller@48000000! We need to use the use the use the PCI IRQ from gemini as root for the irq domain, not the next one in DT. diff --git a/drivers/pci/host/pci-gemini.c b/drivers/pci/host/pci-gemini.c index 7051dd992114..bb564a8e6379 100644 --- a/drivers/pci/host/pci-gemini.c +++ b/drivers/pci/host/pci-gemini.c @@ -217,7 +217,6 @@ static const struct irq_domain_ops gemini_pci_irqdomain_ops = { static int gemini_pci_setup_irq(struct gemini_pci *p, int irq) { - struct device_node *intc = of_get_next_child(p->dev->of_node, NULL); int i; if (!intc) { @@ -225,7 +224,7 @@ static int gemini_pci_setup_irq(struct gemini_pci *p, int irq) return -EINVAL; } - p->irqdomain = irq_domain_add_linear(intc, 4, + p->irqdomain = irq_domain_add_linear(p->dev->of_node, 4, &gemini_pci_irqdomain_ops, p); if (!p->irqdomain) {