From patchwork Mon Apr 24 16:53:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Ulli Kroll X-Patchwork-Id: 9696805 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 50BE1603F3 for ; Mon, 24 Apr 2017 17:06:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3BB902522B for ; Mon, 24 Apr 2017 17:06:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2F13F28404; Mon, 24 Apr 2017 17:06:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 478102522B for ; Mon, 24 Apr 2017 17:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DS6wyET19E/4h+nMR8W/dShMiInmEBT8yng8m2LC6M8=; b=OxeS8HxZVZ2Q91 9Tpe3wm4KcdLf9VoIi2k2d6FfqyRXDfYF8qc+FJsaua2e3Yyd11TP0ovDua8hS34iu7sybhWpnXtJ DjCZItRdMh3mLTfv5Preygn9gyLqX1fyNR839aEWTXYGYhHNZo98H50ez9zfqpV5/l5GhutA3nLF/ aALPN9UsSJ53sdZTTNOHe650bGotMI9CEojnI02nygMMvkQuVSJlKsjwAXLhsRGH55I0AJ4I6RPE9 0qbPP5wcAIAh2p0JGZlrJhQiJM9s1ZexqGB0oTg3SNm9DNuK9eZhbRx5WrCWjcQIULjkVpqzIyupI Rd9PCtnf6ZIFS6QoKqHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1d2hQz-0008Sy-AP; Mon, 24 Apr 2017 17:05:57 +0000 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d2hFc-0008O4-Mz for linux-arm-kernel@lists.infradead.org; Mon, 24 Apr 2017 16:54:16 +0000 Received: by mail-wm0-x241.google.com with SMTP id u65so18719180wmu.3 for ; Mon, 24 Apr 2017 09:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=W2uQkaojyXI/VPGs8KUDxFJnlGDrp+Gbr2vXAOLDuTY=; b=EEFzhDJELMjH2jel1Ra59ZV/eLNZ35ZzZi5GKBKYpRIzvr1c+D6CPDWS9G3NppSSTp TPlA5qn+FKhTOwDmrekN+5CdBFIyfQADch5H4C33brgdUhBgSWo1o8mxToIXld2IJpEV /lu0L6yZWJvFfiY8roRVrmnYgcdEIpNx2aXC2II6x/ieGs6067ILwV53rNa/D7/4UBEN pQ6k7lBZiVheP1z1oSCrfccZIk3Um1TGPU01mlsZ/BefIJ7ohFoSfGfeamZ14/Qo6zZi pyrzFeg07oU0VFe02tGT9NaLZpnd4dI496KxrCZ7PF2NCNw6G+U2AVsMdLQSeNb7ApE9 ATjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=W2uQkaojyXI/VPGs8KUDxFJnlGDrp+Gbr2vXAOLDuTY=; b=efW9AImtFDgmlhOdDoQALHSjRjWmrELB3INqyNkxlLwaprNuIPZJD1kAU/btrAG5/2 xosI2Vt+oElS7TAMnaZDRWThEp0b+Mj4GBb3ptEEMr0M5gSmBQFDnEP7FMBPSVQ/xouh GMb9rmMgvnGxWx8u8i6HjlkTXcCx/WBz7btCvgTuVVEEYuXY/8I3SQYmmRafmc6ZxN6t JIDNPU4z9b4vMXh8BMf9148el0DIDBNbe9t94iBhCZu59g0+FsMJUH52CPpFDfbJ0AKz anb0s7ce3Efdg9nRaLMJfMXh8G++YO117zAuoePfyFjgD6YEfdq+9WCeM0a7uSKHRs3q 8pYQ== X-Gm-Message-State: AN3rC/6XU2/Y4kDbjFmbJUx0f31Nq88BHqzZ8ncCSPy57xkVUG56R8jq GZibGsK/NFo5/A== X-Received: by 10.28.69.73 with SMTP id s70mr10188624wma.33.1493052830558; Mon, 24 Apr 2017 09:53:50 -0700 (PDT) Received: from localhost (cable-78-35-118-8.netcologne.de. [78.35.118.8]) by smtp.gmail.com with ESMTPSA id s82sm945062wmb.33.2017.04.24.09.53.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Apr 2017 09:53:49 -0700 (PDT) Date: Mon, 24 Apr 2017 18:53:10 +0200 (CEST) From: Hans Ulli Kroll X-X-Sender: elektroman@T420s To: Linus Walleij Subject: Re: [PATCH 1/5 v3] usb: host: add DT bindings for faraday fotg2 In-Reply-To: <20170421204058.6206-1-linus.walleij@linaro.org> Message-ID: References: <20170421204058.6206-1-linus.walleij@linaro.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170424_095413_144588_497BE606 X-CRM114-Status: GOOD ( 15.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: openwrt-devel@openwrt.org, devicetree@vger.kernel.org, Florian Fainelli , Paulius Zaleckas , Greg Kroah-Hartman , Hans Ulli Kroll , linux-usb@vger.kernel.org, Janos Laube , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Linus On Fri, 21 Apr 2017, Linus Walleij wrote: > From: Hans Ulli Kroll > > This adds device tree bindings for the Faraday FOTG2 > dual-mode host controller. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Hans Ulli Kroll > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v3: > - Change compatible to "faraday,fotg210" as the name of the > hardware block. > - Add an elaborate SoC-specific compatible string for the > Cortina Systems Gemini so that SoC-specific features can > be enabled. > - Add cortina,gemini-mini-b to indicate a Gemini PHY with > a Mini-B adapter connected. > - Indicated that the Gemini version can handle "wakeup-source". > - Add optional IP block clock. > --- > .../devicetree/bindings/usb/faraday,fotg210.txt | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/faraday,fotg210.txt > Got NAK'ed from Rob on some ealier round due missing "device mode" on this IP. I've blatantly overrided this to a host only driver. These are the needed changes in DT to support both modes Note the -dr at the end of fotg210, to reflect this in an dual role device diff --git a/Documentation/devicetree/bindings/usb/faraday,fotg210.txt b/Documentation/devicetree/bindings/usb/faraday,fotg210.txt index cf06808303e2..862cda19e9d3 100644 --- a/Documentation/devicetree/bindings/usb/faraday,fotg210.txt +++ b/Documentation/devicetree/bindings/usb/faraday,fotg210.txt @@ -13,6 +13,9 @@ Required properties: Optional properties: - clocks: should contain the IP block clock - clock-names: should be "PCLK" for the IP block clock +- dr_mode : indicates the working mode for "fotg210-dr" compatible + controllers. Can be "host", "peripheral". Default to + "host" if not defined for backward compatibility. Required properties for "cortina,gemini-usb" compatible: - syscon: a phandle to the system controller to access PHY registers @@ -25,7 +28,7 @@ Optional properties for "cortina,gemini-usb" compatible: Example for Gemini: usb@68000000 { - compatible = "cortina,gemini-usb", "faraday,fotg210"; + compatible = "cortina,gemini-usb", "faraday,fotg210-dr"; reg = <0x68000000 0x1000>; interrupts = <10 IRQ_TYPE_LEVEL_HIGH>; clocks = <&cc 12>;