From patchwork Mon Aug 18 20:58:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugh Dickins X-Patchwork-Id: 4739241 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 344189F377 for ; Mon, 18 Aug 2014 21:04:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2E7F520125 for ; Mon, 18 Aug 2014 21:04:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25F4420108 for ; Mon, 18 Aug 2014 21:04:47 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XJU2p-000391-U7; Mon, 18 Aug 2014 21:00:47 +0000 Received: from mail-pa0-x22a.google.com ([2607:f8b0:400e:c03::22a]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XJU2m-000325-VE for linux-arm-kernel@lists.infradead.org; Mon, 18 Aug 2014 21:00:45 +0000 Received: by mail-pa0-f42.google.com with SMTP id lf10so8602924pab.1 for ; Mon, 18 Aug 2014 14:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version:content-type; bh=o7s0ESOOts/kL/PnjpmSpwIOrd239ZaC/l4C1KwBrQU=; b=aKTHPzkMVFH8Xgk7n7TTZCht32z1qmZrcxygOKO+9Oo81r0uIRTmQowi+FS/g96Oqe ZbbQMnaF0EnXZLYUt3FFz9XEmQ/Wq2/LgMvS41614ZSuFJb302lu77YcvnvrMttfasvl wqbJKcnMa6++nq4on/RcC60686rkekwl0+SvdKCcFNFG64w8dLQMQnjtZCoommtevgf7 DbxzesKG3OGPlVgMTwY7kyAti+1wNOFU9jRrbos94W49ycmC/vOE00r1ewRBG17GeaIb IzgaGtVb9R1aaWTFQP+xvsbijFPDC+0ZzBlPbWoOraRu9ToN8k64eUYXIs0+TM8U09mU +Hbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=o7s0ESOOts/kL/PnjpmSpwIOrd239ZaC/l4C1KwBrQU=; b=NdZjX/TAZGRu/HD1fnL5e7DiQM/xKXJ+bBvjS5iIJeepxMR45djnR2mMSY6ciNOzwI kfULrJfeW9Tw5ZAy79XXeobM3YPMaZnEeJKcrgyThid4MPwuRaS+mcS/8OspiNXTBWGm /VPjElRHc5lShJQL0S/0oD9BloMgpmdRis92lui7pHvoc7s5ssviLsMV4uMVONtu4Wxf nD8XQFMuL55LWs0C4W92dUGQu6GPzL0WHE15Lx4304OCxcaNFSUl/HRYszSmX1u16Jsh o89v+/rO9vn9wcATR7m8QS6TgqegiHpxC0Cl33GP+4Mm7IF7yvcQqmBDLJTBY0rqq7jU zN2g== X-Gm-Message-State: ALoCoQlqz2GIJdhD+rSOahklrv5xMC49EBIOoZL8EhyunqHgEVfFBaKDtlaOijuOL21xI8XhxDkT X-Received: by 10.68.132.10 with SMTP id oq10mr38549433pbb.132.1408395620786; Mon, 18 Aug 2014 14:00:20 -0700 (PDT) Received: from [100.110.47.20] ([104.132.1.100]) by mx.google.com with ESMTPSA id kb12sm17060027pbd.80.2014.08.18.14.00.14 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 Aug 2014 14:00:19 -0700 (PDT) Date: Mon, 18 Aug 2014 13:58:26 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Felipe Balbi Subject: Re: Lock Directory failure In-Reply-To: <20140818163209.GJ9662@saruman.home> Message-ID: References: <20140818163209.GJ9662@saruman.home> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140818_140045_050305_357F3FF6 X-CRM114-Status: GOOD ( 18.16 ) X-Spam-Score: -1.5 (-) Cc: Stephen Rothwell , "Eric W. Biederman" , linux-kernel@vger.kernel.org, Al Viro , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 18 Aug 2014, Felipe Balbi wrote: > Hi folks, > > with today's Linux next I keep getting below kernel error rather > frequently with my beagle bone black (ARM Cortex A8): > > [ 5.096203] systemd[1]: Mounting User Runtime Directory... > Mounting User Runtime Directory... > [ 5.135060] systemd[1]: Mounting Lock Directory... > Mounting Lock Directory... > [ 5.183453] systemd[1]: Started Various fixups to make systemd work better on Debian. > [ 5.248340] systemd[1]: Starting Load Random Seed... > [ 5.295601] Unable to handle kernel paging request at virtual address 6c617578 > [ 5.303340] pgd = de5c0000 > [ 5.306169] [6c617578] *pgd=00000000 > [ 5.309969] Internal error: Oops: 805 [#1] SMP ARM > [ 5.314972] Modules linked in: > [ 5.318170] CPU: 0 PID: 1092 Comm: mount Not tainted 3.17.0-rc1-next-20140818-00002-gd236526 #636 > [ 5.327433] task: de6d0dc0 ti: de350000 task.ti: de350000 > [ 5.333082] PC is at mnt_set_mountpoint+0x80/0x94 > [ 5.337996] LR is at _raw_spin_unlock+0x20/0x24 > [ 5.342723] pc : [] lr : [] psr: 20000013 > [ 5.342723] sp : de351eb8 ip : 00000000 fp : 00000000 > [ 5.354705] r10: de024dc0 r9 : de250740 r8 : c01487ac > [ 5.360157] r7 : de024dc0 r6 : ddd44468 r5 : de1ecc40 r4 : de250740 > [ 5.366969] r3 : 6c617574 r2 : de1eccb8 r1 : de6d0dc0 r0 : ddd444c8 > [ 5.373783] Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user > [ 5.381230] Control: 10c5387d Table: 9e5c0019 DAC: 00000015 > [ 5.387226] Process mount (pid: 1092, stack limit = 0xde350248) > [ 5.393405] Stack: (0xde351eb8 to 0xde352000) > [ 5.397952] 1ea0: de1ecc68 de1ecc40 > [ 5.406490] 1ec0: de1ecc40 00000000 c0824380 c0148690 00000001 00000000 c01487ac 00000000 > [ 5.415028] 1ee0: ddd44468 00000000 de022000 de1ecc40 de250740 de351f38 00000027 de6a7180 > [ 5.423567] 1f00: de151740 00000000 00000000 c01487ac 00000008 00000027 c087c3c0 de1ecc50 > [ 5.432105] 1f20: c0874cc0 c0149864 de6ae000 de6ae000 000250d8 c0080d4c de024dd0 ddd44468 > [ 5.440644] 1f40: de6aefff 00000000 21977150 00001000 de351f8c 00000000 de1e1000 000250b8 > [ 5.449182] 1f60: c0ed000e c000e604 de350000 00000000 000250d8 c014a52c de6ae000 00000006 > [ 5.457720] 1f80: c000e604 de151740 de6a7180 de6ae000 c0ed000e 00025150 00023548 c0ed000e > [ 5.466259] 1fa0: 00000015 c000e440 00025150 00023548 000250b8 000250c8 000250d8 c0ed000e > [ 5.474797] 1fc0: 00025150 00023548 c0ed000e 00000015 be8deb7c 00000000 00025150 000250d8 > [ 5.483335] 1fe0: b6e125f0 be8deaf8 0000c708 b6e12600 60000010 000250b8 00000000 00000000 > [ 5.491887] [] (mnt_set_mountpoint) from [] (attach_recursive_mnt+0x278/0x294) > [ 5.501244] [] (attach_recursive_mnt) from [] (do_add_mount+0x90/0xd8) > [ 5.509875] [] (do_add_mount) from [] (do_mount+0x234/0xb78) > [ 5.517599] [] (do_mount) from [] (SyS_mount+0x84/0xb8) > [ 5.524877] [] (SyS_mount) from [] (ret_fast_syscall+0x0/0x48) > [ 5.532783] Code: e594300c e2852078 e3530000 e5853078 (15832004) > [ 5.539224] ---[ end trace 29fe002647800da6 ]--- > > since that's mounted as tmpfs, adding Hugh [PATCH next] vfs: initialize m_list to fix crash in mnt_set_mountpoint Fix mnt_set_mountpoint() crash: new_mountpoint() must initialize m_list. Reported-by: Felipe Balbi Signed-off-by: Hugh Dickins --- fs/namespace.c | 1 + 1 file changed, 1 insertion(+) --- 3.17-rc1-next/fs/namespace.c 2014-08-18 12:26:26.619992661 -0700 +++ linux/fs/namespace.c 2014-08-18 13:02:42.948389147 -0700 @@ -738,6 +738,7 @@ static struct mountpoint *new_mountpoint mp->m_dentry = dentry; mp->m_count = 1; + INIT_HLIST_HEAD(&mp->m_list); hlist_add_head(&mp->m_hash, chain); return mp; }