From patchwork Tue Feb 14 16:09:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cristian Birsan X-Patchwork-Id: 9572209 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E90E560573 for ; Tue, 14 Feb 2017 16:26:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DDE371FFAD for ; Tue, 14 Feb 2017 16:26:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D1C18205A4; Tue, 14 Feb 2017 16:26:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 871801FFAD for ; Tue, 14 Feb 2017 16:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WGhqlU2p5h3e/dbObTVH6pQSzBGaAl4DevW5t/5yFLg=; b=Y4Xm2D6hlok0UQ EkJXH1JSLbubR1zSVUa/jRoif6LNYBLSmalWVMtMJ+T0XxJdOvzcWO+7i/gq5JvfKhf7cr5PbVybk 275hE3gxkMd8etsVmisBL8EREbZWkQEmp0DsHn/0tHzJdt9md6bxwjs0nxde29ODFtvR0zYEg5PWO 66x5OlBauPrVDynOQEwouDfvrm+QoZVwoZXMyqj7H0uHhnR/mMLmt/5tYhzffalevHhdKlqwluRkG NKYAShQLx1QVvULT6vbhzoE1n94/9mrXDf86o7VSZacKQGFwBa6fhBJqj4RUGTr5ZO3P981DhkY6k ZPASQ2yaCgscKe1t67yQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cdfw4-0003M3-57; Tue, 14 Feb 2017 16:26:36 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cdfjv-0004uw-Po for linux-arm-kernel@bombadil.infradead.org; Tue, 14 Feb 2017 16:14:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=b98v/W9ny+h0ZJIM/dAZyBiyeQJu693N7JzebBnwnlY=; b=L5e4mAGLM34kmP2j8Cn6tW84a wJl6a0voFyDh7Gddlg3dl+MKD/9wEFzpFHs7R/GAT5O8Xcadu35nBl1gitVyJDwcZ5Lo8R88QzPzv gSUJUlMF2yiL34DYUu4zCwi/ySz+IR0Gy3koWMLCBbTiepqNEqgxfS3FBEVLwu6nGs4YedySt9NvM SyK94JHupSjI1B0V3pyU5PI1mUqcLHr2FBFaLtN8qjUgmDNL2iyv8uxrjwuwKtSKAjMi7L7bMtaSU oayVIXvXmWwfQo5hPbv/0KZYiHOhZfEr147lJeZvFXVjV9PiIs7kLYLdmxGuVL34Cy/ZlOnArPBW+ 9geXAKDRA==; Received: from smtpout.microchip.com ([198.175.253.82] helo=email.microchip.com) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cdfgd-0004wa-KB for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2017 16:10:41 +0000 Received: from cristi-lnx.microchip.com (10.10.76.4) by chn-sv-exch06.mchp-main.com (10.10.76.107) with Microsoft SMTP Server id 14.3.181.6; Tue, 14 Feb 2017 09:10:19 -0700 From: To: , , , , , Subject: [PATCH 3/4 linux-next] usb: gadget: udc: atmel: Use dev_warn() to display EP configuration error Date: Tue, 14 Feb 2017 18:09:05 +0200 Message-ID: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170214_161039_795051_BACBC393 X-CRM114-Status: UNSURE ( 8.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: boris.brezillon@free-electrons.com, ludovic.desroches@atmel.com, alexandre.belloni@free-electrons.com, Cristian Birsan Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Cristian Birsan Use dev_warn() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan --- drivers/usb/gadget/udc/atmel_usba_udc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 3becb28..50f018a 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -1851,7 +1851,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid) * but it's clearly harmless... */ if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED)) - dev_dbg(&udc->pdev->dev, + dev_warn(&udc->pdev->dev, "ODD: EP0 configuration is invalid!\n"); /* Preallocate other endpoints */ @@ -1860,8 +1860,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid) ep = &udc->usba_ep[i]; usba_ep_writel(ep, CFG, ep->ept_cfg); if (!(usba_ep_readl(ep, CFG) & USBA_EPT_MAPPED)) - dev_dbg(&udc->pdev->dev, - "ODD: EP%d configuration is invalid!\n", i); + dev_warn(&udc->pdev->dev, + "ODD: EP%d configuration is invalid!\n", i); } }