| Message ID | bae6ad6c04f7567b224e008ab27b32d2dac1d9c1.1471125083.git.ccc94453@vip.cybercity.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 11, 2016 at 10:11:51PM +0200, Rask Ingemann Lambertsen wrote: > Shenzhen Sunchip Technology Co., Ltd produces TV boxes and TV dongles, > some of which are sold under other brands. Website: > <URL:http://www.sunchip-tech.com/> > > Signed-off-by: Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> > --- > Changes in v2: > No patch changes, but added CC to the ARM kernel mailing list. > > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 1992aa9..fbad2cea 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -256,6 +256,7 @@ ste ST-Ericsson > stericsson ST-Ericsson > syna Synaptics Inc. > synology Synology, Inc. > +sunchip Shenzhen Sunchip Technology Co., Ltd > SUNW Sun Microsystems, Inc These are not in alphabetical order. Maybe someone thought uppercase should be separate, but I don't. So please fix the ordering here moving SUNW before syna. Rob
On Tue, Aug 16, 2016 at 07:56:24AM -0500, Rob Herring wrote: > On Thu, Aug 11, 2016 at 10:11:51PM +0200, Rask Ingemann Lambertsen wrote: > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > > index 1992aa9..fbad2cea 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > > @@ -256,6 +256,7 @@ ste ST-Ericsson > > stericsson ST-Ericsson > > syna Synaptics Inc. > > synology Synology, Inc. > > +sunchip Shenzhen Sunchip Technology Co., Ltd > > SUNW Sun Microsystems, Inc > > These are not in alphabetical order. Maybe someone thought uppercase > should be separate, but I don't. So please fix the ordering here moving > SUNW before syna. I'm new to this, so I could use a bit of guidance here. Is it OK if I send a follow-up patch to fix the ordering or should I send a patch to fix the ordering first, before the sunchip prefix is added? I never considered the possibility that the list wouldn't be in alphabetical order to begin with, so the brain power went into deciding if uppercase should be sorted separately.
On Tue, Aug 16, 2016 at 1:28 PM, Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> wrote: > On Tue, Aug 16, 2016 at 07:56:24AM -0500, Rob Herring wrote: >> On Thu, Aug 11, 2016 at 10:11:51PM +0200, Rask Ingemann Lambertsen wrote: >> > >> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt >> > index 1992aa9..fbad2cea 100644 >> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt >> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt >> > @@ -256,6 +256,7 @@ ste ST-Ericsson >> > stericsson ST-Ericsson >> > syna Synaptics Inc. >> > synology Synology, Inc. >> > +sunchip Shenzhen Sunchip Technology Co., Ltd >> > SUNW Sun Microsystems, Inc >> >> These are not in alphabetical order. Maybe someone thought uppercase >> should be separate, but I don't. So please fix the ordering here moving >> SUNW before syna. > > I'm new to this, so I could use a bit of guidance here. Is it OK if I > send a follow-up patch to fix the ordering or should I send a patch to > fix the ordering first, before the sunchip prefix is added? For this, just doing it all in one patch is fine. If you want to do 2 patches, then fix SUNW first then add sunchip. > I never considered the possibility that the list wouldn't be in > alphabetical order to begin with, so the brain power went into deciding > if uppercase should be sorted separately. Even if uppercase is sorted after lowercase, you've got it in the wrong place. Rob
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 1992aa9..fbad2cea 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -256,6 +256,7 @@ ste ST-Ericsson stericsson ST-Ericsson syna Synaptics Inc. synology Synology, Inc. +sunchip Shenzhen Sunchip Technology Co., Ltd SUNW Sun Microsystems, Inc tbs TBS Technologies tcg Trusted Computing Group
Shenzhen Sunchip Technology Co., Ltd produces TV boxes and TV dongles, some of which are sold under other brands. Website: <URL:http://www.sunchip-tech.com/> Signed-off-by: Rask Ingemann Lambertsen <ccc94453@vip.cybercity.dk> --- Changes in v2: No patch changes, but added CC to the ARM kernel mailing list. Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)