From patchwork Mon Sep 3 13:10:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10585837 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6745D14BD for ; Mon, 3 Sep 2018 13:15:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 559F8297B6 for ; Mon, 3 Sep 2018 13:15:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 473B3297C2; Mon, 3 Sep 2018 13:15:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 502BA297B6 for ; Mon, 3 Sep 2018 13:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=YDjqBdfJ/L1zVkWhloinPnYlKr1a0EPSYSLFYWJAkH0=; b=tf2C+ha2/vyuj8vwj7t1nZbjbB hcVmQZNo4F5tllDYUT7a56SYa4da67sJ6EnNHnzk438uwrtKhMnI4i+77F1158n/f+mDnL9VStAZr 9dDDiGOJ2hFgzpCdm+VXxWfWPfaKdztM7ABadZ3NbanmkbdRrYuOnSL6TJ14j/keQsH8mAN3DN2p0 W9rEOqnh3PJfcW4k9fa4PFwxsTThi4neFKJw+1PszF/x9V2qx6njoaj4HvrojWdJexBPgBHYE8LEn xR+L4RlzseawKSV/IvxbNvM+4EWqT5S8gUIIQ9+DTdHLGxFQrfG7XF4rZloqcWjDU9Z9jhqxWFoQt qjO6RQQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fwogx-0002bO-Dn; Mon, 03 Sep 2018 13:14:55 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fwodO-0000pI-Gx for linux-arm-kernel@lists.infradead.org; Mon, 03 Sep 2018 13:11:17 +0000 Received: by mail-wr1-x443.google.com with SMTP id j26-v6so639328wre.2 for ; Mon, 03 Sep 2018 06:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=wTOILdE9nfHQCYMiecBgy4uyHPVuopq9iik1VZDg6mA=; b=ri1Dz7m59TtHxVJMvmQAzX93b2miaZDK+w8fHLMXjXDn0Hik99zFO+Rt1N2CrTGna6 /865xQZZ9F09gkGUlQcpU/UcvAJHLfFq1TlhOV3PyIcRDK6cfwn/QCMlMjva0+k+/9nu ZAYKWb4tGwymAuU+o5uljVd7gR26kM8ByJ3/o4hQTh15MfiKnl+ndP6vQoanLuuyAUvF GNKhqvZ2ZdkJ+MfZfFGF22KJp/MG5ExU7hnWSnTzFjHdzPvXOq8DMU7mBC8NBp4tMdvo LjFzdSfndYz/tDYqHLIZp7mV0MyHihfGMqx1S2zclXyIZIiJO70kH5EZzBGU//+dWTi8 vzbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=wTOILdE9nfHQCYMiecBgy4uyHPVuopq9iik1VZDg6mA=; b=s9VHb51PP9PwEdLVvIWwQ6s6TmjYLEg3HU0VPACOGjtNXsC10NxxjXzS/mLLbslQiT mPBVgToWQeBZUpcawvokVg7ttm12dKKojUT/c0Javf/GMbDqAaELqFmSkd2vnj+ZFARp 8cZyk1UQFatdFk2LgJzHJKJrhNhxxUG7zpyWxugWR2BBIWiWdhVt3lO8lbsvoU6LMQyy gklvX0ZVW6c5iQ29FLOGFkqXI4+nPNSX6wACLhrDUFF6VnBehyxEyVhaP12z+2ETOARr g7vy1X6mIqOvV32pQQBh9XGbJQYv2RjLPB4fhWzV7/LekYksolKubjuq5bzji3dpyNWC dGUQ== X-Gm-Message-State: APzg51Bl8YP547YgUhon7SbDkUYk32eGCrYOeMBeTdIBepxivwtxkewJ W1o28iCAwxpDURxTWeKtbMBVyg== X-Google-Smtp-Source: ANB0VdZZ1kcMQunUqBPmqO9KVMDszD/YeV47Dm/+4CSPjDx1Dh7tfIV5ksMIyifhfaG7vmxE9lt0Dg== X-Received: by 2002:adf:9ae5:: with SMTP id a92-v6mr20443936wrc.125.1535980263184; Mon, 03 Sep 2018 06:11:03 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id f132-v6sm11314920wme.24.2018.09.03.06.11.02 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 03 Sep 2018 06:11:02 -0700 (PDT) From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu, gnomes@lxorguk.ukuu.org.uk, Alexander Graf , shubhraj@xilinx.com, robh@kernel.org Subject: [PATCH v3 02/10] serial: uartps: Do not initialize field to zero again Date: Mon, 3 Sep 2018 15:10:50 +0200 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180903_061114_589376_9883B37B X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Writing zero and NULLs to already initialized fields is not needed. Remove this additional writes. Signed-off-by: Michal Simek --- Changes in v3: None Changes in v2: - new patch - it can be sent separately too drivers/tty/serial/xilinx_uartps.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index dd905c981f67..9a08542cec47 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1502,15 +1502,12 @@ static int cdns_uart_probe(struct platform_device *pdev) /* At this point, we've got an empty uart_port struct, initialize it */ spin_lock_init(&port->lock); - port->membase = NULL; - port->irq = 0; port->type = PORT_UNKNOWN; port->iotype = UPIO_MEM32; port->flags = UPF_BOOT_AUTOCONF; port->ops = &cdns_uart_ops; port->fifosize = CDNS_UART_FIFO_SIZE; port->line = id; - port->dev = NULL; /* * Register the port.