| Message ID | ca9248caaae69b5134f69e085fe78905dfe74378.1643911278.git.robin.murphy@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | perf/arm-cmn: Make arm_cmn_debugfs static | expand |
On 2/3/22 11:31 PM, Robin Murphy wrote: > Indeed our debugfs directory is driver-internal so should be static. True. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Robin Murphy <robin.murphy@arm.com> > --- > drivers/perf/arm-cmn.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c > index 0e48adce57ef..d0e1ce2c83ba 100644 > --- a/drivers/perf/arm-cmn.c > +++ b/drivers/perf/arm-cmn.c > @@ -353,7 +353,7 @@ static struct arm_cmn_node *arm_cmn_node(const struct arm_cmn *cmn, > return NULL; > } > > -struct dentry *arm_cmn_debugfs; > +static struct dentry *arm_cmn_debugfs; > > #ifdef CONFIG_DEBUG_FS > static const char *arm_cmn_device_type(u8 type) > Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
On Thu, 3 Feb 2022 18:01:18 +0000, Robin Murphy wrote: > Indeed our debugfs directory is driver-internal so should be static. > > Applied to will (for-next/perf), thanks! [1/1] perf/arm-cmn: Make arm_cmn_debugfs static https://git.kernel.org/will/c/6f75217b20a7 Cheers,
diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index 0e48adce57ef..d0e1ce2c83ba 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -353,7 +353,7 @@ static struct arm_cmn_node *arm_cmn_node(const struct arm_cmn *cmn, return NULL; } -struct dentry *arm_cmn_debugfs; +static struct dentry *arm_cmn_debugfs; #ifdef CONFIG_DEBUG_FS static const char *arm_cmn_device_type(u8 type)
Indeed our debugfs directory is driver-internal so should be static. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Robin Murphy <robin.murphy@arm.com> --- drivers/perf/arm-cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)