| Message ID | d31aab90fbdecaf4c5f240becb2d0b0efb23f5c3.1496164448.git.leonard.crestez@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/30/2017 10:34 AM, Leonard Crestez wrote: > Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same > register values can be set through the micrel phy driver by using dts > properties. > > This seems preferable and allows cleanly fixing suspend/resume. > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> Should you have a Fixes: tag for that? Sounds like something you'd want to backport to stable trees as well, no? > --- > arch/arm/boot/dts/imx6ul-14x14-evk.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dts b/arch/arm/boot/dts/imx6ul-14x14-evk.dts > index f18e1f1..d2be8aa 100644 > --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dts > +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dts > @@ -120,10 +120,16 @@ > > ethphy0: ethernet-phy@2 { > reg = <2>; > + micrel,led-mode = <1>; > + clocks = <&clks IMX6UL_CLK_ENET_REF>; > + clock-names = "rmii-ref"; > }; > > ethphy1: ethernet-phy@1 { > reg = <1>; > + micrel,led-mode = <1>; > + clocks = <&clks IMX6UL_CLK_ENET2_REF>; > + clock-names = "rmii-ref"; > }; > }; > }; >
On Tue, 2017-05-30 at 11:10 -0700, Florian Fainelli wrote: > On 05/30/2017 10:34 AM, Leonard Crestez wrote: > > Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same > > register values can be set through the micrel phy driver by using dts > > properties. > > > > This seems preferable and allows cleanly fixing suspend/resume. > > > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> > > Should you have a Fixes: tag for that? Sounds like something you'd want > to backport to stable trees as well, no? I don't know if suspend over nfs ever worked on this board in upstream so there is no commit that this patch "Fixes: ". It would make sense to CC stable.
On Tue, May 30, 2017 at 2:34 PM, Leonard Crestez <leonard.crestez@nxp.com> wrote: > Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same > register values can be set through the micrel phy driver by using dts > properties. > > This seems preferable and allows cleanly fixing suspend/resume. > > Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
diff --git a/arch/arm/boot/dts/imx6ul-14x14-evk.dts b/arch/arm/boot/dts/imx6ul-14x14-evk.dts index f18e1f1..d2be8aa 100644 --- a/arch/arm/boot/dts/imx6ul-14x14-evk.dts +++ b/arch/arm/boot/dts/imx6ul-14x14-evk.dts @@ -120,10 +120,16 @@ ethphy0: ethernet-phy@2 { reg = <2>; + micrel,led-mode = <1>; + clocks = <&clks IMX6UL_CLK_ENET_REF>; + clock-names = "rmii-ref"; }; ethphy1: ethernet-phy@1 { reg = <1>; + micrel,led-mode = <1>; + clocks = <&clks IMX6UL_CLK_ENET2_REF>; + clock-names = "rmii-ref"; }; }; };
Right now mach-imx6ul registers a fixup for the ksz8081 phy. The same register values can be set through the micrel phy driver by using dts properties. This seems preferable and allows cleanly fixing suspend/resume. Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com> --- arch/arm/boot/dts/imx6ul-14x14-evk.dts | 6 ++++++ 1 file changed, 6 insertions(+)