From patchwork Tue Feb 18 03:55:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Popple X-Patchwork-Id: 13978978 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8946CC02198 for ; Tue, 18 Feb 2025 04:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W+P+HGRiqDCmj10CrZO8lY35WcAxWTj70gicDvDjINU=; b=bKvQgW7mQE+4YmvoROlpkTOf2w qrWmadNaMKLFomcE4h47f4pCyiLAPYLMY/4DX7a6csWpP/ygYAwov9iV8DSpNPHRpXnUKSfLInsRx SbbLZrcHfuHgv1db3im2dyhsUxc7+0D+xxvOOAD+Ys3acSlDOAMdeNjBNknePfAUQkh8T9kLFM8UO j0VmVIiuJfY/S+Cyad7X4JqsOBF/EicOJUQyFOFu7ddGw2mUJP2NtgSgFKUdRaRZfNnpmdMqsjsKD 9dGSpYstciNhnDkl4qFirK04NrrfFC+mZ8u4kAFxuDQmBpe5GgQqZY//lew7k3ayNBFGoRjxNGX6T iTQHvMjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tkEml-00000006gv4-1vLC; Tue, 18 Feb 2025 04:00:39 +0000 Received: from mail-dm3nam02on20627.outbound.protection.outlook.com ([2a01:111:f403:2405::627] helo=NAM02-DM3-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tkEiS-00000006exA-2ZSV for linux-arm-kernel@lists.infradead.org; Tue, 18 Feb 2025 03:56:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JdaCPR8msZgKM8bZsejGqK9otKPxSrIgdE+qxCp8awFgYrDx2RvrYmqzPV3mTpTE3fVGg2Vsgm8JqF65xqBvZtHAIA3kXAQ/Q1//v2PD/MpoFpcWuXYSrZebpjox/De241D1/LfJ/aJmxph+6cRFvRt+2EvR4ODpN+HgC3goR90Lk+vCXTu0RzoBMt22GWTl18TtOTeh+Ao293m2IjZYoT3DOpH5JfgBH9+ehd2xa0wgSCQfYFEdKMoX0aWMuaOslLcfSeziu8EaX1LVbvmyvD5V8mF/RxEqzeqLBm+L5AM2//FvFrAUSYH34ZlUupjaYLmuJ456Snau3MrNDr85hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W+P+HGRiqDCmj10CrZO8lY35WcAxWTj70gicDvDjINU=; b=VlRk8fV4QV84SfA76ln1wqYheSQLkMDZd39gUoDawwuMRuQ2WIl2tT5Ra0F+kgBuNQQ3foZgAgY6ewBJuv+e4s5OwhdddbUi/0VWdTZd071dZF0R4cg6JIQX8fYWYvzKXTaqae6BYatltqhkRL8Y1LVOrJwgsAVI2q7yH/yZDldkR0QJxuzEBcdYTh5MBBWeV5+S+2bvfqhtv5b2frBTiY8Jw6XjgBlXTkSScyyx/qk1CXYp9CekrGCv20Mo1WLQQAWNIKruKyyA+VqU+a6DwXdR7aARG59z7YYpmkUxxh+QrkmotH/73VjJGCpy+Ud/EcBrubgk2w0ADe+/lx4QSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W+P+HGRiqDCmj10CrZO8lY35WcAxWTj70gicDvDjINU=; b=C649wbCcsfrXxC8dYPukFSqI0TGt3nmPFx3qDTDL4F11Q+H35IBSxp3u9GrtTzZRWUDXRIAjMYw5wIPcjCQCK+Wei8FjHn4dNe9vi7NjsiHmRmWEXzxyadAptE2tuZsI/LxHgLEvCOcWRRNSeEIcgZuNSKl64t1rOmR6BDZOvcOB/GXrsWQ7+G5/o9GlSFWTHcpCpcKHA7d5LILuaHJJ2oFTuibpVqaM/nyq6EP8VzToOltYKvzli3kHZ+pDhddiXdRgOUQyhrWRULG166Nx2+7zUatuLAC17J5H7wRV5cD0Qqpd17rtN08A5cw6pykVTIxjmc40+SBu/ElxvCyTQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) by SN7PR12MB6789.namprd12.prod.outlook.com (2603:10b6:806:26b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.11; Tue, 18 Feb 2025 03:55:58 +0000 Received: from DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe]) by DS0PR12MB7726.namprd12.prod.outlook.com ([fe80::953f:2f80:90c5:67fe%7]) with mapi id 15.20.8445.017; Tue, 18 Feb 2025 03:55:58 +0000 From: Alistair Popple To: akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: Alistair Popple , Alison Schofield , lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev, Balbir Singh Subject: [PATCH v8 02/20] fs/dax: Return unmapped busy pages from dax_layout_busy_page_range() Date: Tue, 18 Feb 2025 14:55:18 +1100 Message-ID: X-Mailer: git-send-email 2.45.2 In-Reply-To: References: X-ClientProxiedBy: SY8PR01CA0025.ausprd01.prod.outlook.com (2603:10c6:10:29c::7) To DS0PR12MB7726.namprd12.prod.outlook.com (2603:10b6:8:130::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB7726:EE_|SN7PR12MB6789:EE_ X-MS-Office365-Filtering-Correlation-Id: 655b936b-d9b4-4e22-42c9-08dd4fd02721 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|7416014|366016; X-Microsoft-Antispam-Message-Info: gBW+tiFiA7utGLWZCYsTvgiEOA3UKz7fxFOiWBetl35tDYqjeO+sjxS+9c3A1eQhkM0VqXtBh6D+2P3JtgXejZBIZWYEOPpLTbUNjaR+dUxxe9/ra07fH8Bq1f6tIsaPFkrzG0jC2dRxw6RVtSyAi/u3LBhGysY3aGfucXB9nsj73BUD7bmCMliVi1kLEYPaQsaOiwwuDC5U4nj8D2yEzuFQq07iZB++/RgYQDEB+wumzyy6yXzJQeFPU+pxfdQuLQXYz/N3dxN6P07fg/yfXnEBCjNzdpAAj3u7Bp/UGIlYOn/ZZ2mxrcoNZ59OQqZwNw9r59aqfFpFHIUWILyvmUhUgQT8mrsLzVTyTZC5g28ri68hBHqCXwVSCq0UIkyckSOuRlwYvfxuB9kadQ+hYYG+AyTKuIp9RS9TRxq41iWrBW3RlH2Z9uJSN7tAwtuk3EDBHW4rHEaRTRkS/Eod6zUeWgBl+vK1Xhm63LqQIsJpndWYc9ZG05+r8iq2VNiG/f8vPzrd/85q6tuivUBSts0gTnsFMZzwUueoTXJkcIElP2z7a/A1l53QtqaFrpfEWoZf4vESfh4rFepQGe1Z1IjB5cFWWfSzazMroKJENLuZeCO9k0v5q2FefejzkSf+qBo+AUXXbEXLTDncwGj4jIqRRDZ0L0uydcg+OgUANy+DAPBaBzhQhdeED3068MTGTJDXq4M2VdoI3B0jaSdMoV3Ze2yh91G48fAfHkSgNmuiz/xdFwVgRF7mc2D3HAUxLrqD4y7ZeXC1uC8Wldt6rWeO8O70Ud4jScKxgtsXLESCY2wDUFQrJme2Cbm+O3h9oVr5c8er+e1e23qvFdtuI0flU7LHs3mHwN0bitT8CYX0QDEUb0p/BzctAmSl/90/XcEznWZjcsiNONONYg9MTEKN54l/jEaZ++rpLpR9KAxIx7guSIKr1c3mDAsExWGhNTJGjebMgGSEzMxD7rwclPWiLoASFXCT275bvw5w1otgZbbtYU+oLdE39zkLjvA015KoxscSKo+GqVS8jiRPj2SeR3MpgL37cw5j2aR2KjANaL/+FypWSGUbmivua+5fXGkN2Wl53nUBGuQL9GFRwoke3z843iEZTkEusii4XI/y9Ztn+Mhb8uNhLTq44gN8q4Ibt82nQcG3P9W0FF587kdzY0/QXLyqazBxeolFND1iBofH+BG8adP6J9yJC6tninTSJ2xH76G2cSuQN5hbGpIepK4uKQSiYO1WzkpKkMe0HD1czJ0xRJkgVmDoCgLSYWciJG/Gr0rkgxESq3BJbDfMYfo1EPFgwRkCnKmXlupZiJSJDG7LL41P4xpcSCepXk0mKKdSkJpQ8UoYT/3d0rYnfZifYbrXyZZcCaDqyjW6/1C5dK9INFpeaMgSW8zk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB7726.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: a+FGkh0L85vVaaF2MzY9zZjS9PWibQRrYUNjZ9n7kyORQlEuskuOzh7BpOW+nmrBiLGI1bodT/y33dy78XEkagYotwqd2Dm0UPbPv6fmtQSr4xrHOVJ3OTHdzB6VL4tTdRznbTb+Gs3gLeJIw5QoJB5nqdGAFh0Lps9ZR2hv/M9ClcdSHt2WDq1SJG336Ys7wTR0BLOnz5jvrktPZgv5wDs5uRqNCBrctoH0tJuGqd4dZiuuK3umcC7X3wklqzHeAHIIvnh0XaQC+cjRSexblYr6WCq0c5cvX+9xUgzwv/rRf7WgfaMSMPp2f9JmErHQ5o1iHlFn/jTglOdDxtOi7m2TMruVJwdV9eFD61Hhocxd99J4FpHeYrPT6C7A95ufR1Aw3XJ2JbsCqCRhm13GwpwxizlXfL7JCfkbvTtOlZOSMJqxQ56TB3QYl8w7mMvEV1JnrDGzH3eyz0cPjnHggTHviYJBIAOeRlIw9AC+FOldTH1ri34KXQvQUNWVBmTZLr+B2Q0ECYC+q3JxE7ZHnWtntHLmE9kZXOPLG5laBLHtqVQjhqP6r4hBlYtHdQu5YbYf4guCvA+QdyGj2Yh3GJuib1NcR0K8sl2Hb0pMFzqzT57TllB3Vftw8Bs6ZdohIONqucLQRNEb83+SApchLsiNA5hGpWicwuxeU7dWUKrKe+WFWdb4bX4x9XO16vpJWjNIefsZWx4S6AEw+Fs5aScqckieS1xAyou+MjgrYf/nvtMSiEc8i/qEVUHJQnDPBnvAbR7ojqhenOONH8+CyJQyegwhZJIy94Hu2p028UomumqWoOZphQjVLEnpC+2URA1sQ7Ll47ikj5KITACJpjSyuxd+JA8zYxGonM16IGU840+w/9P6/LWXU6t1QNvCaguAORfoYyZsrvfkjP8mLpviKq8SkoLd9iYclt4VUPA5HBgUBTXNuslimAVAgyEhVSergz4EwMsSdlAV18Y/sn7PyltaVdEzjHAdnIhtpb/+p2cY2YXOefzJYQo/c40FLrQXErajzWzDiJ5AkZvkILp+iyMwuXDw07WW0Hsj8bPQ4SUQ4rdnE9BieUz6v9zxuhb0BwbB+gqUCCN6/CWqAt5kzGEF2bPbjIxovxBw4KCGi+fYAD0E5RPNxPu9Sh5LqvBlFVyK6PWcpVv+6X4zsY420Ch+bAdvH5DoF9lsfF5UWuWXG7DKHBy+NYi4y+Da83yg6uuHWf+1b9ArkfjQrrdp0IAx66FWkCOgFLio1wRgqwtPlXelrxKSWAx+W+mTKt7x1lqMHl29xCsPXSzVQOlmumsEH8nxR+uwki37yuBlVMqNxrfC2ubQ20b1mfooC17aeuGjt5nOqeTQ+dEF5F28B/u2YN+y7V8eoEJ2LDuq2r1KUhWU2DAWHMkVbiolGv/9OgHF0jhcDFIa02AIVXvQ0kDUGXlOwVHDidiPg1/VnK3OyQYRyTs01y6zuQQyIxnkldsHkFl1EA96IqEPTJ/ssfeu8BKHDfEraJxCAWFLxyR2iaNp+wuqmXup/XSIV5QVZ9xjjPkxwhqg7t+o6J/uKj3rV0bbyggS5yhQCQ1bCxDgfNkeo2cE5+FyhzUP X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 655b936b-d9b4-4e22-42c9-08dd4fd02721 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB7726.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2025 03:55:58.5818 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EGXJ9q7YuR0Lha9NjlRnMMr0ah4CV11UhRKcjgmFz2ZLEfohwD/064WTDH8pxXK/CQbh07kNI+8aefLDialr8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6789 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250217_195612_654729_8DAB3885 X-CRM114-Status: GOOD ( 13.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org dax_layout_busy_page_range() is used by file systems to scan the DAX page-cache to unmap mapping pages from user-space and to determine if any pages in the given range are busy, either due to ongoing DMA or other get_user_pages() usage. Currently it checks to see the file mapping is mapped into user-space with mapping_mapped() and returns early if not, skipping the check for DMA busy pages. This is wrong as pages may still be undergoing DMA access even if they have subsequently been unmapped from user-space. Fix this by dropping the check for mapping_mapped(). Signed-off-by: Alistair Popple Suggested-by: Dan Williams Reviewed-by: Dan Williams Reviewed-by: Balbir Singh --- fs/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/dax.c b/fs/dax.c index 972febc..b35f538 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -691,7 +691,7 @@ struct page *dax_layout_busy_page_range(struct address_space *mapping, if (IS_ENABLED(CONFIG_FS_DAX_LIMITED)) return NULL; - if (!dax_mapping(mapping) || !mapping_mapped(mapping)) + if (!dax_mapping(mapping)) return NULL; /* If end == LLONG_MAX, all pages from start to till end of file */