From patchwork Tue Jun 5 04:47:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10447585 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7B4436024A for ; Tue, 5 Jun 2018 04:57:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 691E228DE5 for ; Tue, 5 Jun 2018 04:57:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5DAC928E26; Tue, 5 Jun 2018 04:57:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F211828DE5 for ; Tue, 5 Jun 2018 04:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ayJsFtl/eUq0aLInMTPdtpiQ3eYFytRlMugti+o9mOo=; b=Bp45B5QQ+ilwVWHIYr6hXNUHyH vYikzKorERY0BZc+GN6C0IsMG7wQ6DtB49vSLT9qJ7jIYY+ZQI7dhs2briPRMlmi5xvkOVmHe6ZQ+ eml5h6DETZDmOUaxtlVVwKsSx8p3rB86sYutINLewYJThywJ575FUDKreD4f6HB0nQifAPeazKrhJ Uczs0cmaffWTPYWM9DYYNAXmAfO5Yqe5uUiBGcvH/r6+jc9t+r4Vg8xynhE7A17A/y7ck+wNPL/Dh jkHA8tLvyVO3yd57/V5hXaXNpcpROy1E6o5q7eXe9Chbz7LJluyVbNXBx26NPUGqCYFJamOnkGBuM dDchKejg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fQ41q-0000Ms-S2; Tue, 05 Jun 2018 04:57:06 +0000 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fQ41m-0000G4-SY for linux-arm-kernel@lists.infradead.org; Tue, 05 Jun 2018 04:57:04 +0000 Received: by mail-pl0-x244.google.com with SMTP id z9-v6so735481plk.11 for ; Mon, 04 Jun 2018 21:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cwf79dPZ6Mk82viwE3UOroewlvnMne770dLqXn7PpmY=; b=LCG1jzfxlS8cxnXUJxMZ/DzKUI1Zj0l1TOxtWSartnBnsQx78ei/rgBWTyHsTTdLzy 2+UIXDgAYN4beBFTzlW7/tGoMZ+sYnJfysOc7e3fwn+ecPr4ctGKpE7KWK9QVU2ZFnX/ CNX+QHkcmeOEnSH49piQB5CKQruMkptPjdJ4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cwf79dPZ6Mk82viwE3UOroewlvnMne770dLqXn7PpmY=; b=nNQn56K41cWogSYxEceAA/Cs0JmcfeQG+i2ENoo4jKE+QlsyJaTbYAsQjkt9M0thrw O4HbOCYGw1IWDSESPelkhsAaUP2QsHsD3dH63ODLLf+8P1g0OG6VX0ffX6OtwpaUtJSm zefWdGWGxCIaLuDhlFMLHlmJ4ojCbaA5bNj4PeF3A+I6Zsa2wJlzCSndaLj6f/oDPaqv uaFhyrFnOfeMTWx+CE+cpOGzqD64s6TigMdsriFf+UBFQ9RZEzlc1gs3dToCu/5MV81X V3BcO9kA6J03yIGcWZ6jVrt2FN5ATpXDk6Mcv6pJNa4JmXvJpZi5IQ6/yjC35lFkJoNu +5pg== X-Gm-Message-State: ALKqPweCFMwobv5L1qV5nxejtLYCbYgrpFCsXwlkLkcxzGnt8yLU+IVj 6BunovFXl1lLaHLzj0P8qN0o4g== X-Google-Smtp-Source: ADUXVKJsyZtOZkjK3LCrcYInSdiBrQsuTV9RQffR9QWlCL8K4jyPw61CVebcufNTFisOfBBA60cfxg== X-Received: by 2002:a17:902:8a82:: with SMTP id p2-v6mr24717641plo.244.1528174612158; Mon, 04 Jun 2018 21:56:52 -0700 (PDT) Received: from localhost ([122.172.63.23]) by smtp.gmail.com with ESMTPSA id n10-v6sm7891012pfb.27.2018.06.04.21.56.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 21:56:51 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai Subject: [PATCH V2 1/2] arm: dts: sun8i-h3: Add missing cooling device properties for CPUs Date: Tue, 5 Jun 2018 10:17:48 +0530 Message-Id: X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: <20180601151701.sshwfdbflic6mybv@flea> References: <20180601151701.sshwfdbflic6mybv@flea> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180604_215702_960763_8497186A X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vincent Guittot , Viresh Kumar , Daniel Lezcano , linux-kernel@vger.kernel.org, chris.redpath@arm.com, ionela.voinescu@arm.com, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Fix other missing properties (clocks, clock-names) as well to make it all work. Signed-off-by: Viresh Kumar --- V2: Separated patch for h3. arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi index 41d57c76f290..9dff6887923c 100644 --- a/arch/arm/boot/dts/sun8i-h3.dtsi +++ b/arch/arm/boot/dts/sun8i-h3.dtsi @@ -84,21 +84,30 @@ compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <1>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; cpu@2 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <2>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; cpu@3 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <3>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; };