From patchwork Fri Sep 6 04:55:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Furong Xu <0x1207@gmail.com> X-Patchwork-Id: 13793225 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2F2ECE7AB2 for ; Fri, 6 Sep 2024 04:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=awdxA94+EDwJxMaDIv2LrPwLHdX9C7ivLS6VUmJAIug=; b=Xmcp0hZIceUXvu9w59WAsej5gx ge9u5Fx1wUpmkatseJRwZHncSr5lNRJvg5zMo6Vjp+IJB1T2h3HbknQmnSvCn7sqI8sRguHJCGFt0 PPLxomfE+2d4Y17MW3DXVOucBvJaF2hGzXSuGOrcu4POJUBc5EkGoFhc87VeaiMKJl7DylB40WfR/ M/cF91fj9xTxE2/GZigX+B/TcMjoScmwfNBj9NorDXT8tSPJvrqIkFPeBgmRwX0he7fl1Z9KlBdE6 SK9v0HUCeVZGlm8vx+2hDw4OSboASP3Jn6yNydsq0ITa/Hxomu/ObWZpCwuWkyCd3IU7o1uM0rbr8 Oli+819Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1smR4P-0000000Affl-0Acw; Fri, 06 Sep 2024 04:59:41 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1smR1f-0000000AeyL-46t7 for linux-arm-kernel@lists.infradead.org; Fri, 06 Sep 2024 04:56:53 +0000 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-71798a15ce5so727196b3a.0 for ; Thu, 05 Sep 2024 21:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725598611; x=1726203411; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=awdxA94+EDwJxMaDIv2LrPwLHdX9C7ivLS6VUmJAIug=; b=Uw/Bl2zHQ4aSyLZwCg5poe1ZwOitgxzXUNOnMXAFZB1tIM2TImIHiNkeAb6nvg3URa YdTiAR7wAyTz3zKqfPZhAwur/VxOBLB4I+hBI2uXZpdyvFjKozz6IcfNqrcqoedVo87R kAI5KalVAcm3ps7XzBaf5Q5+T41gMPR8+VJ9WmveWr1hRCTTFWmisH3H0eBqJ7P9NUxT uRzi1tCZETtrMHD1/joKtKCtFlFUvW5I0mUZSrjL68c1CHbgCWGwZDCU/kDwRm37ed5B /NwlVZLTCUVxnPM0V4gmiC8ZoCwGfR7ryNKbqeoZZknt0ryGPsdnZ/+lMic907cvMoN+ lduA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725598611; x=1726203411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=awdxA94+EDwJxMaDIv2LrPwLHdX9C7ivLS6VUmJAIug=; b=PQ/AucDS8/WAYms6j1STodXmqOpOlC70f4VkYVrNbf/vZ0ckPxQgIozlU9E7Rcl7bu Qe1qfryfio0SDiLdRVJ6JuLSGS4ICLsiJAeDN/gsHzrOSTcpYXEMoDCm7zcNspUBFD4Q WAoQPnEmnrEEqmRhKZt9erxnXE2Ee+3UJXNHQoJchmq8d7CbBug7o/f+aw/3vf8wA956 /9NI7dKauHCYHdTUGn4GkLWREekqN6zJMwn6WQ/9X3n+MuD6FhwDCOFTiHJLx6bH7221 HNVWC2wt4RHxJOTyIRpzw5aw54Dz4Tk9ugZ/9ic6GAPoYqT8iBg6PonN8gWIYoLlYOOW CvFA== X-Forwarded-Encrypted: i=1; AJvYcCVPxFPfvJ4EY5WK6VkMWk3evscZRz056Z12RrHROyFdimhZUnp6KPwwQUHLIhFNx/4FbBORESViBDfv7fg6fDXv@lists.infradead.org X-Gm-Message-State: AOJu0YwE8M+kubnrlNloLq430dqYxdBNNNWsJHJIeorIZYzv1fv/d28w 06uIpkMDj0cajWWWMEhqFpx+z8AVJ7lbLaHnwIb0C2RyX+6qZ33l X-Google-Smtp-Source: AGHT+IHhLryr0A8pwiJ/WABHRdfza5mcvYUq9KAqWs1D4gDvA0WovWkUgZpTbm906++5urOriKthfg== X-Received: by 2002:a05:6a20:43a9:b0:1bd:1d5f:35be with SMTP id adf61e73a8af0-1cf1bfbb548mr2884149637.11.1725598610767; Thu, 05 Sep 2024 21:56:50 -0700 (PDT) Received: from localhost.localdomain ([129.146.253.192]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-71791e54585sm1704002b3a.182.2024.09.05.21.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 21:56:50 -0700 (PDT) From: Furong Xu <0x1207@gmail.com> To: Vladimir Oltean , Serge Semin , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, rmk+kernel@armlinux.org.uk, linux@armlinux.org.uk, xfr@outlook.com, Furong Xu <0x1207@gmail.com> Subject: [PATCH net-next v9 2/7] net: stmmac: drop stmmac_fpe_handshake Date: Fri, 6 Sep 2024 12:55:57 +0800 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240905_215652_030604_AAF9794F X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org ethtool --set-mm can trigger FPE verification process by calling stmmac_fpe_send_mpacket, stmmac_fpe_handshake should be gone. Signed-off-by: Furong Xu <0x1207@gmail.com> Reviewed-by: Vladimir Oltean --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 1 - .../net/ethernet/stmicro/stmmac/stmmac_main.c | 23 +------------------ .../net/ethernet/stmicro/stmmac/stmmac_tc.c | 8 ------- 3 files changed, 1 insertion(+), 31 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h index 458d6b16ce21..3ad182ef8e97 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h @@ -425,7 +425,6 @@ bool stmmac_eee_init(struct stmmac_priv *priv); int stmmac_reinit_queues(struct net_device *dev, u32 rx_cnt, u32 tx_cnt); int stmmac_reinit_ringparam(struct net_device *dev, u32 rx_size, u32 tx_size); int stmmac_bus_clks_config(struct stmmac_priv *priv, bool enabled); -void stmmac_fpe_handshake(struct stmmac_priv *priv, bool enable); static inline bool stmmac_xdp_is_enabled(struct stmmac_priv *priv) { diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 529fe31f8b04..3072ad33b105 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3533,13 +3533,9 @@ static int stmmac_hw_setup(struct net_device *dev, bool ptp_register) stmmac_set_hw_vlan_mode(priv, priv->hw); - if (priv->dma_cap.fpesel) { + if (priv->dma_cap.fpesel) stmmac_fpe_start_wq(priv); - if (priv->fpe_cfg.enable) - stmmac_fpe_handshake(priv, true); - } - return 0; } @@ -7425,22 +7421,6 @@ static void stmmac_fpe_lp_task(struct work_struct *work) clear_bit(__FPE_TASK_SCHED, &priv->fpe_task_state); } -void stmmac_fpe_handshake(struct stmmac_priv *priv, bool enable) -{ - if (priv->fpe_cfg.hs_enable != enable) { - if (enable) { - stmmac_fpe_send_mpacket(priv, priv->ioaddr, - &priv->fpe_cfg, - MPACKET_VERIFY); - } else { - priv->fpe_cfg.lo_fpe_state = FPE_STATE_OFF; - priv->fpe_cfg.lp_fpe_state = FPE_STATE_OFF; - } - - priv->fpe_cfg.hs_enable = enable; - } -} - static int stmmac_xdp_rx_timestamp(const struct xdp_md *_ctx, u64 *timestamp) { const struct stmmac_xdp_buff *ctx = (void *)_ctx; @@ -7902,7 +7882,6 @@ int stmmac_suspend(struct device *dev) priv->plat->tx_queues_to_use, priv->plat->rx_queues_to_use, false); - stmmac_fpe_handshake(priv, false); stmmac_fpe_stop_wq(priv); } diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c index 9cc41ed01882..b0cc45331ff7 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_tc.c @@ -1078,11 +1078,6 @@ static int tc_taprio_configure(struct stmmac_priv *priv, netdev_info(priv->dev, "configured EST\n"); - if (fpe) { - stmmac_fpe_handshake(priv, true); - netdev_info(priv->dev, "start FPE handshake\n"); - } - return 0; disable: @@ -1107,9 +1102,6 @@ static int tc_taprio_configure(struct stmmac_priv *priv, false); netdev_info(priv->dev, "disabled FPE\n"); - stmmac_fpe_handshake(priv, false); - netdev_info(priv->dev, "stop FPE handshake\n"); - return ret; }