From patchwork Tue Jul 25 13:08:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Gonzalez X-Patchwork-Id: 9861969 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2688D602B1 for ; Tue, 25 Jul 2017 13:09:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1DA1726E75 for ; Tue, 25 Jul 2017 13:09:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 11CA9284C7; Tue, 25 Jul 2017 13:09:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, URIBL_BLACK autolearn=no version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B003826E75 for ; Tue, 25 Jul 2017 13:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GTBGOO2NilF1NiZJwhLmRLTxLI9rYRVHp+BESAeREHE=; b=GM80DH8q9ZQL8F v4qEVXm349FLZZVURXUQKH8Jb4qBKlOE54OqBrV2h585h5S8jOKwEdLEB7dXivhxCGVX6tnjy0+PQ qH2DoA+AJNtWYbOXC9tBNRJjfTYoSeUz8OkLPxmX09UiVROeuvgq/zC5sLA2qrH9QHM+YkV1ukPFe JGcAYMQ79oFlj2BCEGQEjqyptEn+XXHZtRhMhDNEINV9UPWdBNYaKPym6x8ZY0iC9kcNrNNHecLnR KxoOppkWXNqyRst1EYfJNq7hpRBFdq+V7ObrpfPg16UskmISHeWMOgvCXHKomIzIhDOxEe/XCkG9f sVUo8oraw2CqO5k4WzoQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dZzaT-0006f1-1t; Tue, 25 Jul 2017 13:09:21 +0000 Received: from us-smtp-delivery-107.mimecast.com ([216.205.24.107]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dZzaO-0006PG-T3 for linux-arm-kernel@lists.infradead.org; Tue, 25 Jul 2017 13:09:18 +0000 Received: from CPH-EX1.SDESIGNS.COM (195-215-56-170-static.dk.customer.tdc.net [195.215.56.170]) (Using TLS) by us-smtp-1.mimecast.com with ESMTP id us-mta-55-OyQf9r6vOtipSwrmHO1FZg-1; Tue, 25 Jul 2017 09:08:53 -0400 Received: from [172.27.0.114] (172.27.0.114) by CPH-EX1.sdesigns.com (192.168.10.36) with Microsoft SMTP Server (TLS) id 14.3.294.0; Tue, 25 Jul 2017 15:08:50 +0200 Subject: [PATCH v3] irqchip/tango: Don't use incorrect irq_mask_ack callback To: Thomas Gleixner , Marc Zyngier , Jason Cooper References: <20170719190734.18566-1-opendmb@gmail.com> <20170719190734.18566-3-opendmb@gmail.com> <7a51555f-8191-9ebd-1f30-7c20f6db9d3f@sigmadesigns.com> <8d29fec9-35b8-c33b-3091-3e9a51c99ed7@gmail.com> From: Marc Gonzalez Message-ID: Date: Tue, 25 Jul 2017 15:08:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.1 MIME-Version: 1.0 In-Reply-To: <8d29fec9-35b8-c33b-3091-3e9a51c99ed7@gmail.com> X-Originating-IP: [172.27.0.114] X-MC-Unique: OyQf9r6vOtipSwrmHO1FZg-1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170725_060917_144614_4171FE5E X-CRM114-Status: UNSURE ( 8.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Mason , LKML , Doug Berger , Mans Rullgard , Linux ARM Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP irq_gc_mask_disable_reg_and_ack() is not equivalent to irq_gc_mask_disable_reg() and irq_gc_ack_set_bit(). Leave the irq_mask_ack callback undefined, and let the irqchip framework use irq_mask and irq_ack instead. Reported-by: Doug Berger Fixes: 4bba66899ac6 ("irqchip/tango: Add support for Sigma Designs SMP86xx/SMP87xx interrupt controller") Signed-off-by: Marc Gonzalez Cc: stable@vger.kernel.org --- As discussed previously, it is acceptable for tango to rely on mask_ack_irq() doing the right thing(TM). --- drivers/irqchip/irq-tango.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/irqchip/irq-tango.c b/drivers/irqchip/irq-tango.c index bdbb5c0ff7fe..825085cdab99 100644 --- a/drivers/irqchip/irq-tango.c +++ b/drivers/irqchip/irq-tango.c @@ -141,7 +141,6 @@ static void __init tangox_irq_init_chip(struct irq_chip_generic *gc, for (i = 0; i < 2; i++) { ct[i].chip.irq_ack = irq_gc_ack_set_bit; ct[i].chip.irq_mask = irq_gc_mask_disable_reg; - ct[i].chip.irq_mask_ack = irq_gc_mask_disable_reg_and_ack; ct[i].chip.irq_unmask = irq_gc_unmask_enable_reg; ct[i].chip.irq_set_type = tangox_irq_set_type; ct[i].chip.name = gc->domain->name;