From patchwork Fri Sep 30 14:54:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Graf X-Patchwork-Id: 9358489 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BCCE46075E for ; Fri, 30 Sep 2016 14:58:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AEAB92A087 for ; Fri, 30 Sep 2016 14:58:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A2E322A089; Fri, 30 Sep 2016 14:58:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8FD072A087 for ; Fri, 30 Sep 2016 14:58:06 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bpzDG-0007ko-6h; Fri, 30 Sep 2016 14:54:58 +0000 Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bpzDB-0007j0-F7 for linux-arm-kernel@lists.infradead.org; Fri, 30 Sep 2016 14:54:54 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A6F92AE94; Fri, 30 Sep 2016 14:54:29 +0000 (UTC) Subject: Re: [PATCH 0/3] Support userspace irqchip with arch timers To: Christoffer Dall References: <20160927190806.22988-1-christoffer.dall@linaro.org> From: Alexander Graf Message-ID: Date: Fri, 30 Sep 2016 16:54:28 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160927190806.22988-1-christoffer.dall@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160930_075453_742189_CFDCE4C3 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marc Zyngier , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 27.09.16 21:08, Christoffer Dall wrote: > Hi Alex, > > Marc and I have been looking at this during Linaro connect and have > slightly reworked your patch into this small series. > > It would be good if you could have a look at it and test it out. > > I've tested it with your QEMU, and it works for UP, but secondary CPUs > fail to come up, and it looks like the kernel never gets an IPI for > those CPUs from userspace. Any chance you're willing to take a look at > that? I still need to see whether I can come up with a prettier solution, but for now this works: Alex diff --git a/target-i386/kvm.c b/target-i386/kvm.c index f1ad805..8b9a084 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -2393,7 +2393,11 @@ static int kvm_get_mp_state(X86CPU *cpu) return ret; } env->mp_state = mp_state.mp_state; +#ifdef CONFIG_ARM + if (kvm_enabled()) { +#else if (kvm_irqchip_in_kernel()) { +#endif cs->halted = (mp_state.mp_state == KVM_MP_STATE_HALTED); } return 0;