ARM: Kconfig: Open force maximum zone order for all SoCs

Commit Message

Xiubo Li Sept. 26, 2014, 8:39 a.m. UTC

[...]
> On Fri, Sep 26, 2014 at 05:30:40AM +0000, [e-mail] wrote:
> > Hi Russell,
> >
> > I'd like to know the status of this patch.
> >
> > Our Platforms depend on it.
> 
> I'm not applying it.  This option should not be exposed for general
> use.  The usage pattern is clear from the existing users - propose
> an alternative default value for your platform rather than making it
> a user visible tweakable option.
> 

Okay.

Something like :
++++++++++
----------

Is okay ?

Thanks,

BRs
Xiubo

> --
> FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
> according to speedtest.net.

Comments

Russell King - ARM Linux Sept. 26, 2014, 8:44 a.m. UTC | #1

On Fri, Sep 26, 2014 at 08:39:04AM +0000, [e-mail] wrote:
> [...]
> > On Fri, Sep 26, 2014 at 05:30:40AM +0000, [e-mail] wrote:
> > > Hi Russell,
> > >
> > > I'd like to know the status of this patch.
> > >
> > > Our Platforms depend on it.
> > 
> > I'm not applying it.  This option should not be exposed for general
> > use.  The usage pattern is clear from the existing users - propose
> > an alternative default value for your platform rather than making it
> > a user visible tweakable option.
> > 
> 
> Okay.
> 
> Something like :
> ++++++++++
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 1ad6fb6..5729a2c 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1802,7 +1802,7 @@ source "mm/Kconfig"
>  config FORCE_MAX_ZONEORDER
>         int "Maximum zone order" if ARCH_SHMOBILE
>         range 11 64 if ARCH_SHMOBILE
> -       default "12" if SOC_AM33XX
> +       default "12" if SOC_AM33XX || SOC_LS1021A
>         default "9" if SA1111
>         default "11"
>         help
> ----------
> 
> Is okay ?

It's much better than exposing the option, but I'd like this patch to
appear as a properly submitted change (including a change log which
provides the reason why this is necessary.)

Thanks.

Xiubo Li Sept. 26, 2014, 8:46 a.m. UTC | #2

> Subject: Re: [PATCH] ARM: Kconfig: Open force maximum zone order for all SoCs
> 
> On Fri, Sep 26, 2014 at 08:39:04AM +0000, [e-mail] wrote:
> > [...]
> > > On Fri, Sep 26, 2014 at 05:30:40AM +0000, [e-mail] wrote:
> > > > Hi Russell,
> > > >
> > > > I'd like to know the status of this patch.
> > > >
> > > > Our Platforms depend on it.
> > >
> > > I'm not applying it.  This option should not be exposed for general
> > > use.  The usage pattern is clear from the existing users - propose
> > > an alternative default value for your platform rather than making it
> > > a user visible tweakable option.
> > >
> >
> > Okay.
> >
> > Something like :
> > ++++++++++
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 1ad6fb6..5729a2c 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1802,7 +1802,7 @@ source "mm/Kconfig"
> >  config FORCE_MAX_ZONEORDER
> >         int "Maximum zone order" if ARCH_SHMOBILE
> >         range 11 64 if ARCH_SHMOBILE
> > -       default "12" if SOC_AM33XX
> > +       default "12" if SOC_AM33XX || SOC_LS1021A
> >         default "9" if SA1111
> >         default "11"
> >         help
> > ----------
> >
> > Is okay ?
> 
> It's much better than exposing the option, but I'd like this patch to
> appear as a properly submitted change (including a change log which
> provides the reason why this is necessary.)
> 

Okay, I will.

Thanks,

BRs
Xiubo


> Thanks.
> 
> --
> FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
> according to speedtest.net.

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 1ad6fb6..5729a2c 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1802,7 +1802,7 @@  source "mm/Kconfig"
 config FORCE_MAX_ZONEORDER
        int "Maximum zone order" if ARCH_SHMOBILE
        range 11 64 if ARCH_SHMOBILE
-       default "12" if SOC_AM33XX
+       default "12" if SOC_AM33XX || SOC_LS1021A
        default "9" if SA1111
        default "11"
        help