| Message ID | e4eb66dec2901016e01767932461c5d560762f66.1544666839.git.ryder.lee@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] pinctrl: mediatek: improve Kconfig dependencies | expand |
It looks good to me. Thanks for bringing the improved version soon. Acked-by: Sean Wang <sean.wang@kernel.org> On Wed, Dec 12, 2018 at 6:28 PM Ryder Lee <ryder.lee@mediatek.com> wrote: > > Remove prompts to make all pinctrl cores to non-visible symbols and > make sure the target SoCs would be coupled with the corresponding > cores. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > --- > Changes since v1: > - Revise commit message > - Change all pinctrl cores to non-visible symbols > - Drop EINT_MTK in PINCTRL_MTK_MOORE > --- > drivers/pinctrl/mediatek/Kconfig | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig > index d8cb584..1817786 100644 > --- a/drivers/pinctrl/mediatek/Kconfig > +++ b/drivers/pinctrl/mediatek/Kconfig > @@ -17,7 +17,7 @@ config PINCTRL_MTK > select OF_GPIO > > config PINCTRL_MTK_MOORE > - bool "MediaTek Moore Core that implements generic binding" > + bool > depends on OF > select GENERIC_PINCONF > select GENERIC_PINCTRL_GROUPS > @@ -26,7 +26,7 @@ config PINCTRL_MTK_MOORE > select OF_GPIO > > config PINCTRL_MTK_PARIS > - bool "MediaTek Paris Core that implements vendor binding" > + bool > depends on OF > select PINMUX > select GENERIC_PINCONF > @@ -45,14 +45,14 @@ config PINCTRL_MT2701 > config PINCTRL_MT7623 > bool "Mediatek MT7623 pin control with generic binding" > depends on MACH_MT7623 || COMPILE_TEST > - depends on PINCTRL_MTK_MOORE > - default y > + default MACH_MT7623 > + select PINCTRL_MTK_MOORE > > config PINCTRL_MT7629 > bool "Mediatek MT7629 pin control" > depends on MACH_MT7629 || COMPILE_TEST > - depends on PINCTRL_MTK_MOORE > - default y > + default MACH_MT7629 > + select PINCTRL_MTK_MOORE > > config PINCTRL_MT8135 > bool "Mediatek MT8135 pin control" > @@ -93,8 +93,8 @@ config PINCTRL_MT6797 > config PINCTRL_MT7622 > bool "MediaTek MT7622 pin control" > depends on ARM64 || COMPILE_TEST > - depends on PINCTRL_MTK_MOORE > - default y > + default ARM64 && ARCH_MEDIATEK > + select PINCTRL_MTK_MOORE > > config PINCTRL_MT8173 > bool "Mediatek MT8173 pin control" > -- > 1.9.1 >
Ryder Lee <ryder.lee@mediatek.com> writes: > Remove prompts to make all pinctrl cores to non-visible symbols and > make sure the target SoCs would be coupled with the corresponding > cores. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> Tested-by: Kevin Hilman <khilman@baylibre.com> Tested on the mt7623-rfb1 board which has been failing in kernelCI, and this patch gets things booting again. Kevin
On Thu, Dec 13, 2018 at 3:28 AM Ryder Lee <ryder.lee@mediatek.com> wrote: > Remove prompts to make all pinctrl cores to non-visible symbols and > make sure the target SoCs would be coupled with the corresponding > cores. > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> Patch applied with ACK and Tested-by. Yours, Linus Walleij
CC: stable@vger.kernel.org On Fri, 2018-12-21 at 18:17 +0800, Linus Walleij wrote: > On Thu, Dec 13, 2018 at 3:28 AM Ryder Lee <ryder.lee@mediatek.com> wrote: > > > Remove prompts to make all pinctrl cores to non-visible symbols and > > make sure the target SoCs would be coupled with the corresponding > > cores. > > > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> > > Patch applied with ACK and Tested-by. > > Yours, > Linus Walleij I forgot to add stable-kernel into CC list. This patch should be applied to stable-rc linux-4.20.y. Sorry for the inconvenience. Ryder
diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig index d8cb584..1817786 100644 --- a/drivers/pinctrl/mediatek/Kconfig +++ b/drivers/pinctrl/mediatek/Kconfig @@ -17,7 +17,7 @@ config PINCTRL_MTK select OF_GPIO config PINCTRL_MTK_MOORE - bool "MediaTek Moore Core that implements generic binding" + bool depends on OF select GENERIC_PINCONF select GENERIC_PINCTRL_GROUPS @@ -26,7 +26,7 @@ config PINCTRL_MTK_MOORE select OF_GPIO config PINCTRL_MTK_PARIS - bool "MediaTek Paris Core that implements vendor binding" + bool depends on OF select PINMUX select GENERIC_PINCONF @@ -45,14 +45,14 @@ config PINCTRL_MT2701 config PINCTRL_MT7623 bool "Mediatek MT7623 pin control with generic binding" depends on MACH_MT7623 || COMPILE_TEST - depends on PINCTRL_MTK_MOORE - default y + default MACH_MT7623 + select PINCTRL_MTK_MOORE config PINCTRL_MT7629 bool "Mediatek MT7629 pin control" depends on MACH_MT7629 || COMPILE_TEST - depends on PINCTRL_MTK_MOORE - default y + default MACH_MT7629 + select PINCTRL_MTK_MOORE config PINCTRL_MT8135 bool "Mediatek MT8135 pin control" @@ -93,8 +93,8 @@ config PINCTRL_MT6797 config PINCTRL_MT7622 bool "MediaTek MT7622 pin control" depends on ARM64 || COMPILE_TEST - depends on PINCTRL_MTK_MOORE - default y + default ARM64 && ARCH_MEDIATEK + select PINCTRL_MTK_MOORE config PINCTRL_MT8173 bool "Mediatek MT8173 pin control"
Remove prompts to make all pinctrl cores to non-visible symbols and make sure the target SoCs would be coupled with the corresponding cores. Signed-off-by: Ryder Lee <ryder.lee@mediatek.com> --- Changes since v1: - Revise commit message - Change all pinctrl cores to non-visible symbols - Drop EINT_MTK in PINCTRL_MTK_MOORE --- drivers/pinctrl/mediatek/Kconfig | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)