From patchwork Wed Jun 6 12:41:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Simek X-Patchwork-Id: 10450199 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D242D60146 for ; Wed, 6 Jun 2018 12:57:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C0BDE1FEB1 for ; Wed, 6 Jun 2018 12:57:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B55341FF40; Wed, 6 Jun 2018 12:57:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9D7AF1FEB1 for ; Wed, 6 Jun 2018 12:57:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=bOxbqDuMRciupCXZ4LT9Y/zfYQpkg+v1M2w346SnFVM=; b=no30GITGsIQ7TGyawkpTrjcibe ZegGWCVZ/I/PlFiXtlIJ34aMksPG7dLymSK+BxVWqmp0I7I7ueh/gjVrXoY7enz78Ax43rhuoh+Z5 L8dl2oOnmPHZAl1LgsGIYNr4I0hwbZi+J2bzlyW62Uot2eZ2x2QydJiTY2BU2YRuHAhUYr5XKKfa+ aVmiBa08bo31wYdPetE51llH5CVy56IADqiSo6x3+RN64TfJC/rWLgVQZ936mTShcf5cSEF5ULR4H fxKzKv08pDp8QL7a8qaGyigtjMOY6ONAjEO5DEeG+DZSjnTQ6szJi4u/zxKB2CLcHgltBdwvst+9M l46tmneg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fQXzz-00010O-Nt; Wed, 06 Jun 2018 12:57:11 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fQXlE-0000io-HW for linux-arm-kernel@lists.infradead.org; Wed, 06 Jun 2018 12:41:59 +0000 Received: by mail-wm0-x244.google.com with SMTP id p11-v6so11674249wmc.4 for ; Wed, 06 Jun 2018 05:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=Lji2kjfAH3ekg5TqE/YvRfdPPZSDLydGiu1295JcA0s=; b=WfUmlMio1KIQ8shb1C7Qk0J/kyjgB6TD5adV34wtteXLen6eCaowBEt0kjxW3fyltX CdR28ihmQVLOAT5qbBYNmZ+fJiC4UcdhByGgEndXHoLZCDjyaaWRYyd7S5/B+kIfTE84 7sql3MkV9hjpHe0V5/RKFUXshj9YuVKQBwgLhY9DGw/dzD7aT8QqkBhrMMsuUaKcptX0 iOOZbPpokYiaiJxOs1rnZKYU89xYnWqjBHTMNLOoFTyRCeQH5hmGdXfVpDY9IaDcvWmJ FpZj2S81HT0Wk0yZaaEjVBKIwDxHU9Y+ddhoumwL62TOY9e3Mhg88mPYwT+rfmKqQjKj RRLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:in-reply-to:references; bh=Lji2kjfAH3ekg5TqE/YvRfdPPZSDLydGiu1295JcA0s=; b=nTUHsLQ3P+goLLXWBMXoqG3qlTK7heuIamIvrg9tgDwF+3aqVJKKWlzxlGOOPZW/pP gHxAZkyIvnuuaHhE5STq5KOspZOZGU6948+kl8up2+4/qTk1fwteGOR6jzm7n4mVh3Qh LugRNpPD0yhWlUEILgT0TAqSO/OmG/Lc4oInYD+O1HItZGM1LdcAF2YE0giiiPZjo41w y30HuAAd3imRg2s366Z6XjjkCCgtu8teTr8XyydeK2hFAhuXqjAd2AuMH6eOPysCBD+Y 6cS/dFlKKlSl8qKTEKDg3RmHAC6ByHcPvoABaFUyHJh1S4zDTaKTn/LTO7N/3GS5ClCF iv+A== X-Gm-Message-State: APt69E2CVykMtTPAE9vKFrl4idoNf9aBMKis7i4lnrXACFwDTevAvTNq CDVAQ6CrpiCS5SGJKEZAF0UVWg== X-Google-Smtp-Source: ADUXVKLAJsGs2WdEGDsnTMYAT8PmXYVbXK+hg2VHWIFXWcajJ0S4tLF0bK8+h98QbmxhAkDttWUn8Q== X-Received: by 2002:a1c:581:: with SMTP id 123-v6mr1751795wmf.58.1528288904935; Wed, 06 Jun 2018 05:41:44 -0700 (PDT) Received: from localhost (nat-35.starnet.cz. [178.255.168.35]) by smtp.gmail.com with ESMTPSA id t1-v6sm1625850wmt.40.2018.06.06.05.41.44 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 06 Jun 2018 05:41:44 -0700 (PDT) From: Michal Simek To: linux-kernel@vger.kernel.org, monstr@monstr.eu, gnomes@lxorguk.ukuu.org.uk, Alexander Graf , shubhraj@xilinx.com, robh@kernel.org Subject: [RFC PATCH v2 1/6] serial: uartps: Do not initialize field to zero again Date: Wed, 6 Jun 2018 14:41:34 +0200 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180606_054156_603971_1E11715A X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Jiri Slaby MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Writing zero and NULLs to already initialized fields is not needed. Remove this additional writes. Signed-off-by: Michal Simek --- Changes in v2: - new patch - it can be sent separately too drivers/tty/serial/xilinx_uartps.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 8a3e34234e98..5f116f3ecd4a 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1510,15 +1510,12 @@ static int cdns_uart_probe(struct platform_device *pdev) /* At this point, we've got an empty uart_port struct, initialize it */ spin_lock_init(&port->lock); - port->membase = NULL; - port->irq = 0; port->type = PORT_UNKNOWN; port->iotype = UPIO_MEM32; port->flags = UPF_BOOT_AUTOCONF; port->ops = &cdns_uart_ops; port->fifosize = CDNS_UART_FIFO_SIZE; port->line = id; - port->dev = NULL; /* * Register the port.