| Message ID | ebb21da5cb41391421b364815705be8b4c415f8a.1732444746.git.andrea.porta@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for RaspberryPi RP1 PCI device using a DT overlay | expand |
On Sun, 24 Nov 2024 11:51:41 +0100, Andrea della Porta wrote: > The RP1 is a MFD that exposes its peripherals through PCI BARs. This > schema is intended as minimal support for the clock generator and > gpio controller peripherals which are accessible through BAR1. > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > --- > .../devicetree/bindings/misc/pci1de4,1.yaml | 74 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/misc/pci1de4,1.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb: clocks@c040018000: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/clock/raspberrypi,rp1-clocks.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ebb21da5cb41391421b364815705be8b4c415f8a.1732444746.git.andrea.porta@suse.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Rob, On 20:06 Sun 24 Nov , Rob Herring (Arm) wrote: > > On Sun, 24 Nov 2024 11:51:41 +0100, Andrea della Porta wrote: > > The RP1 is a MFD that exposes its peripherals through PCI BARs. This > > schema is intended as minimal support for the clock generator and > > gpio controller peripherals which are accessible through BAR1. > > > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > > --- > > .../devicetree/bindings/misc/pci1de4,1.yaml | 74 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 75 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/misc/pci1de4,1.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb: clocks@c040018000: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/clock/raspberrypi,rp1-clocks.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ebb21da5cb41391421b364815705be8b4c415f8a.1732444746.git.andrea.porta@suse.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. > Sorry about that, but even if I see that this should be the case (I've dropped the clock-name property from raspberrypi,rp1-clock.yaml), I can't reproduce it with: # make W=1 dt_binding_check DT_SCHEMA_FILES=pci1de4,1.yaml and the output is: CHKDT Documentation/devicetree/bindings LINT Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/misc/pci1de4,1.example.dts DTC [C] Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb dt-schema seems up to date. Is my command line correct? Many thanks, Andrea
On Mon, Nov 25, 2024 at 10:15:06AM +0100, Andrea della Porta wrote: > Hi Rob, > > On 20:06 Sun 24 Nov , Rob Herring (Arm) wrote: > > > > On Sun, 24 Nov 2024 11:51:41 +0100, Andrea della Porta wrote: > > > The RP1 is a MFD that exposes its peripherals through PCI BARs. This > > > schema is intended as minimal support for the clock generator and > > > gpio controller peripherals which are accessible through BAR1. > > > > > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > > > --- > > > .../devicetree/bindings/misc/pci1de4,1.yaml | 74 +++++++++++++++++++ > > > MAINTAINERS | 1 + > > > 2 files changed, 75 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/misc/pci1de4,1.yaml > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb: clocks@c040018000: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: http://devicetree.org/schemas/clock/raspberrypi,rp1-clocks.yaml# The error comes from this schema and... > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ebb21da5cb41391421b364815705be8b4c415f8a.1732444746.git.andrea.porta@suse.com > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit after running the above command yourself. Note > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > your schema. However, it must be unset to test all examples with your schema. > > > > Sorry about that, but even if I see that this should be the case (I've dropped > the clock-name property from raspberrypi,rp1-clock.yaml), I can't reproduce it > with: > > # make W=1 dt_binding_check DT_SCHEMA_FILES=pci1de4,1.yaml You've limited testing to schema files matching pci1de4,1.yaml. > > and the output is: > > CHKDT Documentation/devicetree/bindings > LINT Documentation/devicetree/bindings > DTEX Documentation/devicetree/bindings/misc/pci1de4,1.example.dts > DTC [C] Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb > > dt-schema seems up to date. Is my command line correct? > > Many thanks, > Andrea >
Hi Rob, On 07:21 Mon 25 Nov , Rob Herring wrote: > On Mon, Nov 25, 2024 at 10:15:06AM +0100, Andrea della Porta wrote: > > Hi Rob, > > > > On 20:06 Sun 24 Nov , Rob Herring (Arm) wrote: > > > > > > On Sun, 24 Nov 2024 11:51:41 +0100, Andrea della Porta wrote: > > > > The RP1 is a MFD that exposes its peripherals through PCI BARs. This > > > > schema is intended as minimal support for the clock generator and > > > > gpio controller peripherals which are accessible through BAR1. > > > > > > > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > > > > --- > > > > .../devicetree/bindings/misc/pci1de4,1.yaml | 74 +++++++++++++++++++ > > > > MAINTAINERS | 1 + > > > > 2 files changed, 75 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/misc/pci1de4,1.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb: clocks@c040018000: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+' > > > from schema $id: http://devicetree.org/schemas/clock/raspberrypi,rp1-clocks.yaml# > > The error comes from this schema and... > > > > > > > doc reference errors (make refcheckdocs): > > > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/ebb21da5cb41391421b364815705be8b4c415f8a.1732444746.git.andrea.porta@suse.com > > > > > > The base for the series is generally the latest rc1. A different dependency > > > should be noted in *this* patch. > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > > date: > > > > > > pip3 install dtschema --upgrade > > > > > > Please check and re-submit after running the above command yourself. Note > > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > > > your schema. However, it must be unset to test all examples with your schema. > > > > > > > Sorry about that, but even if I see that this should be the case (I've dropped > > the clock-name property from raspberrypi,rp1-clock.yaml), I can't reproduce it > > with: > > > > # make W=1 dt_binding_check DT_SCHEMA_FILES=pci1de4,1.yaml > > You've limited testing to schema files matching pci1de4,1.yaml. Ah I see. I thought that DT_SCHEMA_FILES just restrict the check to that particular file, instead it's also restricting all check of that file to itself. So I guess there's no way to check one specific file against all internally reference (e.g. from examples) schemas... Thanks for pointing that out! Regards, Andrea > > > > > and the output is: > > > > CHKDT Documentation/devicetree/bindings > > LINT Documentation/devicetree/bindings > > DTEX Documentation/devicetree/bindings/misc/pci1de4,1.example.dts > > DTC [C] Documentation/devicetree/bindings/misc/pci1de4,1.example.dtb > > > > dt-schema seems up to date. Is my command line correct? > > > > Many thanks, > > Andrea > >
diff --git a/Documentation/devicetree/bindings/misc/pci1de4,1.yaml b/Documentation/devicetree/bindings/misc/pci1de4,1.yaml new file mode 100644 index 000000000000..304d6b3d9e83 --- /dev/null +++ b/Documentation/devicetree/bindings/misc/pci1de4,1.yaml @@ -0,0 +1,74 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/misc/pci1de4,1.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: RaspberryPi RP1 MFD PCI device + +maintainers: + - Andrea della Porta <andrea.porta@suse.com> + +description: + The RaspberryPi RP1 is a PCI multi function device containing + peripherals ranging from Ethernet to USB controller, I2C, SPI + and others. + The peripherals are accessed by addressing the PCI BAR1 region. + +allOf: + - $ref: /schemas/pci/pci-ep-bus.yaml + +properties: + compatible: + additionalItems: true + maxItems: 3 + items: + - const: pci1de4,1 + + '#interrupt-cells': + const: 2 + description: + Specifies respectively the interrupt number and flags as defined + in include/dt-bindings/interrupt-controller/irq.h. + + interrupt-controller: true + +unevaluatedProperties: false + +required: + - compatible + - '#interrupt-cells' + - interrupt-controller + - pci-ep-bus@1 + +examples: + - | + pci { + #address-cells = <3>; + #size-cells = <2>; + + rp1@0,0 { + compatible = "pci1de4,1"; + ranges = <0x01 0x00 0x00000000 0x82010000 0x00 0x00 0x00 0x400000>; + #address-cells = <3>; + #size-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + + pci_ep_bus: pci-ep-bus@1 { + compatible = "simple-bus"; + ranges = <0xc0 0x40000000 0x01 0x00 0x00000000 0x00 0x00400000>; + dma-ranges = <0x10 0x00000000 0x43000000 0x10 0x00000000 0x10 0x00000000>; + #address-cells = <2>; + #size-cells = <2>; + + rp1_clocks: clocks@c040018000 { + compatible = "raspberrypi,rp1-clocks"; + reg = <0xc0 0x40018000 0x0 0x10038>; + #clock-cells = <1>; + clocks = <&clk_rp1_xosc>; + clock-names = "xosc"; + }; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index ccf123b805c8..2aea5a6166bd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19384,6 +19384,7 @@ RASPBERRY PI RP1 PCI DRIVER M: Andrea della Porta <andrea.porta@suse.com> S: Maintained F: Documentation/devicetree/bindings/clock/raspberrypi,rp1-clocks.yaml +F: Documentation/devicetree/bindings/misc/pci1de4,1.yaml F: Documentation/devicetree/bindings/pci/pci-ep-bus.yaml F: Documentation/devicetree/bindings/pinctrl/raspberrypi,rp1-gpio.yaml F: include/dt-bindings/clock/rp1.h
The RP1 is a MFD that exposes its peripherals through PCI BARs. This schema is intended as minimal support for the clock generator and gpio controller peripherals which are accessible through BAR1. Signed-off-by: Andrea della Porta <andrea.porta@suse.com> --- .../devicetree/bindings/misc/pci1de4,1.yaml | 74 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 75 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/pci1de4,1.yaml