From patchwork Mon Mar 13 21:37:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 9622169 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 75B8560414 for ; Mon, 13 Mar 2017 21:37:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6444B28506 for ; Mon, 13 Mar 2017 21:37:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 55D15284F5; Mon, 13 Mar 2017 21:37:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D64BB284F5 for ; Mon, 13 Mar 2017 21:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eF9PQ6aoAAdYZ0rTpusibt8Ew+Def0elIYLtYWCCP8w=; b=WE88bF2CNLvkDJmTWNj42045t gdrGsuY5VVHpj9xHC3B6xJqxxT0LJgSG3yUT6hknU2VumsJdD63PWLzNiQyrxZpEHOqt6QILs8c+0 eZP16CBHdum6dtygRKFwITwEEFAjLnntd/HOo+0qfzFOJEUibJOdMNf4kaEpGnZMC7C7wl0je5ODA 3a0l4M75LKzpHAHnlJPsXNn621tkVUDzzj2tex+lkwuknSpzt1kXcNqtToE7c0sJq/DF+a4ncxxG3 FPOmNdUi3nP5CRXblA2KwHdev7DSZlJEU8Q+f1x7HkN0dItxuaXJc9tjg8JXmUtslXJfluLvi8VF9 G2VBAYEdw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cnXfB-00024l-G4; Mon, 13 Mar 2017 21:37:57 +0000 Received: from 3.mo177.mail-out.ovh.net ([46.105.36.172]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cnXf6-00020d-RT for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2017 21:37:55 +0000 Received: from player688.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo177.mail-out.ovh.net (Postfix) with ESMTP id A31643BD05 for ; Mon, 13 Mar 2017 22:37:24 +0100 (CET) Received: from linux-samsung.lan (ip-194-187-74-233.konfederacka.maverick.com.pl [194.187.74.233]) (Authenticated sender: rafal@milecki.pl) by player688.ha.ovh.net (Postfix) with ESMTPSA id 1AB3B2006E; Mon, 13 Mar 2017 22:37:12 +0100 (CET) Subject: Re: [PATCH] ARM: dts: BCM5301X: Add support for TP-LINK Archer C5 V2 To: Jon Mason References: <20170311121453.18534-1-zajec5@gmail.com> <20170312171032.GK15842@lunn.ch> <437d898d-b0f4-a4b5-cb51-8ea88ba7a35a@milecki.pl> <20170313191416.GB10397@lunn.ch> <89081716-c0e3-236f-4291-e700dbedbd34@milecki.pl> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: Date: Mon, 13 Mar 2017 22:37:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: X-Ovh-Tracer-Id: 1230608600802561788 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelhedrheeggdduhedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170313_143753_050856_2E8C4BF1 X-CRM114-Status: GOOD ( 15.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Andrew Lunn , Florian Fainelli , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Hauke Mehrtens , Rafa?? Mi??ecki , Russell King , Rob Herring , BCM Kernel Feedback , John Crispin , linux-arm-kernel Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 03/13/2017 08:27 PM, Jon Mason wrote: > On Mon, Mar 13, 2017 at 3:15 PM, Rafał Miłecki wrote: >> On 03/13/2017 08:14 PM, Andrew Lunn wrote: >>> >>> On Mon, Mar 13, 2017 at 07:48:26PM +0100, Rafa?? Mi??ecki wrote: >>>> >>>> On 03/12/2017 06:10 PM, Andrew Lunn wrote: >>>>>> >>>>>> + chosen { >>>>>> + bootargs = "console=ttyS0,115200 earlycon"; >>>>> >>>>> >>>>> Using bootargs to pass the serial settings has been deprecated for a >>>>> while. Please use stdout-path instead. >>>> >>>> >>>> I tried following patch with my SR400ac (I put Archer C5 aside for now). >>> >>> >>> Hi Rafael >>> >>> Take a look at for example the bcm911360k.dts >>> >>> aliases { >>> serial0 = &uart3; >>> }; >>> >>> chosen { >>> stdout-path = "serial0:115200n8"; >>> }; >>> >>> You need an alias to the serial device you want to us, and you should >>> list the speed, parity, bits etc. >> >> >> That was actually my first try (just with s/uart3/uart0) and I got the same >> problem. > > I have a similar line in the bcm953012k.dts, and the serial there works for me. Well, the serial seems to work OK (I'm getting boot log & I can see my chars being echoed back). I just can't log in. Can this kernel change somehow affect user space? I also tried method with alias, etc. (see below), it doesn't help, Also since serial console works, I'm not sure if decompiling dtb will show anything. diff --git a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts index 36b628b..a5442a9 100644 --- a/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts +++ b/arch/arm/boot/dts/bcm4708-smartrg-sr400ac.dts @@ -17,7 +17,7 @@ model = "SmartRG SR400ac"; chosen { - bootargs = "console=ttyS0,115200 earlycon"; + bootargs = "earlycon"; }; memory { diff --git a/arch/arm/boot/dts/bcm5301x.dtsi b/arch/arm/boot/dts/bcm5301x.dtsi index 4fbb089..5a9fa3e 100644 --- a/arch/arm/boot/dts/bcm5301x.dtsi +++ b/arch/arm/boot/dts/bcm5301x.dtsi @@ -18,8 +18,12 @@ / { interrupt-parent = <&gic>; + aliases { + serial0 = &uart0; + }; + chosen { - stdout-path = &uart0; + stdout-path = "serial0:115200n8"; }; chipcommonA {