From patchwork Tue Nov 8 15:53:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 9417675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C8F2B60459 for ; Tue, 8 Nov 2016 15:56:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BA4A428B90 for ; Tue, 8 Nov 2016 15:56:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id AE7C828B93; Tue, 8 Nov 2016 15:56:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 20E0B28B90 for ; Tue, 8 Nov 2016 15:56:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c48j7-0006Iv-4g; Tue, 08 Nov 2016 15:54:21 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c48j0-0005j8-If for linux-arm-kernel@lists.infradead.org; Tue, 08 Nov 2016 15:54:16 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OGB006UIYTQPI70@mailout1.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 08 Nov 2016 15:53:50 +0000 (GMT) Received: from eusmges1.samsung.com (unknown [203.254.199.239]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20161108155349eucas1p1651e4898e161a24632fc9b2997b6ddcf~FHXJbJFvU0309603096eucas1p15; Tue, 8 Nov 2016 15:53:49 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1.samsung.com (EUCPMTA) with SMTP id CF.64.23383.E05F1285; Tue, 8 Nov 2016 15:53:50 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20161108155348eucas1p2fd2ec7583c14999305647983f809f062~FHXIwVoeH1407114071eucas1p2X; Tue, 8 Nov 2016 15:53:48 +0000 (GMT) X-AuditID: cbfec7ef-f79e76d000005b57-e1-5821f50e6aa6 Received: from eusync4.samsung.com ( [203.254.199.214]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 26.AB.10494.FE4F1285; Tue, 8 Nov 2016 15:53:19 +0000 (GMT) Received: from [106.116.147.40] by eusync4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OGB00HGEYTGUT30@eusync4.samsung.com>; Tue, 08 Nov 2016 15:53:48 +0000 (GMT) Subject: Re: [PATCH RFC 2/7] ARM: S3C64XX: Add DMA slave maps for PL080 devices To: Charles Keepax From: Sylwester Nawrocki Message-id: Date: Tue, 08 Nov 2016 16:53:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-version: 1.0 In-reply-to: <20161108145534.GE1575@localhost.localdomain> X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHec/Z5Ww6OU3TB8vMZZShphV10BDtAocKKhAcfrGlBxWv7Khk X7SUzOvMCy1LMBMVZ6RzOStvbaaBYIqiQ0ozb3kjSaW81raj4Lff/33+z/O8/5eXwKWtfGci Oj6JUcYrYmUCMa+5e73Py27NTe6Tu+BE6btm+NR2UbeQKp2YElA7JSYhpSnd5lOLS/UYpZpc wCnt5DCfUn9px6iB2lWMmivo4FF5Df/4gbb05kYRot+VfRPSr1rnMFpbly2gm6rS6LknmwJa pzKfF+jqEL2iPXJLFCq+GMHERqcwytMBd8RRS5MGLHHV7l7Te2E6MtnkIBEB5Dnoz9Ijjh2h f+yNIAeJCSlZjaB8qhPjxAqCZ0Y12ut4WVqLWdjqWl68yplmEegyNDxLwZ68DaOvJ6zsQFJQ UjWKWxgnCzBYfxhuYQHpC/mfCqxDJWQAPBgfsXp45HEYet5rXXCQlMPHRs2u5wD8LR6zzhSR fjBS3ifkZvqAusSIcewKTfVLuOVCQM4JIbNPbRaEWbiAthPnAlwB/VYLxrE9zPfohBwfhsHi XB7Xq0LwuT4DcUKN4GtW4W6HPxh7BvjcNjsoan66u0ACjx9JOQsNjSo1n+MgWEv/jnOvpccg szCsELmW7ctTti9D2b4MFQivQw5MMhsXybC+3qwijk2Oj/QOT4jTIvOf6t3p+dWCpjOCDYgk kMxWQo67yaV8RQqbGmdAQOAyB8mNKfORJEKRep9RJoQpk2MZ1oAOETyZk6StYihESkYqkpgY hklklHtVjBA5p6PqnJg/lbUN591LK4721nqogx3F/oxzfjsEbiTJ6e2bpp+SF0E7uVGeVMus TYffTCVbI+w7Mbh0+Vrx0IfqEVNeY68hwah5myFO9zwTjG+FZsuDNCfT5hnS/XrxpZpKl7aQ rkoGa/692uj0Y+vu2WFXw7JX4sSFHY/pY4TMD8l4bJTC9xSuZBX/AYhfN5xPAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDIsWRmVeSWpSXmKPExsVy+t/xa7rvvyhGGNyepGKx/cgzVou/k46x W0x9+ITN4t+UG+wWq6f+ZbV483YNk0X/49fMFpseX2O1mHF+H5PFxRVfmCxe9u1nsejZ8J/V gcfj969JjB47Z91l91i85yWTx6ZVnWwem5fUe7yc+JvNY0s/ULxvyypGj8+b5AI4o9xsMlIT U1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoSc0qBPCMDNODgHOAerKRvl+CW 8fbxIaaCL3wVm3exNzDe4O5i5OSQEDCRWDh1BROELSZx4d56ti5GLg4hgSWMEl1dcxghnOeM Ek+eLGcGqRIW8JfY1fKVDcQWEbCQmLLkFjNE0XYmiX9vHrOAOMwCfUwSt54sZAWpYhMwlOg9 2scIYvMK2Ek03r8ONolFQFXiyuzTYLtFBSIkNn2dwwJRIyjxY/I9MJtTwEri+txz7F2MHEBD 9STuX9QCCTMLyEtsXvOWeQKjwCwkHbMQqmYhqVrAyLyKUSS1tDg3PbfYSK84Mbe4NC9dLzk/ dxMjMGa3Hfu5ZQdj17vgQ4wCHIxKPLwZDxUjhFgTy4orcw8xSnAwK4nw+jwBCvGmJFZWpRbl xxeV5qQWH2I0BXphIrOUaHI+MJ3klcQbmhiaWxoaGVtYmBsZKYnzTv1wJVxIID2xJDU7NbUg tQimj4mDU6qBcXqi+/tnrqIJL/lYorQZBcUfHk/Lsja/tTSwQa9sxspXutUbpOT1uBODBLJW hTwrtu1dev9Q5YackL8s/NWBjB4qK+Z6lzp+fXbL4r9Wchfjge2sxk1fp7FwyJdJMXLoMFaU 5z56a2v3/murJiNjonye4YmS/I3MW769ce45Zao6Z8Lq/NdKLMUZiYZazEXFiQCpJaC87wIA AA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161108155348eucas1p2fd2ec7583c14999305647983f809f062 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161108145620epcas2p4b8e2ec5ffdd4bf04ab3bf0728b46e3f2 X-RootMTR: 20161108145620epcas2p4b8e2ec5ffdd4bf04ab3bf0728b46e3f2 References: <1478276094-19135-1-git-send-email-s.nawrocki@samsung.com> <1478276094-19135-4-git-send-email-s.nawrocki@samsung.com> <20161108144445.GD1575@localhost.localdomain> <20161108145534.GE1575@localhost.localdomain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161108_075414_846380_DEEABAB0 X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, arnd@arndb.de, vinod.koul@intel.com, sbkim73@samsung.com, andi.shyti@samsung.com, javier@osg.samsung.com, broonie@kernel.org, kgene@kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ym0914@gmail.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/08/2016 03:55 PM, Charles Keepax wrote: >>> diff --git a/arch/arm/mach-s3c64xx/pl080.c b/arch/arm/mach-s3c64xx/pl080.c >>> > > index 89c5a62..8c88680 100644 >>> > > --- a/arch/arm/mach-s3c64xx/pl080.c >>> > > +++ b/arch/arm/mach-s3c64xx/pl080.c >> > >>> > > @@ -134,6 +153,8 @@ struct pl08x_platform_data s3c64xx_dma0_plat_data = { >>> > > .put_xfer_signal = pl08x_put_xfer_signal, >>> > > .slave_channels = s3c64xx_dma0_info, >>> > > .num_slave_channels = ARRAY_SIZE(s3c64xx_dma0_info), >>> > > + .slave_map = s3c64xx_dma0_slave_map, >>> > > + .slavecnt = ARRAY_SIZE(s3c64xx_dma0_slave_map), >>> > > }; >> > >> > Here we add a .slavecnt but the pl08x_platform_data structure doesn't >> > contain that field. I can't see it on the branch you linked in >> > the cover letter either, is it added by a patch on another branch >> > I am missing? >> > > Ah I think I see it should be .slave_map_len here. Yeah, sorry, I fixed it after getting report from the kbuild test but have forgotten to push changes to the git tree. I pushed now to branch for-v4.10/dma/pl080-s3c64xx-v2 with this issue fixed and added initialization of the filer function. -------------------8<------------------------- Tested-by: Charles Keepax --- Thanks, Sylwester diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index 939a7c3..d441c4b 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -2307,6 +2307,10 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id) ret = -EINVAL; goto out_no_platdata; } + } else { + pl08x->slave.filter.map = pl08x->pd->slave_map; + pl08x->slave.filter.mapcnt = pl08x->pd->slave_map_len; + pl08x->slave.filter.fn = pl08x_filter_id; } -------------------8<-------------------------