From patchwork Tue Nov 8 16:02:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sylwester Nawrocki/Kernel \\(PLT\\) /SRPOL/Staff Engineer/Samsung Electronics" X-Patchwork-Id: 9417687 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E902A60459 for ; Tue, 8 Nov 2016 16:04:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D820428898 for ; Tue, 8 Nov 2016 16:04:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C9E2C28A88; Tue, 8 Nov 2016 16:04:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 68DF128898 for ; Tue, 8 Nov 2016 16:04:44 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c48rh-0003XZ-FI; Tue, 08 Nov 2016 16:03:13 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c48rd-0003QY-1i for linux-arm-kernel@lists.infradead.org; Tue, 08 Nov 2016 16:03:10 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OGB0047DZ8MLV80@mailout1.w1.samsung.com> for linux-arm-kernel@lists.infradead.org; Tue, 08 Nov 2016 16:02:46 +0000 (GMT) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20161108160246eucas1p1208766c432f73b86ca3e3096aa4e7cb5~FHe89ZIfJ3156031560eucas1p1c; Tue, 8 Nov 2016 16:02:46 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id DC.55.02283.527F1285; Tue, 8 Nov 2016 16:02:45 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20161108160245eucas1p1f93a86960d1952d236cc58ed74c1f525~FHe8URssN3150431504eucas1p1R; Tue, 8 Nov 2016 16:02:45 +0000 (GMT) X-AuditID: cbfec7f1-f79f46d0000008eb-f6-5821f7250f8b Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B5.4D.07726.427F1285; Tue, 8 Nov 2016 16:02:44 +0000 (GMT) Received: from [106.116.147.40] by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OGB005CAZ8K9GB0@eusync1.samsung.com>; Tue, 08 Nov 2016 16:02:45 +0000 (GMT) Subject: Re: [PATCH RFC 0/7] DMA: S3C64XX: Conversion to the new channel request API To: Charles Keepax From: Sylwester Nawrocki Message-id: Date: Tue, 08 Nov 2016 17:02:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-version: 1.0 In-reply-to: <20161108153949.GF1575@localhost.localdomain> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHKsWRmVeSWpSXmKPExsWy7djP87qq3xUjDE4+1LPYfuQZq8XfScfY LaY+fMJm8W/KDXaL1VP/slq8ebuGyaL/8Wtmi02Pr7FazDi/j8ni4oovTBYv+/azWPRs+M/q wOPx+9ckRo+ds+6yeyze85LJY9OqTjaPzUvqPV5O/M3msaUfKN63ZRWjx+dNcgGcUVw2Kak5 mWWpRfp2CVwZe9e2MBWc5Kx4+vY6ewPjNvYuRk4OCQETiW1n70PZYhIX7q1n62Lk4hASWMoo cenxd2YI5zOjxO/++2wwHdO6rrJAJJYBJS5/hXKeM0qsuvGcCaRKWCBMYuPEHcwgtoiAhcSU JbfAbGaBPiaJn03JIDabgKFE79E+RhCbV8BOov/5EzCbRUBV4uDeL2BzRAUiJA5uXA1VIyjx Y/I9FhCbU8BKYvPlj+wQMw0kZkw5zARhy0tsXvMW7GwJgZfsEn0zbwI1cAA5shKbDjBDfOAi 0XrnJSuELSzx6vgWqP9lJDo7DjJB9PYzSpxY08wI4cxglLjTPoEJospa4vDxi6wQ2/gkJm2b zgyxgFeio00IosRDYtvvpVBhR4l77fGQAGpnklix6hnTBEb5WUj+mYXkh1lIfljAyLyKUSS1 tDg3PbXYSK84Mbe4NC9dLzk/dxMjMFWd/nf84w7G9yesDjEKcDAq8fBmPFSMEGJNLCuuzD3E KMHBrCTC6/MEKMSbklhZlVqUH19UmpNafIhRmoNFSZx3z4Ir4UIC6YklqdmpqQWpRTBZJg5O qQZGvsMhhyfycRRvPrPolN+nS4uCa9jjOJfFiP/6IVIoJ/NW2F/sh5W7j4KkZfrs0iexTorb mkPjdbMTLM9bfD9/6nmdZ2/hz0n9H6+ZCRldqlJ6psFQHbnlndjBillqhVXnmlf9lv4od2Wr oMVFhll3b92Tdz3DkMN2ZRmH0/IfzWeEetZoXX+uxFKckWioxVxUnAgAqyZsJlEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsVy+t/xy7oq3xUjDLb3qVpsP/KM1eLvpGPs FlMfPmGz+DflBrvF6ql/WS3evF3DZNH/+DWzxabH11gtZpzfx2RxccUXJouXfftZLHo2/Gd1 4PH4/WsSo8fOWXfZPRbvecnksWlVJ5vH5iX1Hi8n/mbz2NIPFO/bsorR4/MmuQDOKDebjNTE lNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nbJbhl 7F3bwlRwkrPi6dvr7A2M29i7GDk5JARMJKZ1XWWBsMUkLtxbz9bFyMUhJLCEUeLf7SXsEM5z Ronv996zgVQJC4RJbJy4gxnEFhGwkJiy5BYzRFE7k8T1VesZQRxmgT4miVtPFrKCVLEJGEr0 Hu1jBLF5Bewk+p8/AbNZBFQlDu79wgRiiwpESGz6OocFokZQ4sfke2A2p4CVxObLH4HO4AAa qidx/6IWSJhZQF5i85q3zBMYBWYh6ZiFUDULSdUCRuZVjCKppcW56bnFhnrFibnFpXnpesn5 uZsYgVG77djPzTsYL20MPsQowMGoxMOb8VAxQog1say4MvcQowQHs5IIr88ToBBvSmJlVWpR fnxRaU5q8SFGU6AXJjJLiSbnAxNKXkm8oYmhuaWhkbGFhbmRkZI4b8mHK+FCAumJJanZqakF qUUwfUwcnFINjG1FF5SPP4wsYguSNzW8HKk1+9gml1sl7Scmz4qqPJv637GBR33B4Zs79YyF nCSFrsu/sjqirpK1bvsd6d0HZ1qIh88KvRCps1HswMHsBJYoG4MujdVre7ZbXgroMy+XXcn1 aKbLz62Hp/1JNj+7ksv52IbsdKtHnP3Rmyacktvy92l/fVqTpBJLcUaioRZzUXEiAHaP1mPw AgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20161108160245eucas1p1f93a86960d1952d236cc58ed74c1f525 X-Msg-Generator: CA X-Sender-IP: 182.198.249.179 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20161108154037epcas4p34b3004ca2ffb63275be42edec4c91f6e X-RootMTR: 20161108154037epcas4p34b3004ca2ffb63275be42edec4c91f6e References: <1478276094-19135-1-git-send-email-s.nawrocki@samsung.com> <1478276094-19135-2-git-send-email-s.nawrocki@samsung.com> <20161108153949.GF1575@localhost.localdomain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161108_080309_317288_FD803AD1 X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, arnd@arndb.de, vinod.koul@intel.com, sbkim73@samsung.com, andi.shyti@samsung.com, javier@osg.samsung.com, broonie@kernel.org, kgene@kernel.org, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ym0914@gmail.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/08/2016 04:39 PM, Charles Keepax wrote: > Hmm... fixing the bug I mentioned in my other email this still > seems to cause some problems with my SPI on Cragganmore: > > [ 200.210213] wm0010 spi0.0: I/O Error: rx-1 tx-1 res:rx-f tx-f len-2632 > [ 200.211275] wm0010 spi0.0: SPI transfer failed: -5 > > I am still looking into it, without your patches work the wm0010 > comes up. A few other small things seem to have been broken in > mainline since last time I fired up this board as well which is > slowing me down a little (network seems to have stopped coming > up and one of the regulators on the SD card is spamming me with > warnings). Thanks for giving it a try. Is it any better with a change as below? diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index d5c75c8..d441c4b 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -2310,6 +2310,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id) } else { pl08x->slave.filter.map = pl08x->pd->slave_map; pl08x->slave.filter.mapcnt = pl08x->pd->slave_map_len; + pl08x->slave.filter.fn = pl08x_filter_id; }