| Message ID | fbde85a5e8ae99b10a2115d8ea1e69320a62947f.1657084786.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | perf/arm-cci: Use the bitmap API to allocate bitmaps | expand |
On Wed, 6 Jul 2022 07:20:15 +0200, Christophe JAILLET wrote: > Use devm_bitmap_zalloc() instead of hand-writing it. > It is less verbose and it improves the semantic. > > While at it, use bitmap_zero() instead of hand-writing it. > > Applied to will (for-next/perf), thanks! [1/1] perf/arm-cci: Use the bitmap API to allocate bitmaps https://git.kernel.org/will/c/0e35850b341e Cheers,
diff --git a/drivers/perf/arm-cci.c b/drivers/perf/arm-cci.c index 16a272c8d4b3..03b1309875ae 100644 --- a/drivers/perf/arm-cci.c +++ b/drivers/perf/arm-cci.c @@ -1261,7 +1261,7 @@ static int validate_group(struct perf_event *event) */ .used_mask = mask, }; - memset(mask, 0, BITS_TO_LONGS(cci_pmu->num_cntrs) * sizeof(unsigned long)); + bitmap_zero(mask, cci_pmu->num_cntrs); if (!validate_event(event->pmu, &fake_pmu, leader)) return -EINVAL; @@ -1629,10 +1629,9 @@ static struct cci_pmu *cci_pmu_alloc(struct device *dev) GFP_KERNEL); if (!cci_pmu->hw_events.events) return ERR_PTR(-ENOMEM); - cci_pmu->hw_events.used_mask = devm_kcalloc(dev, - BITS_TO_LONGS(CCI_PMU_MAX_HW_CNTRS(model)), - sizeof(*cci_pmu->hw_events.used_mask), - GFP_KERNEL); + cci_pmu->hw_events.used_mask = devm_bitmap_zalloc(dev, + CCI_PMU_MAX_HW_CNTRS(model), + GFP_KERNEL); if (!cci_pmu->hw_events.used_mask) return ERR_PTR(-ENOMEM);
Use devm_bitmap_zalloc() instead of hand-writing it. It is less verbose and it improves the semantic. While at it, use bitmap_zero() instead of hand-writing it. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/perf/arm-cci.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)