From patchwork Thu Jul 5 05:09:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10507943 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9BB5860325 for ; Thu, 5 Jul 2018 05:10:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89F7D28DE7 for ; Thu, 5 Jul 2018 05:10:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7CBAB28DEC; Thu, 5 Jul 2018 05:10:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1C42F28DE7 for ; Thu, 5 Jul 2018 05:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=vMzHHmPUYivCdvm24nETICWhnp9Yto5K3D4fw6/hEzQ=; b=p9dmWExkYumEyFjL6AWoulzj8O uv2qaZPEBKc86s4A5firKUFMf1+jZbs5Rhc9mramSvVehEshRiT6RN/ZvbY0bMy52htnr5AyQ0GfB 1dEQwIj2tC4fY4uqGZTOyuB1J6METx8oc3gKjy+QqXGYEzzKMCOhBCPbWNV2K3nrQ6Cn6M5i+Q4kr RARgaz0N8UQu/MgAtrntGxvL6lqbRp6epLgfPtb3PkXiyrh8dlyt+UAtVVXEUroVOcvLNw6SVIzsV F0Ii5MXN7m8/Do/enBp1bjRmj3DSrtn6aFSjZM8If482LCCxhBq9kEmC2jBcypG5l60rTo5vY2T+V I2UPmCLA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fawWp-0005zn-II; Thu, 05 Jul 2018 05:10:03 +0000 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fawWX-0005lI-6C for linux-arm-kernel@lists.infradead.org; Thu, 05 Jul 2018 05:09:49 +0000 Received: by mail-pf0-x242.google.com with SMTP id q7-v6so3222504pff.2 for ; Wed, 04 Jul 2018 22:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+5ItNYTYeiKz+mT0Uq7k5mUE+h7almHMaSv0njAJGPc=; b=C1B6R/QiTyttjB+gnxPIQfMOeSYwVVfnSeY4onNWi6WmZ4DTgRecmoX9QKinq8HODh sug3aU2uKP0C+2tj3WA+GE/aAPhkD0kQea79sOTWq0btUo8uDSgagQ4MHUz2dB6vg8lq p8RLTYovNwyyigN+Ku0KcHBXqVqtHRFVgNUxE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+5ItNYTYeiKz+mT0Uq7k5mUE+h7almHMaSv0njAJGPc=; b=I01m+e/jFN12Rx1i0Ycy1rIs2SVkAPV3tQW2VKCW/9HuB36AwVcikqddEXjot9tJ4v x43vboVkaItXmlQxEE5yAknRGTxFtFLe5I0E9GVZrYKwc+RIp2PMz680ANiKXL+W6vcX 1zexGqQ2JLC08NKEaQfHQgh5udFgXJv6OnZul9rDEc6EecNx4ahsTCV2Xr01YEFwxjTE OjomZEwKVTan3XRrBBi7skDTXdEuEWIyvBJ+NfXOeggkkoy0Hoj4/yrXuq86LtnbFv4G KBNVYxHWkoFwf7WN6oF0L4C+eTIyh61VDnHcSqxXKK7NY4wtDUSd1gH7QE7YWyPDlZvz 33yg== X-Gm-Message-State: APt69E1d1VVdUDs36qkT5TaSyME7Dco+0swpwO3FPJ/D337UpiGqJWJs rEeimjK0aTNoaEyrWZx3DKEi1A== X-Google-Smtp-Source: AAOMgpfD16zRbyggutR+hU2YxXVeYKtpE7KT9ZlIOF8Jek2W9xdERrHhfEsbv1u7vWN7Hr6+ZGLIYg== X-Received: by 2002:a62:a05:: with SMTP id s5-v6mr4791283pfi.147.1530767374020; Wed, 04 Jul 2018 22:09:34 -0700 (PDT) Received: from localhost ([122.172.117.17]) by smtp.gmail.com with ESMTPSA id s22-v6sm8983090pgs.34.2018.07.04.22.09.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Jul 2018 22:09:33 -0700 (PDT) From: Viresh Kumar To: Zhang Rui , Eduardo Valentin , robh@kernel.org, Wei Xu Subject: [PATCH 2/2] arm64: dts: hi6220: Add all CPUs in cooling maps Date: Thu, 5 Jul 2018 10:39:24 +0530 Message-Id: X-Mailer: git-send-email 2.18.0.rc1.242.g61856ae69a2c In-Reply-To: References: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180704_220945_564144_DFE225A4 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vincent Guittot , linux-pm@vger.kernel.org, Viresh Kumar , Daniel Lezcano , linux-kernel@vger.kernel.org, olof@lixom.net, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Each CPU can (and does) participate in cooling down the system but the DT only captures the CPU0 in the cooling maps. Things work by chance as under normal circumstances its the CPU0 which is used by the operating systems to probe the cooling devices. But as soon as that ordering changes and any other CPU is used to bring up the cooling device, we will start seeing errors. On the other hand, the hardware is partially defined in DT in these cases and we must do a better job by capturing all devices. Add all devices (CPUs here) in the cooling maps which are also affected by the trip point. Signed-off-by: Viresh Kumar Acked-by: Daniel Lezcano --- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi index 247024df714f..919d36b91bf3 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi @@ -886,7 +886,14 @@ cooling-maps { map0 { trip = <&target>; - cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };