From patchwork Fri Jul 22 10:27:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Imre Kaloz X-Patchwork-Id: 998602 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6MARbco009054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 22 Jul 2011 10:27:58 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QkCx5-0007IX-2t; Fri, 22 Jul 2011 10:27:27 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QkCx4-0002vR-NV; Fri, 22 Jul 2011 10:27:26 +0000 Received: from arrakis.dune.hu ([78.24.191.176]) by canuck.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QkCx1-0002v9-9X for linux-arm-kernel@lists.infradead.org; Fri, 22 Jul 2011 10:27:24 +0000 Received: from localhost (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id D82B223C00A3; Fri, 22 Jul 2011 12:27:20 +0200 (CEST) X-Virus-Scanned: at arrakis.dune.hu X-Spam-Flag: NO X-Spam-Score: -2.633 X-Spam-Level: X-Spam-Status: No, score=-2.633 required=5 tests=[ALL_TRUSTED=-1.8, AWL=0.636, BAYES_00=-2.599, DNS_FROM_OPENWHOIS=1.13] autolearn=no Received: from arrakis.dune.hu ([127.0.0.1]) by localhost (arrakis.dune.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7XZkJN9P+m7R; Fri, 22 Jul 2011 12:27:19 +0200 (CEST) Received: from ecaz (firewall.ahiv.hu [195.228.168.220]) by arrakis.dune.hu (Postfix) with ESMTPSA id 2113D23C009F; Fri, 22 Jul 2011 12:27:19 +0200 (CEST) To: "Russell King - ARM Linux" Subject: Re: [PATCH v2] ARM: support XZ compressed kernels References: <1310475369-3000-1-git-send-email-kaloz@openwrt.org> <20110715162519.GC24628@n2100.arm.linux.org.uk> <20110719110235.GH26574@n2100.arm.linux.org.uk> <20110719110717.GI26574@n2100.arm.linux.org.uk> <20110722091604.GC21416@n2100.arm.linux.org.uk> <20110722095738.GE21416@n2100.arm.linux.org.uk> Date: Fri, 22 Jul 2011 12:27:18 +0200 MIME-Version: 1.0 From: "Imre Kaloz" Organization: OpenWrt - Wireless Freedom Message-ID: In-Reply-To: <20110722095738.GE21416@n2100.arm.linux.org.uk> X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110722_062723_474701_D1697BD5 X-CRM114-Status: GOOD ( 20.39 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- Cc: linux-arm-kernel@lists.infradead.org, nico@fluxnic.net X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 22 Jul 2011 10:27:58 +0000 (UTC) On Fri, 22 Jul 2011 11:57:38 +0200, Russell King - ARM Linux wrote: > On Fri, Jul 22, 2011 at 11:52:19AM +0200, Imre Kaloz wrote: > >> Guessed I'm not the one outside the ARM community, so.. I can say it >> didn't break neither ppc or mips for me, but have no idea who's feedback >> are you waiting for. > > What I'm concerned about is the apparant lack of exposure of the patch > to people outside of ARM, especially as it touches lib/xz/xz_dec_stream.c. > > I have no idea whether that breaks some architecture or not. > > Is Lasse Collin (the original contributer of that file) aware of this > change? > > What is the additional include fixing on ARM? Why isn't this include > needed on other architectures? And why isn't any of this mentioned in > the patch commit log? > It's needed because of missing min_t - but just looked a bit further and it seems decompress.c should use kernel.h - so I send v3 right away with the following change if you agree: --- a/arch/arm/boot/compressed/decompress.c +++ b/arch/arm/boot/compressed/decompress.c @@ -1,7 +1,7 @@ #define _LINUX_STRING_H_ #include /* for inline */ -#include /* for size_t */ +#include /* for min_t */ #include /* for NULL */ #include #include