[v3,0/6] MSM8998 basic USB support

Message

Jeffrey Hugo Jan. 21, 2019, 9:31 p.m. UTC

This series provides basic USB support for MSM8998.  Currently missing is
wiring up the Type-C detection logic so that the controller can correctly
switch between host and peripheral modes.  Work to implement that is
ongoing, and expected to appear soon in followup patches.  Also missing is
Display Port (DP) support which apparently is different from sdm845 and
needs additional investigation.

v3:
-Dropped accepted phy changes
-Changed DT node labels per discussion with Bjorn
-Made DT reg property addresses fill width
-Added Bjorn's reviewed-by

v2:
-Fixed typo in QUSB2 bindings changes
-Split out bindings changes
-Fixed dual lane support in QMP to reflect Doug's updates
-Dropped the clock fixes which were accepted

Jeffrey Hugo (6):
  clk: qcom: Add missing freq for usb30_master_clk on 8998
  clk: qcom: Skip halt checks on gcc_usb3_phy_pipe_clk for 8998
  phy: qcom-qusb2: Add QUSB2 PHY support for msm8998
  phy: qcom-qmp: Add QMP V3 USB3 PHY support for msm8998
  usb: dwc3: qcom: Add support for MSM8998
  arm64: dts: qcom: msm8998: Add USB-related nodes

 .../devicetree/bindings/phy/qcom-qmp-phy.txt       |   5 +
 .../devicetree/bindings/phy/qcom-qusb2-phy.txt     |   1 +
 .../devicetree/bindings/usb/qcom,dwc3.txt          |   1 +
 arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi          |  22 ++++
 arch/arm64/boot/dts/qcom/msm8998.dtsi              |  90 +++++++++++++
 drivers/clk/qcom/gcc-msm8998.c                     |   3 +-
 drivers/phy/qualcomm/phy-qcom-qmp.c                | 142 +++++++++++++++++++++
 drivers/phy/qualcomm/phy-qcom-qmp.h                |   4 +
 drivers/phy/qualcomm/phy-qcom-qusb2.c              |  41 ++++++
 drivers/usb/dwc3/dwc3-qcom.c                       |   1 +
 10 files changed, 309 insertions(+), 1 deletion(-)

Comments

Marc Gonzalez Feb. 13, 2019, 11:55 a.m. UTC | #1

On 21/01/2019 22:31, Jeffrey Hugo wrote:

> This series provides basic USB support for MSM8998.  Currently missing is
> wiring up the Type-C detection logic so that the controller can correctly
> switch between host and peripheral modes.  Work to implement that is
> ongoing, and expected to appear soon in followup patches.  Also missing is
> Display Port (DP) support which apparently is different from sdm845 and
> needs additional investigation.

FTR and FWIW:

_regmap_update_bits: reg=88014 old=3 new=2
[    CLK_BASE + 88014] = 00000002
------------[ cut here ]------------
gcc_rx1_usb2_clkref_clk status stuck at 'on'
WARNING: CPU: 3 PID: 1 at drivers/clk/qcom/clk-branch.c:92 clk_branch_toggle+0x19c/0x1c0
Modules linked in:
CPU: 3 PID: 1 Comm: swapper/0 Tainted: G S      W         5.0.0-rc6 #13
Hardware name: Qualcomm Technologies, Inc. MSM8998 v1 MTP (DT)
pstate: 60000085 (nZCv daIf -PAN -UAO)
pc : clk_branch_toggle+0x19c/0x1c0
lr : clk_branch_toggle+0x19c/0x1c0
sp : ffffff801005bc60
x29: ffffff801005bc60 x28: ffffff8010627464 
x27: ffffff8010c7b000 x26: ffffff80105b06d4 
x25: ffffff801054b1b8 x24: 0000000000000000 
x23: ffffff8010c39c18 x22: ffffff80102bf2f0 
x21: 0000000000000000 x20: ffffff8010c08000 
x19: 0000000000000000 x18: ffffffffffffffff 
x17: 0000000000000000 x16: 0000000000000000 
x15: ffffff8010c08548 x14: ffffff8010c807f0 
x13: ffffff8010c80431 x12: ffffff8010c14000 
x11: ffffff801005bc60 x10: ffffff801005bc60 
x9 : 00000000ffffffc8 x8 : 7320737574617473 
x7 : 206b6c635f666572 x6 : ffffff8010c7fabc 
x5 : 0000000000000000 x4 : 0000000000000000 
x3 : 00000000ffffffff x2 : 00000040ecf69000 
x1 : 59b62fd98d8ce200 x0 : 0000000000000000 
Call trace:
 clk_branch_toggle+0x19c/0x1c0
 clk_branch2_disable+0x2c/0x40
 clk_disable_unused_subtree+0xe8/0x250
 clk_disable_unused_subtree+0x34/0x250
 clk_disable_unused_subtree+0x34/0x250
 clk_disable_unused+0x44/0x140
 do_one_initcall+0x68/0x250
 kernel_init_freeable+0x288/0x32c
 kernel_init+0x18/0x110
 ret_from_fork+0x10/0x1c
---[ end trace d1565111e6d9749a ]---