[RESEND,v2,0/2] Modularize RPMH driver

Message

Maulik Shah Oct. 5, 2020, 5:59 a.m. UTC

Resending the patches rebasing on top of latest linux-next (next-20201002)

Changes in v2:
- Update commit message in patch 1
- send [4] again instead of revert's revert in patch 2.

This series is to modularize RPMH driver

The tracepoint in RPMH driver was changed to _rcuidle variant based on the
test results of unmerged series [1] where .power_off callback from genpd
reported RCU warnings. 

The series which finally got merged [2] uses CPU PM notifications
and genpd .power_off callback is not implemented in RPMH driver to invoke
rpmh_flush(). The CPU PM notifications are done with RCU non idle in kernel
(see cpu_pm_notify() uses rcu_irq_enter_irqson() before notifications)

However using _rcuidle variant prevented RPMH driver to compile as module
since these _rcuidle are not exported symbols for tracepoints.

This seris reverts the change [3] to remove _rcuidle variant for tracepoint
as its no more valid test case (genpd .power_off is not implemented)
and bring backs the change [4] that was reverted due to _rcuidle preventing
to become modular.

[1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=243931
[2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=269733
[3] https://lore.kernel.org/r/[e-mail] 
[4] https://lore.kernel.org/r/[e-mail]

John Stultz (1):
  soc: qcom: rpmh: Allow RPMH driver to be loaded as a module

Maulik Shah (1):
  Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh"

 drivers/soc/qcom/Kconfig    | 2 +-
 drivers/soc/qcom/rpmh-rsc.c | 7 ++++++-
 2 files changed, 7 insertions(+), 2 deletions(-)

Comments

Maulik Shah Oct. 19, 2020, 7:26 a.m. UTC | #1

Hi Bjorn,

Can you please pick these changes.

Thanks,
Maulik

On 10/5/2020 11:29 AM, Maulik Shah wrote:
> Resending the patches rebasing on top of latest linux-next (next-20201002)
>
> Changes in v2:
> - Update commit message in patch 1
> - send [4] again instead of revert's revert in patch 2.
>
> This series is to modularize RPMH driver
>
> The tracepoint in RPMH driver was changed to _rcuidle variant based on the
> test results of unmerged series [1] where .power_off callback from genpd
> reported RCU warnings.
>
> The series which finally got merged [2] uses CPU PM notifications
> and genpd .power_off callback is not implemented in RPMH driver to invoke
> rpmh_flush(). The CPU PM notifications are done with RCU non idle in kernel
> (see cpu_pm_notify() uses rcu_irq_enter_irqson() before notifications)
>
> However using _rcuidle variant prevented RPMH driver to compile as module
> since these _rcuidle are not exported symbols for tracepoints.
>
> This seris reverts the change [3] to remove _rcuidle variant for tracepoint
> as its no more valid test case (genpd .power_off is not implemented)
> and bring backs the change [4] that was reverted due to _rcuidle preventing
> to become modular.
>
> [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=243931
> [2] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=269733
> [3] https://lore.kernel.org/r/[e-mail]
> [4] https://lore.kernel.org/r/[e-mail]
>
> John Stultz (1):
>    soc: qcom: rpmh: Allow RPMH driver to be loaded as a module
>
> Maulik Shah (1):
>    Revert "drivers: qcom: rpmh-rsc: Use rcuidle tracepoints for rpmh"
>
>   drivers/soc/qcom/Kconfig    | 2 +-
>   drivers/soc/qcom/rpmh-rsc.c | 7 ++++++-
>   2 files changed, 7 insertions(+), 2 deletions(-)
>