mbox series

[v3,0/7] drm/msm/dpu: Clean up dpu code

Message ID 20180924162228.180689-1-bzwang@chromium.org (mailing list archive)
Headers show
Series drm/msm/dpu: Clean up dpu code | expand

Message

Bruce Wang Sept. 24, 2018, 4:22 p.m. UTC 
Removes uneeded checks and unused variables. Changes some
function that do not need return values to void.

Bruce Wang (7):
  drm/msm/dpu: Remove unneeded checks in dpu_plane.c
  drm/msm/dpu: Clean up plane atomic disable/update
  drm/msm/dpu: Remove unneeded checks in dpu_crtc.c
  drm/msm/dpu: Change _dpu_crtc_power_enable to void
  drm/msm/dpu: Change _dpu_crtc_vblank_enable_no_lock to void
  drm/msm/dpu: Make dpu_plane_danger_signal_ctrl void
  drm/msm/dpu: Make _dpu_plane_get_aspace void

 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c  | 253 ++++---------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 280 +++-------------------
 2 files changed, 70 insertions(+), 463 deletions(-)

Comments

Sean Paul Sept. 28, 2018, 7:42 a.m. UTC | #1 
On Mon, Sep 24, 2018 at 12:22:21PM -0400, Bruce Wang wrote:
> Removes uneeded checks and unused variables. Changes some
> function that do not need return values to void.
> 
> Bruce Wang (7):
>   drm/msm/dpu: Remove unneeded checks in dpu_plane.c
>   drm/msm/dpu: Clean up plane atomic disable/update
>   drm/msm/dpu: Remove unneeded checks in dpu_crtc.c
>   drm/msm/dpu: Change _dpu_crtc_power_enable to void
>   drm/msm/dpu: Change _dpu_crtc_vblank_enable_no_lock to void
>   drm/msm/dpu: Make dpu_plane_danger_signal_ctrl void
>   drm/msm/dpu: Make _dpu_plane_get_aspace void


Applied to dpu-staging.

Congrats on your first patches!
                                   .''.       
       .''.      .        *''*    :_\/_:     . 
      :_\/_:   _\(/_  .:.*_\/_*   : /\ :  .'.:.'.
  .''.: /\ :   ./)\   ':'* /\ * :  '..'.  -=:o:=-
 :_\/_:'.:::.    ' *''*    * '.\'/.' _\(/_'.':'.'
 : /\ : :::::     *_\/_*     -= o =-  /)\    '  *
  '..'  ':::'     * /\ *     .'/.\'.   '
                   *..*         :

Sean


> 
>  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c  | 253 ++++---------------
>  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 280 +++-------------------
>  2 files changed, 70 insertions(+), 463 deletions(-)
> 
> -- 
> 2.19.0.444.g18242da7ef-goog
>
Bruce Wang Sept. 28, 2018, 8:41 p.m. UTC | #2 
On Fri, Sep 28, 2018 at 3:42 AM Sean Paul <sean@poorly.run> wrote:
>
> On Mon, Sep 24, 2018 at 12:22:21PM -0400, Bruce Wang wrote:
> > Removes uneeded checks and unused variables. Changes some
> > function that do not need return values to void.
> >
> > Bruce Wang (7):
> >   drm/msm/dpu: Remove unneeded checks in dpu_plane.c
> >   drm/msm/dpu: Clean up plane atomic disable/update
> >   drm/msm/dpu: Remove unneeded checks in dpu_crtc.c
> >   drm/msm/dpu: Change _dpu_crtc_power_enable to void
> >   drm/msm/dpu: Change _dpu_crtc_vblank_enable_no_lock to void
> >   drm/msm/dpu: Make dpu_plane_danger_signal_ctrl void
> >   drm/msm/dpu: Make _dpu_plane_get_aspace void
>
>
> Applied to dpu-staging.
>
> Congrats on your first patches!
>                                    .''.
>        .''.      .        *''*    :_\/_:     .
>       :_\/_:   _\(/_  .:.*_\/_*   : /\ :  .'.:.'.
>   .''.: /\ :   ./)\   ':'* /\ * :  '..'.  -=:o:=-
>  :_\/_:'.:::.    ' *''*    * '.\'/.' _\(/_'.':'.'
>  : /\ : :::::     *_\/_*     -= o =-  /)\    '  *
>   '..'  ':::'     * /\ *     .'/.\'.   '
>                    *..*         :
>
> Sean
>

Haha, I have no idea what that ascii art is supposed to be but thanks Sean!
Also, a big thank you to Jordan and Jeykumar as well for the comments
and reviews

Bruce

>
> >
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c  | 253 ++++---------------
> >  drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 280 +++-------------------
> >  2 files changed, 70 insertions(+), 463 deletions(-)
> >
> > --
> > 2.19.0.444.g18242da7ef-goog
> >
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS