| Message ID | 20180926235112.25710-1-masneyb@onstation.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | treewide: add vibrator support for various MSM SOCs | expand |
On Wed, Sep 26, 2018 at 07:51:09PM -0400, Brian Masney wrote: > This patch set adds support for the vibrator found on various Qualcomm > MSM SOCs. This is based on work from: > > Jonathan Marek from qcom,pwm-vibrator.c in the PostmarketOS repo: > https://gitlab.com/postmarketOS/linux-postmarketos/commit/7647fb36cb1cbd060f8b52087a68ab93583292b5 > > Jongrak Kwon and Devin Kim from msm_pwm_vibrator.c in the downstream > Android 3.4.0 sources: > https://android.googlesource.com/kernel/msm/+/android-msm-lenok-3.10-lollipop-wear-release/drivers/misc/msm_pwm_vibrator.c > > Driver was tested on a LG Nexus 5 (hammerhead) phone using rumble-test: > https://git.collabora.com/cgit/user/sre/rumble-test.git/plain/rumble-test.c Looking at all of this it seems like this would be more appropriately implemented as a force-feedback input device directly. The only reason you seem to be making this a PWM driver is so that it can be used in conjunction with pwm-vibrator. The device itself doesn't seem to be a generic PWM in the way that the PWM framework expects it. Thierry
Quoting Brian Masney (2018-09-26 16:51:09) > This patch set adds support for the vibrator found on various Qualcomm > MSM SOCs. This is based on work from: Can you please stop adding 'treewide:' to your cover letters? It is very confusing while reading over subject summaries to see something that isn't actually treewide end up being qcom specific.
This patch set adds support for the vibrator found on various Qualcomm MSM SOCs. This is based on work from: Jonathan Marek from qcom,pwm-vibrator.c in the PostmarketOS repo: https://gitlab.com/postmarketOS/linux-postmarketos/commit/7647fb36cb1cbd060f8b52087a68ab93583292b5 Jongrak Kwon and Devin Kim from msm_pwm_vibrator.c in the downstream Android 3.4.0 sources: https://android.googlesource.com/kernel/msm/+/android-msm-lenok-3.10-lollipop-wear-release/drivers/misc/msm_pwm_vibrator.c Driver was tested on a LG Nexus 5 (hammerhead) phone using rumble-test: https://git.collabora.com/cgit/user/sre/rumble-test.git/plain/rumble-test.c Changes since v1 - Update device tree binding document based on feedback from Rob Herring. - Changed the driver description to: Qualcomm PWM driver for the MSM vibrator. Brian Masney (3): dt-bindings: pwm: msm-vibrator: new bindings for MSM vibrator PWM pwm: msm-vibrator: new driver for the vibrator found on various MSM SOCs ARM: dts: qcom: msm8974-hammerhead: add device tree bindings for vibrator .../bindings/pwm/pwm-msm-vibrator.txt | 38 +++ .../qcom-msm8974-lge-nexus5-hammerhead.dts | 39 +++ drivers/pwm/Kconfig | 9 + drivers/pwm/Makefile | 1 + drivers/pwm/pwm-msm-vibrator.c | 227 ++++++++++++++++++ 5 files changed, 314 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/pwm-msm-vibrator.txt create mode 100644 drivers/pwm/pwm-msm-vibrator.c