[v2,00/24] drm/msm: Various dpu locking and legacy cleanups

Message

Sean Paul Nov. 16, 2018, 6:42 p.m. UTC

From: Sean Paul <[e-mail]>

This was originally 3 patchsets, but none have gotten full review, so I
figured I'd package the v2's all up into one set so it's easier to track.

Set 1- https://lists.freedesktop.org/archives/dri-devel/2018-November/196170.html
Set 2- https://lists.freedesktop.org/archives/dri-devel/2018-November/196184.html
Set 3- https://lists.freedesktop.org/archives/dri-devel/2018-November/196276.html

Thanks,
Sean


Sean Paul (24):
  drm/msm: dpu: Remove dpu_power_handle_get_dbus_name()
  drm/msm: dpu: Remove unused trace_dpu_perf_update_bus()
  drm/msm: dpu: Remove dpu_power_client
  drm/msm: dpu: Don't use power_event for vbif_init_memtypes
  drm/msm: dpu: Handle crtc pm_runtime_resume() directly
  drm/msm: dpu: Remove power_handle from core_perf
  drm/msm: dpu: Include dpu_io_util.h directly in dpu_kms.h
  drm/msm: dpu: Move DPU_POWER_HANDLE_DBUS_ID to core_perf
  drm/msm: dpu: Remove dpu_power_handle
  drm/msm: dpu: Fix typo in dpu_encoder
  drm/msm: dpu: Add ->enabled to dpu_encoder_virt
  drm/msm: dpu: Move crtc runtime resume to encoder
  drm/msm: dpu: Don't drop locks in crtc_vblank_enable
  drm/msm: dpu: Grab the modeset locks in frame_event
  drm/msm: dpu: Stop using encoder->crtc pointer
  drm/msm: dpu: Add modeset lock checks where applicable
  drm/msm: dpu: Move pm_runtime_(get|put) from vblank_enable
  drm/msm: dpu: Remove crtc_lock from setup_mixers
  drm/msm: dpu: Remove vblank_callback from encoder
  drm/msm: dpu: Use atomic_disable for dpu_crtc_disable
  drm/msm: dpu: Don't bother checking ->enabled in dpu_crtc_vblank
  drm/msm: dpu: Separate crtc assignment from vblank enable
  drm/msm: dpu: Remove vblank_requested flag from dpu_crtc
  drm/msm: dpu: Remove crtc_lock

 drivers/gpu/drm/msm/Makefile                  |   1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c |  37 ++-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h |  22 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c      | 216 +++++-----------
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h      |  15 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   |  97 ++++---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h   |  24 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |  76 ++----
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h       |   6 +-
 .../gpu/drm/msm/disp/dpu1/dpu_power_handle.c  | 240 ------------------
 .../gpu/drm/msm/disp/dpu1/dpu_power_handle.h  | 217 ----------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h     |  43 +---
 12 files changed, 204 insertions(+), 790 deletions(-)
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h

Comments

Sean Paul Dec. 4, 2018, 3:15 p.m. UTC | #1

On Fri, Nov 16, 2018 at 01:42:10PM -0500, Sean Paul wrote:
> From: Sean Paul <[e-mail]>
> 
> This was originally 3 patchsets, but none have gotten full review, so I
> figured I'd package the v2's all up into one set so it's easier to track.
> 
> Set 1- https://lists.freedesktop.org/archives/dri-devel/2018-November/196170.html
> Set 2- https://lists.freedesktop.org/archives/dri-devel/2018-November/196184.html
> Set 3- https://lists.freedesktop.org/archives/dri-devel/2018-November/196276.html
> 
Thanks for the reviews, I've pushed it to dpu-staging/for-next

Sean

> Thanks,
> Sean
> 
> 
> Sean Paul (24):
>   drm/msm: dpu: Remove dpu_power_handle_get_dbus_name()
>   drm/msm: dpu: Remove unused trace_dpu_perf_update_bus()
>   drm/msm: dpu: Remove dpu_power_client
>   drm/msm: dpu: Don't use power_event for vbif_init_memtypes
>   drm/msm: dpu: Handle crtc pm_runtime_resume() directly
>   drm/msm: dpu: Remove power_handle from core_perf
>   drm/msm: dpu: Include dpu_io_util.h directly in dpu_kms.h
>   drm/msm: dpu: Move DPU_POWER_HANDLE_DBUS_ID to core_perf
>   drm/msm: dpu: Remove dpu_power_handle
>   drm/msm: dpu: Fix typo in dpu_encoder
>   drm/msm: dpu: Add ->enabled to dpu_encoder_virt
>   drm/msm: dpu: Move crtc runtime resume to encoder
>   drm/msm: dpu: Don't drop locks in crtc_vblank_enable
>   drm/msm: dpu: Grab the modeset locks in frame_event
>   drm/msm: dpu: Stop using encoder->crtc pointer
>   drm/msm: dpu: Add modeset lock checks where applicable
>   drm/msm: dpu: Move pm_runtime_(get|put) from vblank_enable
>   drm/msm: dpu: Remove crtc_lock from setup_mixers
>   drm/msm: dpu: Remove vblank_callback from encoder
>   drm/msm: dpu: Use atomic_disable for dpu_crtc_disable
>   drm/msm: dpu: Don't bother checking ->enabled in dpu_crtc_vblank
>   drm/msm: dpu: Separate crtc assignment from vblank enable
>   drm/msm: dpu: Remove vblank_requested flag from dpu_crtc
>   drm/msm: dpu: Remove crtc_lock
> 
>  drivers/gpu/drm/msm/Makefile                  |   1 -
>  drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c |  37 ++-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h |  22 +-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c      | 216 +++++-----------
>  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h      |  15 +-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   |  97 ++++---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h   |  24 +-
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |  76 ++----
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h       |   6 +-
>  .../gpu/drm/msm/disp/dpu1/dpu_power_handle.c  | 240 ------------------
>  .../gpu/drm/msm/disp/dpu1/dpu_power_handle.h  | 217 ----------------
>  drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h     |  43 +---
>  12 files changed, 204 insertions(+), 790 deletions(-)
>  delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c
>  delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h
> 
> -- 
> Sean Paul, Software Engineer, Google / Chromium OS
>