mbox series

[0/3] regulator: max77826: Add MAX77826 support

Message ID 20200413164440.1138178-1-iskren.chernev@gmail.com (mailing list archive)
Headers show
Series regulator: max77826: Add MAX77826 support | expand

Message

Iskren Chernev April 13, 2020, 4:44 p.m. UTC 
The MAX77826 is a PMIC found on the Samsung Galaxy S5 (klte) and possibly other
devices. It is produced by Maxim Integrated and contains 15 LDOs a buck and
a buck boost regulator.

Iskren Chernev (3):
  regulator: max77826: Add max77826 regulator driver
  dt-bindings: regulator: Add document bindings for max77826
  ARM: dts: qcom: msm8974-klte: Add max77826 pmic node

 .../bindings/regulator/maxim,max77826.yaml    |  70 ++++
 .../boot/dts/qcom-msm8974-samsung-klte.dts    | 110 +++++++
 arch/arm/boot/dts/qcom-msm8974.dtsi           |  11 +
 drivers/regulator/Kconfig                     |  10 +
 drivers/regulator/Makefile                    |   1 +
 drivers/regulator/max77826-regulator.c        | 301 ++++++++++++++++++
 6 files changed, 503 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/maxim,max77826.yaml
 create mode 100644 drivers/regulator/max77826-regulator.c


base-commit: 3b2804993d1e9f2b01f4264993009d3e48722e0d
--
2.26.0

Comments

Mark Brown April 14, 2020, 10:57 a.m. UTC | #1 
On Mon, Apr 13, 2020 at 07:44:37PM +0300, Iskren Chernev wrote:
> The MAX77826 is a PMIC found on the Samsung Galaxy S5 (klte) and possibly other
> devices. It is produced by Maxim Integrated and contains 15 LDOs a buck and
> a buck boost regulator.
> 
> Iskren Chernev (3):
>   regulator: max77826: Add max77826 regulator driver
>   dt-bindings: regulator: Add document bindings for max77826

Aside from the compatible string and the subject prefix on the DT
binding patch this looks good to me.
Iskren Chernev April 14, 2020, 1:14 p.m. UTC | #2 
On 4/14/20 1:57 PM, Mark Brown wrote:
> On Mon, Apr 13, 2020 at 07:44:37PM +0300, Iskren Chernev wrote:
>> The MAX77826 is a PMIC found on the Samsung Galaxy S5 (klte) and possibly other
>> devices. It is produced by Maxim Integrated and contains 15 LDOs a buck and
>> a buck boost regulator.
>>
>> Iskren Chernev (3):
>>   regulator: max77826: Add max77826 regulator driver
>>   dt-bindings: regulator: Add document bindings for max77826
>
> Aside from the compatible string and the subject prefix on the DT
> binding patch this looks good to me.

About the subject -- I guess you mean the suffix is wrong, it should be:

  dt-bindings: regulator: Document bindings for max77826

I'll also change the compatible string.
Mark Brown April 14, 2020, 2:53 p.m. UTC | #3 
On Tue, Apr 14, 2020 at 04:14:01PM +0300, Iskren Chernev wrote:

> > Aside from the compatible string and the subject prefix on the DT
> > binding patch this looks good to me.

> About the subject -- I guess you mean the suffix is wrong, it should be:

>   dt-bindings: regulator: Document bindings for max77826

No, it should just be regulator:.