[0/2] drm/msm/a6xx: add A640/A650 hwcg

Message

Jonathan Marek June 29, 2020, 11:49 p.m. UTC

Initialize hardware clock-gating registers on A640 and A650 GPUs.

I put the hwcg tables in adreno_device.c, but maybe it makes more
sense to keep them in a6xx_gpu.c? (this would allow switching a5xx
to use the gpulist too.. it isn't possible to include both a6xx.xml.h
and a5xx.xml.h in adreno_device.c)

Jonathan Marek (2):
  drm/msm/a6xx: hwcg tables in gpulist
  drm/msm/a6xx: add A640/A650 hwcg

 drivers/gpu/drm/msm/adreno/a6xx.xml.h      |   8 +
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c      | 140 ++-----------
 drivers/gpu/drm/msm/adreno/adreno_device.c | 219 +++++++++++++++++++++
 drivers/gpu/drm/msm/adreno/adreno_gpu.h    |   7 +
 4 files changed, 251 insertions(+), 123 deletions(-)

Comments

Rob Clark June 30, 2020, 3:36 a.m. UTC | #1

On Mon, Jun 29, 2020 at 4:49 PM Jonathan Marek <[e-mail]> wrote:
>
> Initialize hardware clock-gating registers on A640 and A650 GPUs.
>
> I put the hwcg tables in adreno_device.c, but maybe it makes more
> sense to keep them in a6xx_gpu.c? (this would allow switching a5xx
> to use the gpulist too.. it isn't possible to include both a6xx.xml.h
> and a5xx.xml.h in adreno_device.c)


yeah, I've kinda tried to avoid "crossing the streams".. maybe these
should move to adreno_gpu

BR,
-R

>
> Jonathan Marek (2):
>   drm/msm/a6xx: hwcg tables in gpulist
>   drm/msm/a6xx: add A640/A650 hwcg
>
>  drivers/gpu/drm/msm/adreno/a6xx.xml.h      |   8 +
>  drivers/gpu/drm/msm/adreno/a6xx_gpu.c      | 140 ++-----------
>  drivers/gpu/drm/msm/adreno/adreno_device.c | 219 +++++++++++++++++++++
>  drivers/gpu/drm/msm/adreno/adreno_gpu.h    |   7 +
>  4 files changed, 251 insertions(+), 123 deletions(-)
>
> --
> 2.26.1
>