From patchwork Sun Jul 19 08:07:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Ravnborg X-Patchwork-Id: 11672231 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0375360D for ; Sun, 19 Jul 2020 08:08:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD2BA20809 for ; Sun, 19 Jul 2020 08:08:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z8trr1tl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725988AbgGSIIF (ORCPT ); Sun, 19 Jul 2020 04:08:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgGSIIE (ORCPT ); Sun, 19 Jul 2020 04:08:04 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73191C0619D2; Sun, 19 Jul 2020 01:08:04 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id q4so17105642lji.2; Sun, 19 Jul 2020 01:08:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WnI5F454pMZI6Esv1LgL7L2JfitladHB6StSSThkZNI=; b=Z8trr1tlrNcJmz4HoHn9adB6bJd9M8zYoGrkDc30++eOz0f2ld8VLs5yNrPJIbb81g 1xwki8GLp9mJgEF0hjQV0vtGhhwvWEU1N6b3joW7Y9LIH45UivASrZF6ftTsDcCeXBwe DFwjsNTkosOE7b0pTrBgseXg63DMFglYbA3ARM9I/ifBX+IqERM9QadZ4MKuuzNck328 12McziDSW3iV3MPkHiXjXNP+pwNFi4qsy+X1jans3WgUqnb4H70H7qtKDmXy9VXvUJ/b TLrOXN6eH8zbcO4WHtbkT+UFXi7Gp9oxCcX284hwWKNPJ0kgjxOvDmfj2Z+rKZpsWqFQ AprA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=WnI5F454pMZI6Esv1LgL7L2JfitladHB6StSSThkZNI=; b=ZU3cf6viHkk0CFFumNgIH79r/MCfQ7lxuOKwpQ7ffEPHvGYFTWwhu5JLx/b1yFAzF6 XNsG3N79Fx3Pe/4EykHPhaXevQ9KRpMmlONCBz00EIxRKvRIl3YBi1wF/naNB6vfRkou y0cpRi9cILrmEb3ArDmel7Q3825h0oJqlExjDvu8uss3Kb8kGrd7efyUXGPAx/VuHtu4 AQyLTCrwS9ek96TXKoUvhClh8o+bCdE9sHi4o7n5HtAbQmsYlSsFVyCijvNZ43U0dxY7 yh+BtrK6aWVTo0K5oE3UNDCp28w18AYskAPjuNd5D2TLIxAIxaubF3iLgYzRHSpgE9J5 RQWg== X-Gm-Message-State: AOAM5318Z+Y763NjScaCONMqWVpl/o3/uUwd11wNyfJ9IDrNR20Ixr4G NerNSj1JM9TuYg8qOWTuYAY= X-Google-Smtp-Source: ABdhPJwlmppqA7BV4OvP0HV49A8Pja1NU+jaBZTZwubftCwEK6zwc1GhTyRydeLODV0nED3CA5IPTQ== X-Received: by 2002:a2e:b8d4:: with SMTP id s20mr8011885ljp.177.1595146082636; Sun, 19 Jul 2020 01:08:02 -0700 (PDT) Received: from saturn.lan ([2a00:fd00:805f:db00:d5fe:fe9c:fc06:b74c]) by smtp.gmail.com with ESMTPSA id 72sm732407lfh.97.2020.07.19.01.08.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2020 01:08:02 -0700 (PDT) From: Sam Ravnborg To: dri-devel@lists.freedesktop.org, Jingoo Han , Lee Jones , Daniel Thompson Cc: Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Emil Velikov , Jonathan Corbet , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe Kleine-Konig , Peter Ujfalusi , Tomi Valkeinen , Sam Ravnborg Subject: [PATCH v5 0/19] backlight: backlight updates Date: Sun, 19 Jul 2020 10:07:24 +0200 Message-Id: <20200719080743.8560-1-sam@ravnborg.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi all. Follow-up on v4 - with only a few changes listed below and in the individual patches. Thanks for all the reviews and the feedback on the patches! I am planning a follow-up on this patchset to update the backlight drivers all over to use backlight_get_brightness() and backlight_is_blank() as appropriate. v5: - Added r-b's - Updated cr_bllcd to use gpio-backlight semantics - Various editorial updates to changelogs - Rebased on top of Lee's backlight tree - Dropped "make of_find_backlight_by_node() static" The change depends on drm-misc-next. Will be re-send when the changes hits the backlight tree (We could have done this in other ways, but it is easier to just wait) v4: - Introduced backlight_get_brightness based on feedback from Emil. - Properly described the rationale behind more restrictive locking use I checked that locking was not used outside backlight core by renaming the lock fields. As it is not used seems OK to restrict use to the core. - Introducing backlight_get_brightness invalidated some patches and I did a bit finer split to ease review. - Added acks - A few small adjustments documented in the individual patches v3: - Dropped video patch that was reviewd and thus applied - Updated kernel-doc so all fields now have a short intro - Improved readability in a lot of places, thanks to review feedback from Daniel - thanks! - Added better intro to backlight - Added acks Several other smaller changes documented in the patches. I left out patches to make functions static as there are dependencies to drm-misc-next for these. v2: - Dropped drm patches that was reviewed and thus applied (Thanks Tomi) - Updated backligth_is_blank() based on Daniel's feedback - Dropped EXPORT_SYMBOL that was no longer relevant - Reordered patches, so patches with no external dependencies comes first - Updated the description that follows. The following series touches a lot of backlight things. Starts with a small refactoring in backligth.c to remove some indents. This increases the readability and no functional changes. Then two new helpers backlight_is_blank(), backlight_get_brightness() are added. These helpers simplifies the implementation of update_status() in the backlight drivers where they are used. Then while surfing the code I missed some documentation. So I got a bit carried away and updated the documentation for the backlight core and added it to kernel-doc. The documentation express my current understanding. Everything from spelling errors to outright wrong content shall be anticipated - so please review! We are all best helped if the documentation is correct and up-to-date and it is readable. In this process I identified that the backlight_bl driver was no longer in use - so drop it. Everything builds, but so far no run-time testing. Sam Sam Ravnborg (19): backlight: refactor fb_notifier_callback() backlight: add backlight_is_blank() backlight: improve backlight_ops documentation backlight: improve backlight_properties documentation backlight: improve backlight_device documentation backlight: document inline functions in backlight.h backlight: document enums in backlight.h backlight: remove the unused backlight_bl driver backlight: drop extern from prototypes backlight: add overview and update existing doc backlight: wire up kernel-doc documentation backlight: introduce backlight_get_brightness() backlight: as3711_bl: simplify update_status backlight: cr_bllcd: introduce gpio-backlight semantics backlight: gpio_backlight: simplify update_status() backlight: jornada720_bl: introduce backlight_is_blank() backlight: use backlight_get_brightness() backlight: drop backlight_put() backlight: make of_find_backlight static Documentation/gpu/backlight.rst | 12 + Documentation/gpu/index.rst | 1 + drivers/video/backlight/88pm860x_bl.c | 13 +- drivers/video/backlight/Kconfig | 8 - drivers/video/backlight/Makefile | 1 - drivers/video/backlight/adp5520_bl.c | 10 +- drivers/video/backlight/adp8860_bl.c | 10 +- drivers/video/backlight/adp8870_bl.c | 10 +- drivers/video/backlight/as3711_bl.c | 11 +- drivers/video/backlight/backlight.c | 208 +++++++++------- drivers/video/backlight/bd6107.c | 7 +- drivers/video/backlight/corgi_lcd.c | 8 +- drivers/video/backlight/cr_bllcd.c | 25 +- drivers/video/backlight/da903x_bl.c | 13 +- drivers/video/backlight/ep93xx_bl.c | 8 +- drivers/video/backlight/generic_bl.c | 110 --------- drivers/video/backlight/gpio_backlight.c | 17 +- drivers/video/backlight/hp680_bl.c | 6 +- drivers/video/backlight/jornada720_bl.c | 2 +- drivers/video/backlight/kb3886_bl.c | 6 +- drivers/video/backlight/led_bl.c | 7 +- drivers/video/backlight/lm3533_bl.c | 8 +- drivers/video/backlight/locomolcd.c | 6 +- drivers/video/backlight/lv5207lp.c | 7 +- drivers/video/backlight/max8925_bl.c | 13 +- drivers/video/backlight/pwm_bl.c | 7 +- drivers/video/backlight/qcom-wled.c | 7 +- drivers/video/backlight/tps65217_bl.c | 10 +- drivers/video/backlight/wm831x_bl.c | 13 +- include/linux/backlight.h | 399 +++++++++++++++++++++++++------ 30 files changed, 497 insertions(+), 466 deletions(-)