Message ID | 20200827211658.27479-1-tanmay@codeaurora.org (mailing list archive) |
---|---|
Headers | show |
Series | Add support for DisplayPort driver on SnapDragon | expand |
Fyi, I've pushed this series and the dp-compliance bits to msm-next-dp[1] I didn't include the dp audio series yet, which seems to need some minor rebasing. (And a small request, when resending, cc freedreno@lists.freedesktop.org, so it shows up in the patchwork instance[2] I use) You might want to double check that I got the correct versions of the series, etc. And that nothing else (other than audio) is missing. BR, -R [1] https://gitlab.freedesktop.org/drm/msm/-/commits/msm-next-dp [2] https://patchwork.freedesktop.org/project/freedreno On Thu, Aug 27, 2020 at 2:17 PM Tanmay Shah <tanmay@codeaurora.org> wrote: > > These patches add Display-Port driver on SnapDragon/msm hardware. > This series also contains device-tree bindings for msm DP driver. > It also contains Makefile and Kconfig changes to compile msm DP driver. > > The block diagram of DP driver is shown below: > > > +-------------+ > |DRM FRAMEWORK| > +------+------+ > | > +----v----+ > | DP DRM | > +----+----+ > | > +----v----+ > +------------+| DP +----------++------+ > + +---+| DISPLAY |+---+ | | > | + +-+-----+-+ | | | > | | | | | | | > | | | | | | | > | | | | | | | > v v v v v v v > +------+ +------+ +---+ +----+ +----+ +---+ +-----+ > | DP | | DP | |DP | | DP | | DP | |DP | | DP | > |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| > +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ > | | | > +--v---+ +v-----v+ > |DEVICE| | DP | > | TREE | |CATALOG| > +------+ +---+---+ > | > +---v----+ > |CTRL/PHY| > | HW | > +--------+ > > Changes in v12: > > -- Add support of pm ops in display port driver > -- Clear bpp depth bits before writing to MISC register > -- Fix edid read > > Previous change log: > https://lkml.kernel.org/lkml/20200818051137.21478-1-tanmay@codeaurora.org/ > > Chandan Uddaraju (4): > dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon > drm: add constant N value in helper file > drm/msm/dp: add displayPort driver support > drm/msm/dp: add support for DP PLL driver > > Jeykumar Sankaran (1): > drm/msm/dpu: add display port support in DPU > > Tanmay Shah (1): > drm/msm/dp: Add Display Port HPD feature > > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > drivers/gpu/drm/msm/Kconfig | 9 + > drivers/gpu/drm/msm/Makefile | 14 + > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 27 +- > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 83 +- > drivers/gpu/drm/msm/dp/dp_aux.c | 535 ++++++ > drivers/gpu/drm/msm/dp/dp_aux.h | 30 + > drivers/gpu/drm/msm/dp/dp_catalog.c | 1045 ++++++++++ > drivers/gpu/drm/msm/dp/dp_catalog.h | 105 + > drivers/gpu/drm/msm/dp/dp_ctrl.c | 1693 +++++++++++++++++ > drivers/gpu/drm/msm/dp/dp_ctrl.h | 35 + > drivers/gpu/drm/msm/dp/dp_display.c | 1046 ++++++++++ > drivers/gpu/drm/msm/dp/dp_display.h | 31 + > drivers/gpu/drm/msm/dp/dp_drm.c | 168 ++ > drivers/gpu/drm/msm/dp/dp_drm.h | 18 + > drivers/gpu/drm/msm/dp/dp_hpd.c | 69 + > drivers/gpu/drm/msm/dp/dp_hpd.h | 79 + > drivers/gpu/drm/msm/dp/dp_link.c | 1214 ++++++++++++ > drivers/gpu/drm/msm/dp/dp_link.h | 132 ++ > drivers/gpu/drm/msm/dp/dp_panel.c | 486 +++++ > drivers/gpu/drm/msm/dp/dp_panel.h | 95 + > drivers/gpu/drm/msm/dp/dp_parser.c | 267 +++ > drivers/gpu/drm/msm/dp/dp_parser.h | 138 ++ > drivers/gpu/drm/msm/dp/dp_pll.c | 99 + > drivers/gpu/drm/msm/dp/dp_pll.h | 61 + > drivers/gpu/drm/msm/dp/dp_pll_10nm.c | 930 +++++++++ > drivers/gpu/drm/msm/dp/dp_pll_private.h | 89 + > drivers/gpu/drm/msm/dp/dp_power.c | 373 ++++ > drivers/gpu/drm/msm/dp/dp_power.h | 103 + > drivers/gpu/drm/msm/dp/dp_reg.h | 518 +++++ > drivers/gpu/drm/msm/msm_drv.c | 2 + > drivers/gpu/drm/msm/msm_drv.h | 59 +- > include/drm/drm_dp_helper.h | 1 + > 34 files changed, 9545 insertions(+), 19 deletions(-) > create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_10nm.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_private.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c > create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h > create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h > > > base-commit: d012a7190fc1fd72ed48911e77ca97ba4521bccd > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
Thanks Rob for pushing the changes. I confirm that the versions which you have pushed are the latest ones. I have rebased audio changes on top of the latest DP changes and posted them here https://patchwork.freedesktop.org/series/81612/. The other DP change which is missing is the video pattern CTS change https://patchwork.freedesktop.org/series/81614/ which also I have now rebased on top of the latest DP patch series and posted. Thanks Abhinav On 2020-09-12 11:25, Rob Clark wrote: > Fyi, I've pushed this series and the dp-compliance bits to > msm-next-dp[1] > > I didn't include the dp audio series yet, which seems to need some > minor rebasing. (And a small request, when resending, cc > freedreno@lists.freedesktop.org, so it shows up in the patchwork > instance[2] I use) > > You might want to double check that I got the correct versions of the > series, etc. And that nothing else (other than audio) is missing. > > BR, > -R > > [1] https://gitlab.freedesktop.org/drm/msm/-/commits/msm-next-dp > [2] https://patchwork.freedesktop.org/project/freedreno > > On Thu, Aug 27, 2020 at 2:17 PM Tanmay Shah <tanmay@codeaurora.org> > wrote: >> >> These patches add Display-Port driver on SnapDragon/msm hardware. >> This series also contains device-tree bindings for msm DP driver. >> It also contains Makefile and Kconfig changes to compile msm DP >> driver. >> >> The block diagram of DP driver is shown below: >> >> >> +-------------+ >> |DRM FRAMEWORK| >> +------+------+ >> | >> +----v----+ >> | DP DRM | >> +----+----+ >> | >> +----v----+ >> +------------+| DP +----------++------+ >> + +---+| DISPLAY |+---+ | | >> | + +-+-----+-+ | | | >> | | | | | | | >> | | | | | | | >> | | | | | | | >> v v v v v v v >> +------+ +------+ +---+ +----+ +----+ +---+ +-----+ >> | DP | | DP | |DP | | DP | | DP | |DP | | DP | >> |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| >> +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ >> | | | >> +--v---+ +v-----v+ >> |DEVICE| | DP | >> | TREE | |CATALOG| >> +------+ +---+---+ >> | >> +---v----+ >> |CTRL/PHY| >> | HW | >> +--------+ >> >> Changes in v12: >> >> -- Add support of pm ops in display port driver >> -- Clear bpp depth bits before writing to MISC register >> -- Fix edid read >> >> Previous change log: >> https://lkml.kernel.org/lkml/20200818051137.21478-1-tanmay@codeaurora.org/ >> >> Chandan Uddaraju (4): >> dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon >> drm: add constant N value in helper file >> drm/msm/dp: add displayPort driver support >> drm/msm/dp: add support for DP PLL driver >> >> Jeykumar Sankaran (1): >> drm/msm/dpu: add display port support in DPU >> >> Tanmay Shah (1): >> drm/msm/dp: Add Display Port HPD feature >> >> drivers/gpu/drm/i915/display/intel_display.c | 2 +- >> drivers/gpu/drm/msm/Kconfig | 9 + >> drivers/gpu/drm/msm/Makefile | 14 + >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 27 +- >> .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 + >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 83 +- >> drivers/gpu/drm/msm/dp/dp_aux.c | 535 ++++++ >> drivers/gpu/drm/msm/dp/dp_aux.h | 30 + >> drivers/gpu/drm/msm/dp/dp_catalog.c | 1045 ++++++++++ >> drivers/gpu/drm/msm/dp/dp_catalog.h | 105 + >> drivers/gpu/drm/msm/dp/dp_ctrl.c | 1693 >> +++++++++++++++++ >> drivers/gpu/drm/msm/dp/dp_ctrl.h | 35 + >> drivers/gpu/drm/msm/dp/dp_display.c | 1046 ++++++++++ >> drivers/gpu/drm/msm/dp/dp_display.h | 31 + >> drivers/gpu/drm/msm/dp/dp_drm.c | 168 ++ >> drivers/gpu/drm/msm/dp/dp_drm.h | 18 + >> drivers/gpu/drm/msm/dp/dp_hpd.c | 69 + >> drivers/gpu/drm/msm/dp/dp_hpd.h | 79 + >> drivers/gpu/drm/msm/dp/dp_link.c | 1214 ++++++++++++ >> drivers/gpu/drm/msm/dp/dp_link.h | 132 ++ >> drivers/gpu/drm/msm/dp/dp_panel.c | 486 +++++ >> drivers/gpu/drm/msm/dp/dp_panel.h | 95 + >> drivers/gpu/drm/msm/dp/dp_parser.c | 267 +++ >> drivers/gpu/drm/msm/dp/dp_parser.h | 138 ++ >> drivers/gpu/drm/msm/dp/dp_pll.c | 99 + >> drivers/gpu/drm/msm/dp/dp_pll.h | 61 + >> drivers/gpu/drm/msm/dp/dp_pll_10nm.c | 930 +++++++++ >> drivers/gpu/drm/msm/dp/dp_pll_private.h | 89 + >> drivers/gpu/drm/msm/dp/dp_power.c | 373 ++++ >> drivers/gpu/drm/msm/dp/dp_power.h | 103 + >> drivers/gpu/drm/msm/dp/dp_reg.h | 518 +++++ >> drivers/gpu/drm/msm/msm_drv.c | 2 + >> drivers/gpu/drm/msm/msm_drv.h | 59 +- >> include/drm/drm_dp_helper.h | 1 + >> 34 files changed, 9545 insertions(+), 19 deletions(-) >> create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_10nm.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_private.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h >> >> >> base-commit: d012a7190fc1fd72ed48911e77ca97ba4521bccd >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project >>
On 2020-09-12 11:25, Rob Clark wrote: > Fyi, I've pushed this series and the dp-compliance bits to > msm-next-dp[1] > > I didn't include the dp audio series yet, which seems to need some > minor rebasing. (And a small request, when resending, cc > freedreno@lists.freedesktop.org, so it shows up in the patchwork > instance[2] I use) > > You might want to double check that I got the correct versions of the > series, etc. And that nothing else (other than audio) is missing. > Thanks Rob for pulling changes in msm-next-dp branch. I confirm that changes you pointed above are latest changes and nothing else is missing in driver. Sure, we will make sure to send changes in freedreno list as well. Thanks. > BR, > -R > > [1] https://gitlab.freedesktop.org/drm/msm/-/commits/msm-next-dp > [2] https://patchwork.freedesktop.org/project/freedreno > > On Thu, Aug 27, 2020 at 2:17 PM Tanmay Shah <tanmay@codeaurora.org> > wrote: >> >> These patches add Display-Port driver on SnapDragon/msm hardware. >> This series also contains device-tree bindings for msm DP driver. >> It also contains Makefile and Kconfig changes to compile msm DP >> driver. >> >> The block diagram of DP driver is shown below: >> >> >> +-------------+ >> |DRM FRAMEWORK| >> +------+------+ >> | >> +----v----+ >> | DP DRM | >> +----+----+ >> | >> +----v----+ >> +------------+| DP +----------++------+ >> + +---+| DISPLAY |+---+ | | >> | + +-+-----+-+ | | | >> | | | | | | | >> | | | | | | | >> | | | | | | | >> v v v v v v v >> +------+ +------+ +---+ +----+ +----+ +---+ +-----+ >> | DP | | DP | |DP | | DP | | DP | |DP | | DP | >> |PARSER| | HPD | |AUX| |LINK| |CTRL| |PHY| |POWER| >> +--+---+ +---+--+ +---+ +----+ +--+-+ +-+-+ +-----+ >> | | | >> +--v---+ +v-----v+ >> |DEVICE| | DP | >> | TREE | |CATALOG| >> +------+ +---+---+ >> | >> +---v----+ >> |CTRL/PHY| >> | HW | >> +--------+ >> >> Changes in v12: >> >> -- Add support of pm ops in display port driver >> -- Clear bpp depth bits before writing to MISC register >> -- Fix edid read >> >> Previous change log: >> https://lkml.kernel.org/lkml/20200818051137.21478-1-tanmay@codeaurora.org/ >> >> Chandan Uddaraju (4): >> dt-bindings: msm/dp: add bindings of DP/DP-PLL driver for Snapdragon >> drm: add constant N value in helper file >> drm/msm/dp: add displayPort driver support >> drm/msm/dp: add support for DP PLL driver >> >> Jeykumar Sankaran (1): >> drm/msm/dpu: add display port support in DPU >> >> Tanmay Shah (1): >> drm/msm/dp: Add Display Port HPD feature >> >> drivers/gpu/drm/i915/display/intel_display.c | 2 +- >> drivers/gpu/drm/msm/Kconfig | 9 + >> drivers/gpu/drm/msm/Makefile | 14 + >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 27 +- >> .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 8 + >> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 83 +- >> drivers/gpu/drm/msm/dp/dp_aux.c | 535 ++++++ >> drivers/gpu/drm/msm/dp/dp_aux.h | 30 + >> drivers/gpu/drm/msm/dp/dp_catalog.c | 1045 ++++++++++ >> drivers/gpu/drm/msm/dp/dp_catalog.h | 105 + >> drivers/gpu/drm/msm/dp/dp_ctrl.c | 1693 >> +++++++++++++++++ >> drivers/gpu/drm/msm/dp/dp_ctrl.h | 35 + >> drivers/gpu/drm/msm/dp/dp_display.c | 1046 ++++++++++ >> drivers/gpu/drm/msm/dp/dp_display.h | 31 + >> drivers/gpu/drm/msm/dp/dp_drm.c | 168 ++ >> drivers/gpu/drm/msm/dp/dp_drm.h | 18 + >> drivers/gpu/drm/msm/dp/dp_hpd.c | 69 + >> drivers/gpu/drm/msm/dp/dp_hpd.h | 79 + >> drivers/gpu/drm/msm/dp/dp_link.c | 1214 ++++++++++++ >> drivers/gpu/drm/msm/dp/dp_link.h | 132 ++ >> drivers/gpu/drm/msm/dp/dp_panel.c | 486 +++++ >> drivers/gpu/drm/msm/dp/dp_panel.h | 95 + >> drivers/gpu/drm/msm/dp/dp_parser.c | 267 +++ >> drivers/gpu/drm/msm/dp/dp_parser.h | 138 ++ >> drivers/gpu/drm/msm/dp/dp_pll.c | 99 + >> drivers/gpu/drm/msm/dp/dp_pll.h | 61 + >> drivers/gpu/drm/msm/dp/dp_pll_10nm.c | 930 +++++++++ >> drivers/gpu/drm/msm/dp/dp_pll_private.h | 89 + >> drivers/gpu/drm/msm/dp/dp_power.c | 373 ++++ >> drivers/gpu/drm/msm/dp/dp_power.h | 103 + >> drivers/gpu/drm/msm/dp/dp_reg.h | 518 +++++ >> drivers/gpu/drm/msm/msm_drv.c | 2 + >> drivers/gpu/drm/msm/msm_drv.h | 59 +- >> include/drm/drm_dp_helper.h | 1 + >> 34 files changed, 9545 insertions(+), 19 deletions(-) >> create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_aux.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_catalog.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_ctrl.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_display.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_display.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_drm.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_link.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_link.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_panel.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_parser.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_pll.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_10nm.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_pll_private.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_power.c >> create mode 100644 drivers/gpu/drm/msm/dp/dp_power.h >> create mode 100644 drivers/gpu/drm/msm/dp/dp_reg.h >> >> >> base-commit: d012a7190fc1fd72ed48911e77ca97ba4521bccd >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project >>