From patchwork Wed Jun 9 22:02:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 12311323 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B353C48BE0 for ; Wed, 9 Jun 2021 22:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8C6F613DF for ; Wed, 9 Jun 2021 22:04:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230043AbhFIWGI (ORCPT ); Wed, 9 Jun 2021 18:06:08 -0400 Received: from mail-pg1-f174.google.com ([209.85.215.174]:45907 "EHLO mail-pg1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230171AbhFIWGE (ORCPT ); Wed, 9 Jun 2021 18:06:04 -0400 Received: by mail-pg1-f174.google.com with SMTP id q15so20866945pgg.12 for ; Wed, 09 Jun 2021 15:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FSmG8JSTNYJB4mdr65MxKl2rnU6Do0CSqL9o/SwwmH8=; b=mYno2CUBt+srYNkkvZxkbcWenzshrbVT0rkI9hQHk5JcPp+a1/qukg1XAfh/bp9PKy tOuADKVuUrytj83Fnp+wzUBjsGNW8nr3kjPVZK+wtTBbCrGY6+lnc5K1XAlTO1idWTSK iiDcYQAoFQDApt9xGemxq3tlqC3e/QVQDNXCI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FSmG8JSTNYJB4mdr65MxKl2rnU6Do0CSqL9o/SwwmH8=; b=abSBBd579859bwXDoVB/dDLPTxAID3cBtQaRzTQANxTgs40Z0aUmY6+Fshy+imFQeK KUNk5qCTIJQnBxzx5taskreGEvIiuzro6fGlmSUGNa4V8MD+i23tXMqNfdp7sZ8RvCVK TSMlxs/s8cULr2NmfwlEV6rNjJqOoxEvB7C7V+3LH3axTVc/Aq15GvscxHWfa+7msRPp a2Sglr6Qt3f81OuzfEulV6la6ANEwzWslKlMhyPgPYtMpChlJ2SAhWqhx3OwCMukver4 ycoa+dc85eHYyGvUCh+m+zKYAOfR190a/oh/yj2bV9tjR0fLFNyA5gKCopLx/EilC3xI F6/A== X-Gm-Message-State: AOAM530DgP0MhcoMq0HvTNu403yiBIiNw2viGavNswnVEz6wAoF5ZAXO QT4ww8sR9xgFQJMj5J9v1U7SXA== X-Google-Smtp-Source: ABdhPJz4Kny4z2bVLbWkuDIljoKel/KIoiXmZ9FfqLEn86S9YrJ78VqUUOGMHNJG4mPFXt0x7bi8GA== X-Received: by 2002:a63:4b0f:: with SMTP id y15mr1719057pga.227.1623276173250; Wed, 09 Jun 2021 15:02:53 -0700 (PDT) Received: from localhost ([2620:15c:202:201:cedb:c2b5:f22c:760]) by smtp.gmail.com with UTF8SMTPSA id h12sm463276pfh.9.2021.06.09.15.02.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 15:02:52 -0700 (PDT) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman Cc: Peter Chen , Bastien Nocera , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Ravi Chandra Sadineni , Stephen Boyd , linux-kernel@vger.kernel.org, Michal Simek , Krzysztof Kozlowski , Douglas Anderson , Matthias Kaehlcke , Al Cooper , "Alexander A. Klimov" , Andy Gross , Bjorn Andersson , Colin Ian King , Dmitry Osipenko , Fabio Estevam , Masahiro Yamada , linux-arm-msm@vger.kernel.org Subject: [PATCH v12 0/5] USB: misc: Add onboard_usb_hub driver Date: Wed, 9 Jun 2021 15:02:44 -0700 Message-Id: <20210609220249.86061-1-mka@chromium.org> X-Mailer: git-send-email 2.32.0.rc1.229.g3e70b5a671-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This series adds: - the onboard_usb_hub_driver - glue in the xhci-plat driver to create and destroy the onboard_usb_hub platform devices if needed - a device tree binding for the Realtek RTS5411 USB hub controller - device tree changes that add RTS5411 entries for the QCA SC7180 based boards trogdor and lazor - a couple of stubs for platform device functions to avoid unresolved symbols with certain kernel configs The main issue the driver addresses is that a USB hub needs to be powered before it can be discovered. For discrete onboard hubs (an example for such a hub is the Realtek RTS5411) this is often solved by supplying the hub with an 'always-on' regulator, which is kind of a hack. Some onboard hubs may require further initialization steps, like changing the state of a GPIO or enabling a clock, which requires even more hacks. This driver creates a platform device representing the hub which performs the necessary initialization. Currently it only supports switching on a single regulator, support for multiple regulators or other actions can be added as needed. Different initialization sequences can be supported based on the compatible string. Besides performing the initialization the driver can be configured to power the hub off during system suspend. This can help to extend battery life on battery powered devices which have no requirements to keep the hub powered during suspend. The driver can also be configured to leave the hub powered when a wakeup capable USB device is connected when suspending, and power it off otherwise. Changes in v12: - onboard_hub driver: use IS_ENABLED(CONFIG_USB_ONBOARD_HUB_MODULE) in onboard_hub.h to also check for the driver built as module - onboard_hub_driver: include onboard_hub.h again to make sure there are prototype declarations for the public functions Changes in v11: - support multiple onboard hubs connected to the same parent - don't include ‘onboard_hub.h’ from the onboard hub driver Changes in v10: - always use of_is_onboard_usb_hub() stub unless ONBOARD_USB_HUB=y/m - keep 'regulator-boot-on' property for pp3300_hub Changes in v9: - added dependency on ONBOARD_USB_HUB (or !!ONBOARD_USB_HUB) to USB_PLATFORM_XHCI Changes in v7: - updated DT binding - series rebased on qcom/arm64-for-5.13 Changes in v6: - updated summary Changes in v5: - cover letter added Matthias Kaehlcke (5): dt-bindings: usb: Add binding for Realtek RTS5411 hub controller USB: misc: Add onboard_usb_hub driver of/platform: Add stubs for of_platform_device_create/destroy() usb: host: xhci-plat: Create platform device for onboard hubs in probe() arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub .../sysfs-bus-platform-onboard-usb-hub | 8 + .../bindings/usb/realtek,rts5411.yaml | 62 +++ MAINTAINERS | 7 + .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 +- .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +- .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 +- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 +- drivers/usb/host/Kconfig | 1 + drivers/usb/host/xhci-plat.c | 6 + drivers/usb/host/xhci.h | 2 + drivers/usb/misc/Kconfig | 17 + drivers/usb/misc/Makefile | 1 + drivers/usb/misc/onboard_usb_hub.c | 497 ++++++++++++++++++ include/linux/of_platform.h | 22 +- include/linux/usb/onboard_hub.h | 18 + 15 files changed, 676 insertions(+), 34 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub create mode 100644 Documentation/devicetree/bindings/usb/realtek,rts5411.yaml create mode 100644 drivers/usb/misc/onboard_usb_hub.c create mode 100644 include/linux/usb/onboard_hub.h