From patchwork Mon Jul 19 22:21:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matthias Kaehlcke X-Patchwork-Id: 12387083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E48C07E95 for ; Mon, 19 Jul 2021 23:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64E936113C for ; Mon, 19 Jul 2021 23:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346539AbhGSW6W (ORCPT ); Mon, 19 Jul 2021 18:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244923AbhGSVmA (ORCPT ); Mon, 19 Jul 2021 17:42:00 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 744ACC0613EF for ; Mon, 19 Jul 2021 15:21:33 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id j3so10471009plx.7 for ; Mon, 19 Jul 2021 15:21:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g/dOV28w65pxh5ZmEzT6pr+7G27OdOAmfP8aDoqZ7uM=; b=AhLgpr5yBSQHcGrcgVSeffBdLqhhiTLHq6yDABoOKwG02fOJewBUfDQ2/EmGUYUHOu D48vq0kGXE5lcoEItRHyqL+m6e6qzJlTsvI3tePcufoaW1VVcMi9sWo+j3Cy8rXQ6JjW XrMgRuyUQuHSasNE7tsI8p/a1paQ6SUdJFArA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=g/dOV28w65pxh5ZmEzT6pr+7G27OdOAmfP8aDoqZ7uM=; b=Zu6+TRLhWOmAQ6Bw2bb6CmfaI9WpJO/uMhdR89iHlbnjXt8FKBxfg+7//Rjq5xwc5c PE14IqE+LLJJYPDWM5oYZIA36RcGOUZkanwD60sRRkwJsI/dzj/+w8ycknFZh1n9rS+m bHdEI04W+BPOga+pjItF1WgcbK1UgElult2g/GxlqXq467whNPxJRpciee/OGHA/woG5 fLelxMTwFoJ6SdwkkYFLwnLqg8wGEbgGeNe9cEyoWtAOVMN8mZ1ztC596t2+wDyWQFR8 2rp352O4bjT298vRSTz/1TCThpW6lJFDkx89ypXBMh8Sb5KqvZPNembJN8mrLsuDrOG2 preQ== X-Gm-Message-State: AOAM533cGK9MInYVtAebx1KQIRoXoeDeP6GbhQLeLnuYrsE7xwXFfl6g Lsar6KB9KeqT2NH8e7DckrQ1UQ== X-Google-Smtp-Source: ABdhPJzwqcUb44VC1v8yykJ4jZuanOJGbArWh13iII5p2GKfZ+5qRQ4gk263ws9+YVvXDaq0KWaOQA== X-Received: by 2002:a17:90a:7e18:: with SMTP id i24mr25916128pjl.130.1626733292973; Mon, 19 Jul 2021 15:21:32 -0700 (PDT) Received: from localhost ([2620:15c:202:201:4d0:bf5f:b8cd:2d67]) by smtp.gmail.com with UTF8SMTPSA id w16sm23566431pgi.41.2021.07.19.15.21.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jul 2021 15:21:32 -0700 (PDT) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi Cc: Michal Simek , linux-usb@vger.kernel.org, Peter Chen , Bastien Nocera , Douglas Anderson , Stephen Boyd , devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Ravi Chandra Sadineni , Matthias Kaehlcke , Al Cooper , "Alexander A. Klimov" , Andrey Zhizhikin , Andy Gross , Aswath Govindraju , Bjorn Andersson , Catalin Marinas , Dmitry Baryshkov , Dmitry Osipenko , Enric Balletbo i Serra , Fabio Estevam , =?utf-8?q?Guido_G=C3=BCnther?= , Jagan Teki , Nishanth Menon , Pawel Laszczak , Roger Quadros , Shawn Guo , Vinod Koul , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v14 0/6] usb: misc: Add onboard_usb_hub driver Date: Mon, 19 Jul 2021 15:21:22 -0700 Message-Id: <20210719222128.4122837-1-mka@chromium.org> X-Mailer: git-send-email 2.32.0.402.g57bb445576-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org This series adds: - the onboard_usb_hub_driver - glue in the xhci-plat driver to create and destroy the onboard_usb_hub platform devices if needed - a device tree binding for the Realtek RTS5411 USB hub controller - device tree changes that add RTS5411 entries for the QCA SC7180 based boards trogdor and lazor - a couple of stubs for platform device functions to avoid unresolved symbols with certain kernel configs The main issue the driver addresses is that a USB hub needs to be powered before it can be discovered. For discrete onboard hubs (an example for such a hub is the Realtek RTS5411) this is often solved by supplying the hub with an 'always-on' regulator, which is kind of a hack. Some onboard hubs may require further initialization steps, like changing the state of a GPIO or enabling a clock, which requires even more hacks. This driver creates a platform device representing the hub which performs the necessary initialization. Currently it only supports switching on a single regulator, support for multiple regulators or other actions can be added as needed. Different initialization sequences can be supported based on the compatible string. Besides performing the initialization the driver can be configured to power the hub off during system suspend. This can help to extend battery life on battery powered devices which have no requirements to keep the hub powered during suspend. The driver can also be configured to leave the hub powered when a wakeup capable USB device is connected when suspending, and power it off otherwise. Changes in v14: - rebased on top of v5.14-rc1 - dropped DT binding patch which landed in v5.13 Changes in v13: - added patch "usb: Specify dependency on USB_XHCI_PLATFORM with 'depends on'" to the series to avoid Kconfig conflicts - added patch "arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM" to the series to keep effective defconfig unchanged Changes in v12: - onboard_hub driver: use IS_ENABLED(CONFIG_USB_ONBOARD_HUB_MODULE) in onboard_hub.h to also check for the driver built as module - onboard_hub_driver: include onboard_hub.h again to make sure there are prototype declarations for the public functions Changes in v11: - support multiple onboard hubs connected to the same parent - don't include ‘onboard_hub.h’ from the onboard hub driver Changes in v10: - always use of_is_onboard_usb_hub() stub unless ONBOARD_USB_HUB=y/m - keep 'regulator-boot-on' property for pp3300_hub Changes in v9: - added dependency on ONBOARD_USB_HUB (or !!ONBOARD_USB_HUB) to USB_PLATFORM_XHCI Changes in v7: - updated DT binding - series rebased on qcom/arm64-for-5.13 Changes in v6: - updated summary Changes in v5: - cover letter added Matthias Kaehlcke (6): usb: misc: Add onboard_usb_hub driver of/platform: Add stubs for of_platform_device_create/destroy() arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' usb: host: xhci-plat: Create platform device for onboard hubs in probe() arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub .../sysfs-bus-platform-onboard-usb-hub | 8 + MAINTAINERS | 7 + .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 +- .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +- .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 +- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 +- arch/arm64/configs/defconfig | 1 + drivers/usb/cdns3/Kconfig | 2 +- drivers/usb/dwc3/Kconfig | 3 +- drivers/usb/host/Kconfig | 5 +- drivers/usb/host/xhci-plat.c | 6 + drivers/usb/host/xhci.h | 2 + drivers/usb/misc/Kconfig | 17 + drivers/usb/misc/Makefile | 1 + drivers/usb/misc/onboard_usb_hub.c | 497 ++++++++++++++++++ include/linux/of_platform.h | 22 +- include/linux/usb/onboard_hub.h | 18 + 17 files changed, 620 insertions(+), 38 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub create mode 100644 drivers/usb/misc/onboard_usb_hub.c create mode 100644 include/linux/usb/onboard_hub.h