Message ID | 20220921045602.1462007-1-bhupesh.sharma@linaro.org (mailing list archive) |
---|---|
Headers | show |
Series | ARM: dts + defconfig: Add support for Qualcomm QCE block on new SoCs and in defconfig | expand |
On Wed, 21 Sep 2022 10:25:58 +0530, Bhupesh Sharma wrote: > Changes since v6: > ================= > - v6 can be seen here: https://lore.kernel.org/linux-arm-msm/30756e6f-952f-ccf2-b493-e515ba4f0a64@linaro.org/ > - No code changes since v6. > - As per Krzysztof's suggestion on v6, clubbed the crypto driver and > dt-bindings changes together. Now the overall v5 patchset into 3 > separate patchsets, one each for the following areas to allow easier > review and handling from the maintainer: > arm-msm, crypto and dma > - This patch targets the arm/arm-msm tree specifically. > - This patchset is dependent on the crypto + dt-binding patchset, which > can be seen here: https://lore.kernel.org/linux-arm-msm/20220920114051.1116441-1-bhupesh.sharma@linaro.org/ > > [...] Applied, thanks! [4/4] arm64: defconfig: Enable Qualcomm QCE crypto commit: e19d0bf25c8119eaf401041c55af4edb5beab90c Best regards,
Changes since v6: ================= - v6 can be seen here: https://lore.kernel.org/linux-arm-msm/30756e6f-952f-ccf2-b493-e515ba4f0a64@linaro.org/ - No code changes since v6. - As per Krzysztof's suggestion on v6, clubbed the crypto driver and dt-bindings changes together. Now the overall v5 patchset into 3 separate patchsets, one each for the following areas to allow easier review and handling from the maintainer: arm-msm, crypto and dma - This patch targets the arm/arm-msm tree specifically. - This patchset is dependent on the crypto + dt-binding patchset, which can be seen here: https://lore.kernel.org/linux-arm-msm/20220920114051.1116441-1-bhupesh.sharma@linaro.org/ Changes since v5: ================= - v5 can be seen here: https://lore.kernel.org/lkml/20211110105922.217895-1-bhupesh.sharma@linaro.org/ - As per Bjorn's suggestion on irc, broke down the patchset into 4 separate patchsets, one each for the following areas to allow easier review and handling from the respective maintainer(s): 'arm-msm', 'crypto', 'dma' and 'devicetree' This patchset is directed for the 'arm-msm' tree / area. - Addressed Rob's, Vladimir's and Bjorn's review comments on v5. - Added Tested-by from Jordan received on the v5. - Also added a 'defconfig' change where I enabled the QCE block as a module. Changes since v4: ================= - v4 for sm8250 can be seen here: https://lore.kernel.org/linux-arm-msm/20211013105541.68045-1-bhupesh.sharma@linaro.org/ - v1 for sm8150 qce enablement can be seen here: https://lore.kernel.org/linux-arm-msm/20211013165823.88123-1-bhupesh.sharma@linaro.org/ - Merged the sm8150 and sm8250 enablement patches in the same patchset, as per suggestions from Bjorn. - Dropped a couple of patches from v4, as these have been picked by Bjorn already via his tree. - Addressed review comments from Vladimir, Thara and Rob. - Collect Reviewed-by from Rob and Thara on some of the patches from the v4 patchset. Changes since v3: ================= - v3 can be seen here: https://lore.kernel.org/linux-arm-msm/20210519143700.27392-1-bhupesh.sharma@linaro.org/ - Dropped a couple of patches from v3, on basis of the review comments: ~ [PATCH 13/17] crypto: qce: core: Make clocks optional ~ [PATCH 15/17] crypto: qce: Convert the device found dev_dbg() to dev_info() - Addressed review comments from Thara, Rob and Stephan Gerhold. - Collect Reviewed-by from Rob and Thara on some of the patches from the v3 patchset. Changes since v2: ================= - v2 can be seen here: https://lore.kernel.org/dmaengine/20210505213731.538612-1-bhupesh.sharma@linaro.org/ - Drop a couple of patches from v1, which tried to address the defered probing of qce driver in case bam dma driver is not yet probed. Replace it instead with a single (simpler) patch [PATCH 16/17]. - Convert bam dma and qce crypto dt-bindings to YAML. - Addressed review comments from Thara, Bjorn, Vinod and Rob. Changes since v1: ================= - v1 can be seen here: https://lore.kernel.org/linux-arm-msm/20210310052503.3618486-1-bhupesh.sharma@linaro.org/ - v1 did not work well as reported earlier by Dmitry, so v2 contains the following changes/fixes: ~ Enable the interconnect path b/w BAM DMA and main memory first before trying to access the BAM DMA registers. ~ Enable the interconnect path b/w qce crytpo and main memory first before trying to access the qce crypto registers. ~ Make sure to document the required and optional properties for both BAM DMA and qce crypto drivers. ~ Add a few debug related print messages in case the qce crypto driver passes or fails to probe. ~ Convert the qce crypto driver probe to a defered one in case the BAM DMA or the interconnect driver(s) (needed on specific Qualcomm parts) are not yet probed. Qualcomm crypto engine (qce) is available on several Snapdragon SoCs. The qce block supports hardware accelerated algorithms for encryption and authentication. It also provides support for aes, des, 3des encryption algorithms and sha1, sha256, hmac(sha1), hmac(sha256) authentication algorithms. Tested the enabled crypto algorithms with cryptsetup test utilities on sm8150-mtp, sa8155p-adp, sm8250-mtp and RB5 boards (see [1]) and also with crypto self-tests, including the fuzz tests (CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y). [1]. https://linux.die.net/man/8/cryptsetup Cc: thara.gopinath@gmail.com Cc: robh@kernel.org Cc: andersson@kernel.org Tested-by: Jordan Crouse <jorcrous@amazon.com> Bhupesh Sharma (4): ARM: dts: qcom: Use new compatibles for crypto nodes arm64: dts: qcom: sm8250: Add dt entries to support crypto engine. arm64: dts: qcom: sm8150: Add dt entries to support crypto engine. arm64: defconfig: Enable Qualcomm QCE crypto arch/arm/boot/dts/qcom-ipq4019.dtsi | 2 +- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- arch/arm64/boot/dts/qcom/sm8150.dtsi | 28 +++++++++++++++++++++++++++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 28 +++++++++++++++++++++++++++ arch/arm64/configs/defconfig | 1 + 8 files changed, 62 insertions(+), 5 deletions(-)