[net-next,0/8] net: ipa: another set of cleanups

Message

Alex Elder Sept. 22, 2022, 10:20 p.m. UTC

This series contains another set of cleanups done in preparation for
an upcoming series that reworks how IPA registers and their fields
are defined.

The first replaces the use of u32_replace_bits() with a simple
logical AND operation in two places.

The second creates a new function to encapsulate some common code,
and renames another for consistency.  The third restructures two
other functions that do similar things to make their similarity more
obvious.

The fourth defines the flag bits in a register using an enumerated
type.  And the fifth updates "ipa_reg.h" so the values assigned to
enumerated type members are aligned consistently.

The last three encapsulate the code that assigns values to a few
registers into separate functions.

					-Alex

Alex Elder (8):
  net: ipa: don't use u32p_replace_bits()
  net: ipa: introduce ipa_qtime_val()
  net: ipa: rearrange functions for similarity
  net: ipa: define BCR values using an enum
  net: ipa: tidy up register enum definitions
  net: ipa: encapsulate setting the FILT_ROUT_HASH_EN register
  net: ipa: encapsulate updating the COUNTER_CFG register
  net: ipa: encapsulate updating three more registers

 drivers/net/ipa/data/ipa_data-v3.1.c   |   2 +-
 drivers/net/ipa/data/ipa_data-v3.5.1.c |  10 +-
 drivers/net/ipa/ipa_endpoint.c         | 138 +++++++++++++------------
 drivers/net/ipa/ipa_main.c             | 135 +++++++++++++++---------
 drivers/net/ipa/ipa_reg.h              |  68 ++++++------
 drivers/net/ipa/ipa_table.c            |   4 +-
 6 files changed, 200 insertions(+), 157 deletions(-)

Comments

[e-mail] Sept. 24, 2022, 4:10 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[e-mail]>:

On Thu, 22 Sep 2022 17:20:52 -0500 you wrote:
> This series contains another set of cleanups done in preparation for
> an upcoming series that reworks how IPA registers and their fields
> are defined.
> 
> The first replaces the use of u32_replace_bits() with a simple
> logical AND operation in two places.
> 
> [...]

Here is the summary with links:
  - [net-next,1/8] net: ipa: don't use u32p_replace_bits()
    https://git.kernel.org/netdev/net-next/c/a50d37b7565e
  - [net-next,2/8] net: ipa: introduce ipa_qtime_val()
    https://git.kernel.org/netdev/net-next/c/8be440e17bdb
  - [net-next,3/8] net: ipa: rearrange functions for similarity
    (no matching commit)
  - [net-next,4/8] net: ipa: define BCR values using an enum
    https://git.kernel.org/netdev/net-next/c/21ab2078ff37
  - [net-next,5/8] net: ipa: tidy up register enum definitions
    https://git.kernel.org/netdev/net-next/c/73e0c9efb5ed
  - [net-next,6/8] net: ipa: encapsulate setting the FILT_ROUT_HASH_EN register
    https://git.kernel.org/netdev/net-next/c/b24627b1d9b2
  - [net-next,7/8] net: ipa: encapsulate updating the COUNTER_CFG register
    https://git.kernel.org/netdev/net-next/c/1e5db0965ef5
  - [net-next,8/8] net: ipa: encapsulate updating three more registers
    https://git.kernel.org/netdev/net-next/c/92073b1648cb

You are awesome, thank you!