[net-next,0/7] net: ipa: validation cleanup

Message

Alex Elder Oct. 21, 2022, 7:13 p.m. UTC

This series gathers a set of IPA driver cleanups, mostly involving
code that ensures certain things are known to be correct *early*
(either at build or initializatin time), so they can be assumed good
during normal operation.

The first removes three constant symbols, by making a (reasonable)
assumption that a routing table consists of entries for the modem
followed by entries for the AP, with no unused entries between them.

The second removes two checks that are redundant (they verify the
sizes of two memory regions are in range, which will have been done
earlier for all regions).

The third adds some new checks to routing and filter tables that
can be done at "init time" (without requiring any access to IPA
hardware).

The fourth moves a check that routing and filter table addresses can
be encoded within certain IPA immediate commands, so it's performed
earlier; the checks can be done without touching IPA hardware.  The
fifth moves some other command-related checks earlier, for the same
reason.

The sixth removes the definition ipa_table_valid(), because what it
does has become redundant.  Finally, the last patch moves two more
validation calls so they're done very early in the probe process.
This will be required by some upcoming patches, which will record
the size of the routing and filter tables at this time so they're
available for subsequent initialization.

					-Alex

Alex Elder (7):
  net: ipa: kill two constant symbols
  net: ipa: remove two memory region checks
  net: ipa: validate IPA table memory earlier
  net: ipa: verify table sizes fit in commands early
  net: ipa: introduce ipa_cmd_init()
  net: ipa: kill ipa_table_valid()
  net: ipa: check table memory regions earlier

 drivers/net/ipa/ipa_cmd.c   |  53 ++++--------
 drivers/net/ipa/ipa_cmd.h   |  16 +++-
 drivers/net/ipa/ipa_mem.c   |  14 ++--
 drivers/net/ipa/ipa_table.c | 162 +++++++++++++++++++++---------------
 drivers/net/ipa/ipa_table.h |  15 ++--
 5 files changed, 138 insertions(+), 122 deletions(-)

Comments

[e-mail] Oct. 25, 2022, 9:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by Paolo Abeni <[e-mail]>:

On Fri, 21 Oct 2022 14:13:33 -0500 you wrote:
> This series gathers a set of IPA driver cleanups, mostly involving
> code that ensures certain things are known to be correct *early*
> (either at build or initializatin time), so they can be assumed good
> during normal operation.
> 
> The first removes three constant symbols, by making a (reasonable)
> assumption that a routing table consists of entries for the modem
> followed by entries for the AP, with no unused entries between them.
> 
> [...]

Here is the summary with links:
  - [net-next,1/7] net: ipa: kill two constant symbols
    https://git.kernel.org/netdev/net-next/c/fb4014ac76b8
  - [net-next,2/7] net: ipa: remove two memory region checks
    https://git.kernel.org/netdev/net-next/c/2554322b3199
  - [net-next,3/7] net: ipa: validate IPA table memory earlier
    https://git.kernel.org/netdev/net-next/c/cf13919654d5
  - [net-next,4/7] net: ipa: verify table sizes fit in commands early
    https://git.kernel.org/netdev/net-next/c/5444b0ea9915
  - [net-next,5/7] net: ipa: introduce ipa_cmd_init()
    https://git.kernel.org/netdev/net-next/c/7fd10a2aca6a
  - [net-next,6/7] net: ipa: kill ipa_table_valid()
    https://git.kernel.org/netdev/net-next/c/39ad815244ac
  - [net-next,7/7] net: ipa: check table memory regions earlier
    https://git.kernel.org/netdev/net-next/c/73da9cac517c

You are awesome, thank you!