| Message ID | 20230119212632.185881-1-marijn.suijten@somainline.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: Use labels with generic node names for ADC channels | expand |
+cc linux-iio@vger.kernel.org Apologies, I blindly copied Jonathans request [1] to send this to iio@vger.kernel.org, without checking for the common linux- prefix. [1]: https://lore.kernel.org/linux-arm-msm/20221211141526.463f43e6@jic23-huawei/ On 2023-01-19 22:26:30, Marijn Suijten wrote: > As discussed in [1] it is more convenient to use a generic adc-chan node > name for ADC channels while storing a friendly - board-specific instead > of PMIC-specific - name in the label, if/when desired to overwrite the > channel description already contained (but previously unused) in the > driver [2]. > > Replace the .* name pattern with the adc-chan literal, but leave the > label property optional for bindings to choose to fall back a channel > label hardcoded in the driver [2] instead. > > [1]: https://lore.kernel.org/linux-arm-msm/20221106193018.270106-1-marijn.suijten@somainline.org/T/#u > [2]: https://lore.kernel.org/linux-arm-msm/20230116220909.196926-4-marijn.suijten@somainline.org/ > > Changes since v1: > - Require adc-chan name in dt-bindings; > - Replace more node names with adc-chan and a descriptive label, that > were found by running dtbs_check on adjusted bindings; > - sm8250-mtp.dts: Fix accidental adc-chan2 node name with pa_therm > label, which should have been adc-chan with pa_therm2 label. > > v1: https://lore.kernel.org/linux-arm-msm/20221209215308.1781047-1-marijn.suijten@somainline.org/ > > Marijn Suijten (2): > dt-bindings: iio: adc: Require generic adc-chan name for channel nodes > arm64: dts: qcom: Use labels with generic node names for ADC channels > > .../bindings/iio/adc/qcom,spmi-vadc.yaml | 16 ++++---- > arch/arm64/boot/dts/qcom/pm6125.dtsi | 18 ++++++--- > arch/arm64/boot/dts/qcom/pm660.dtsi | 33 ++++++++++------ > arch/arm64/boot/dts/qcom/pm8150.dtsi | 6 +-- > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 8 ++-- > arch/arm64/boot/dts/qcom/pm8150l.dtsi | 6 +-- > arch/arm64/boot/dts/qcom/pm8950.dtsi | 39 ++++++++++++------- > arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi | 6 +-- > arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi | 6 +-- > arch/arm64/boot/dts/qcom/pmp8074.dtsi | 27 ++++++++----- > arch/arm64/boot/dts/qcom/pms405.dtsi | 21 ++++++---- > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 15 ++++--- > .../dts/qcom/sc7180-trogdor-coachz-r1.dts | 4 +- > .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 3 +- > .../dts/qcom/sc7180-trogdor-homestar.dtsi | 3 +- > .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 2 +- > .../dts/qcom/sc7180-trogdor-pompom-r1.dts | 2 +- > .../dts/qcom/sc7180-trogdor-pompom-r2.dts | 2 +- > .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 3 +- > .../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 3 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 +- > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 2 +- > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 +- > .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 39 ++++++++++++------- > .../qcom/sm6125-sony-xperia-seine-pdx201.dts | 15 ++++--- > arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 21 ++++++---- > 27 files changed, 196 insertions(+), 113 deletions(-) > > -- > 2.39.1 >
On Thu, 19 Jan 2023 23:17:57 +0100 Marijn Suijten <marijn.suijten@somainline.org> wrote: > +cc linux-iio@vger.kernel.org > > Apologies, I blindly copied Jonathans request [1] to send this to > iio@vger.kernel.org, without checking for the common linux- prefix. Oops from me! :) Jonathan > > [1]: https://lore.kernel.org/linux-arm-msm/20221211141526.463f43e6@jic23-huawei/ > > On 2023-01-19 22:26:30, Marijn Suijten wrote: > > As discussed in [1] it is more convenient to use a generic adc-chan node > > name for ADC channels while storing a friendly - board-specific instead > > of PMIC-specific - name in the label, if/when desired to overwrite the > > channel description already contained (but previously unused) in the > > driver [2]. > > > > Replace the .* name pattern with the adc-chan literal, but leave the > > label property optional for bindings to choose to fall back a channel > > label hardcoded in the driver [2] instead. > > > > [1]: https://lore.kernel.org/linux-arm-msm/20221106193018.270106-1-marijn.suijten@somainline.org/T/#u > > [2]: https://lore.kernel.org/linux-arm-msm/20230116220909.196926-4-marijn.suijten@somainline.org/ > > > > Changes since v1: > > - Require adc-chan name in dt-bindings; > > - Replace more node names with adc-chan and a descriptive label, that > > were found by running dtbs_check on adjusted bindings; > > - sm8250-mtp.dts: Fix accidental adc-chan2 node name with pa_therm > > label, which should have been adc-chan with pa_therm2 label. > > > > v1: https://lore.kernel.org/linux-arm-msm/20221209215308.1781047-1-marijn.suijten@somainline.org/ > > > > Marijn Suijten (2): > > dt-bindings: iio: adc: Require generic adc-chan name for channel nodes > > arm64: dts: qcom: Use labels with generic node names for ADC channels > > > > .../bindings/iio/adc/qcom,spmi-vadc.yaml | 16 ++++---- > > arch/arm64/boot/dts/qcom/pm6125.dtsi | 18 ++++++--- > > arch/arm64/boot/dts/qcom/pm660.dtsi | 33 ++++++++++------ > > arch/arm64/boot/dts/qcom/pm8150.dtsi | 6 +-- > > arch/arm64/boot/dts/qcom/pm8150b.dtsi | 8 ++-- > > arch/arm64/boot/dts/qcom/pm8150l.dtsi | 6 +-- > > arch/arm64/boot/dts/qcom/pm8950.dtsi | 39 ++++++++++++------- > > arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi | 6 +-- > > arch/arm64/boot/dts/qcom/pmm8155au_2.dtsi | 6 +-- > > arch/arm64/boot/dts/qcom/pmp8074.dtsi | 27 ++++++++----- > > arch/arm64/boot/dts/qcom/pms405.dtsi | 21 ++++++---- > > arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 15 ++++--- > > .../dts/qcom/sc7180-trogdor-coachz-r1.dts | 4 +- > > .../boot/dts/qcom/sc7180-trogdor-coachz.dtsi | 3 +- > > .../dts/qcom/sc7180-trogdor-homestar.dtsi | 3 +- > > .../boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 2 +- > > .../dts/qcom/sc7180-trogdor-pompom-r1.dts | 2 +- > > .../dts/qcom/sc7180-trogdor-pompom-r2.dts | 2 +- > > .../boot/dts/qcom/sc7180-trogdor-pompom.dtsi | 3 +- > > .../dts/qcom/sc7180-trogdor-wormdingler.dtsi | 3 +- > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 +- > > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 2 +- > > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 2 +- > > arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 4 +- > > .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 39 ++++++++++++------- > > .../qcom/sm6125-sony-xperia-seine-pdx201.dts | 15 ++++--- > > arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 21 ++++++---- > > 27 files changed, 196 insertions(+), 113 deletions(-) > > > > -- > > 2.39.1 > >
On 2023-01-21 16:59:54, Jonathan Cameron wrote: > On Thu, 19 Jan 2023 23:17:57 +0100 > Marijn Suijten <marijn.suijten@somainline.org> wrote: > > > +cc linux-iio@vger.kernel.org > > > > Apologies, I blindly copied Jonathans request [1] to send this to > > iio@vger.kernel.org, without checking for the common linux- prefix. > Oops from me! > :) Double oops from me, linux-iio was already CC'd because of the dt-bindings patch (and I collate all CC'ers in the cover letter and distribute all patches with --cc-cover) and I acted on the iio@ bounce too quickly :) - Marijn <snip>