mbox series

[v4,0/3] Add USB/DP combo PHY config for SM6350

Message ID 20230120-sm6350-usbphy-v4-0-4d700a90ba16@fairphone.com (mailing list archive)
Headers show
Series Add USB/DP combo PHY config for SM6350 | expand

Message

Luca Weiss Jan. 23, 2023, 1:29 p.m. UTC
While this patchset started out as just adding a dedicated init sequence
for SM6350 since USB PHY init didn't work in some cases, now it's also
migrating the phy config and dts over to a new format.

Also note, that the DP portions are pratically untested since TCPM
(type-C port manager) and possibly other components aren't brought up
yet.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Changes in v4:
- Fix dp_serdes offsets in driver, add dp_txa & dp_txb fields (as in v2)
- Fix order of resets in dtsi
- Link to v3: https://lore.kernel.org/r/20221130081430.67831-1-luca.weiss@fairphone.com

---
Luca Weiss (3):
      dt-bindings: phy: qcom,qmp-usb3-dp: Add sm6350 compatible
      phy: qcom-qmp-combo: Add config for SM6350
      arm64: dts: qcom: sm6350: Use specific qmpphy compatible

 .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml         |   1 +
 arch/arm64/boot/dts/qcom/sm6350.dtsi               |  54 +++-----
 drivers/phy/qualcomm/phy-qcom-qmp-combo.c          | 139 ++++++++++++++++++++-
 3 files changed, 154 insertions(+), 40 deletions(-)
---
base-commit: d514392f17fd4d386cfadde7f849d97db4ca1fb0
change-id: 20230120-sm6350-usbphy-87c5e3f0218e

Best regards,

Comments

Vinod Koul Feb. 2, 2023, 1:19 p.m. UTC | #1
On 23-01-23, 14:29, Luca Weiss wrote:
> While this patchset started out as just adding a dedicated init sequence
> for SM6350 since USB PHY init didn't work in some cases, now it's also
> migrating the phy config and dts over to a new format.
> 
> Also note, that the DP portions are pratically untested since TCPM
> (type-C port manager) and possibly other components aren't brought up
> yet.

Applied 1-2, thanks

> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>

cover doesnt need sob :)

> ---
> Changes in v4:
> - Fix dp_serdes offsets in driver, add dp_txa & dp_txb fields (as in v2)
> - Fix order of resets in dtsi
> - Link to v3: https://lore.kernel.org/r/20221130081430.67831-1-luca.weiss@fairphone.com
> 
> ---
> Luca Weiss (3):
>       dt-bindings: phy: qcom,qmp-usb3-dp: Add sm6350 compatible
>       phy: qcom-qmp-combo: Add config for SM6350
>       arm64: dts: qcom: sm6350: Use specific qmpphy compatible
> 
>  .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml         |   1 +
>  arch/arm64/boot/dts/qcom/sm6350.dtsi               |  54 +++-----
>  drivers/phy/qualcomm/phy-qcom-qmp-combo.c          | 139 ++++++++++++++++++++-
>  3 files changed, 154 insertions(+), 40 deletions(-)
> ---
> base-commit: d514392f17fd4d386cfadde7f849d97db4ca1fb0
> change-id: 20230120-sm6350-usbphy-87c5e3f0218e
> 
> Best regards,
> -- 
> Luca Weiss <luca.weiss@fairphone.com>
Luca Weiss Feb. 2, 2023, 1:39 p.m. UTC | #2
On Thu Feb 2, 2023 at 2:19 PM CET, Vinod Koul wrote:
> On 23-01-23, 14:29, Luca Weiss wrote:
> > While this patchset started out as just adding a dedicated init sequence
> > for SM6350 since USB PHY init didn't work in some cases, now it's also
> > migrating the phy config and dts over to a new format.
> > 
> > Also note, that the DP portions are pratically untested since TCPM
> > (type-C port manager) and possibly other components aren't brought up
> > yet.
>
> Applied 1-2, thanks

Thanks!

>
> > 
> > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>
> cover doesnt need sob :)

That comes from b4 ;)
https://b4.docs.kernel.org/

>
> > ---
> > Changes in v4:
> > - Fix dp_serdes offsets in driver, add dp_txa & dp_txb fields (as in v2)
> > - Fix order of resets in dtsi
> > - Link to v3: https://lore.kernel.org/r/20221130081430.67831-1-luca.weiss@fairphone.com
> > 
> > ---
> > Luca Weiss (3):
> >       dt-bindings: phy: qcom,qmp-usb3-dp: Add sm6350 compatible
> >       phy: qcom-qmp-combo: Add config for SM6350
> >       arm64: dts: qcom: sm6350: Use specific qmpphy compatible
> > 
> >  .../phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml         |   1 +
> >  arch/arm64/boot/dts/qcom/sm6350.dtsi               |  54 +++-----
> >  drivers/phy/qualcomm/phy-qcom-qmp-combo.c          | 139 ++++++++++++++++++++-
> >  3 files changed, 154 insertions(+), 40 deletions(-)
> > ---
> > base-commit: d514392f17fd4d386cfadde7f849d97db4ca1fb0
> > change-id: 20230120-sm6350-usbphy-87c5e3f0218e
> > 
> > Best regards,
> > -- 
> > Luca Weiss <luca.weiss@fairphone.com>
>
> -- 
> ~Vinod
Konstantin Ryabitsev Feb. 2, 2023, 6:40 p.m. UTC | #3
February 2, 2023 8:39 AM, "Luca Weiss" <luca.weiss@fairphone.com> wrote:
> On Thu Feb 2, 2023 at 2:19 PM CET, Vinod Koul wrote:
>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>> 
>> cover doesnt need sob :)
> 
> That comes from b4 ;)
> https://b4.docs.kernel.org

There's a number of subsystems that will use the cover letter as the base message for the merge commit, which is why the signoff is added to the cover.

-K
Bjorn Andersson Feb. 9, 2023, 4:23 a.m. UTC | #4
On Mon, 23 Jan 2023 14:29:48 +0100, Luca Weiss wrote:
> While this patchset started out as just adding a dedicated init sequence
> for SM6350 since USB PHY init didn't work in some cases, now it's also
> migrating the phy config and dts over to a new format.
> 
> Also note, that the DP portions are pratically untested since TCPM
> (type-C port manager) and possibly other components aren't brought up
> yet.
> 
> [...]

Applied, thanks!

[3/3] arm64: dts: qcom: sm6350: Use specific qmpphy compatible
      commit: 5ed2b6388b310521fdaa81cf5e075c20e9d0006c

Best regards,