| Message ID | 20230202150619.22425-1-quic_devipriy@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add minimal boot support for IPQ9574 | expand |
On 3.02.2023 06:47, Kathiravan T wrote: > > On 2/2/2023 8:36 PM, Devi Priya wrote: >> Add Global Clock Controller (GCC) driver for ipq9574 based devices >> >> Co-developed-by: Anusha Rao <quic_anusha@quicinc.com> >> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com> >> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >> --- [...] >> +static int gcc_ipq9574_probe(struct platform_device *pdev) >> +{ >> + struct regmap *regmap; >> + struct qcom_cc_desc ipq9574_desc = gcc_ipq9574_desc; >> + >> + regmap = qcom_cc_map(pdev, &ipq9574_desc); >> + if (IS_ERR(regmap)) >> + return PTR_ERR(regmap); >> + >> + return qcom_cc_really_probe(pdev, &ipq9574_desc, regmap); > > > can we use qcom_cc_probe as suggested here https://lore.kernel.org/linux-arm-msm/84f68577f5629e6ef6d6b14357a79f84.sboyd@kernel.org/ ? Yes we can. When you're answering a long long long long email, please cut off parts that you aren't replying to, I had to scroll and scroll and scroll and scroll to get to this sentence and I'm not even sure if you said something inbetween that I missed.. Konrad > > >> +} >> + >> +static struct platform_driver gcc_ipq9574_driver = { >> + .probe = gcc_ipq9574_probe, >> + .driver = { >> + .name = "qcom,gcc-ipq9574", >> + .of_match_table = gcc_ipq9574_match_table, >> + }, >> +}; >> + >> +static int __init gcc_ipq9574_init(void) >> +{ >> + return platform_driver_register(&gcc_ipq9574_driver); >> +} >> +core_initcall(gcc_ipq9574_init); >> + >> +static void __exit gcc_ipq9574_exit(void) >> +{ >> + platform_driver_unregister(&gcc_ipq9574_driver); >> +} >> +module_exit(gcc_ipq9574_exit); >> + >> +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ9574 Driver"); >> +MODULE_LICENSE("GPL");
On 2/3/2023 4:25 PM, Konrad Dybcio wrote: > > On 3.02.2023 06:47, Kathiravan T wrote: >> On 2/2/2023 8:36 PM, Devi Priya wrote: >>> Add Global Clock Controller (GCC) driver for ipq9574 based devices >>> >>> Co-developed-by: Anusha Rao <quic_anusha@quicinc.com> >>> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com> >>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com> >>> --- > [...] > >>> +static int gcc_ipq9574_probe(struct platform_device *pdev) >>> +{ >>> + struct regmap *regmap; >>> + struct qcom_cc_desc ipq9574_desc = gcc_ipq9574_desc; >>> + >>> + regmap = qcom_cc_map(pdev, &ipq9574_desc); >>> + if (IS_ERR(regmap)) >>> + return PTR_ERR(regmap); >>> + >>> + return qcom_cc_really_probe(pdev, &ipq9574_desc, regmap); >> >> can we use qcom_cc_probe as suggested here https://lore.kernel.org/linux-arm-msm/84f68577f5629e6ef6d6b14357a79f84.sboyd@kernel.org/ ? > Yes we can. > > When you're answering a long long long long email, please cut off > parts that you aren't replying to, I had to scroll and scroll and > scroll and scroll to get to this sentence and I'm not even sure if > you said something inbetween that I missed.. Got it, Thanks. > > Konrad >> >>> +} >>> + >>> +static struct platform_driver gcc_ipq9574_driver = { >>> + .probe = gcc_ipq9574_probe, >>> + .driver = { >>> + .name = "qcom,gcc-ipq9574", >>> + .of_match_table = gcc_ipq9574_match_table, >>> + }, >>> +}; >>> + >>> +static int __init gcc_ipq9574_init(void) >>> +{ >>> + return platform_driver_register(&gcc_ipq9574_driver); >>> +} >>> +core_initcall(gcc_ipq9574_init); >>> + >>> +static void __exit gcc_ipq9574_exit(void) >>> +{ >>> + platform_driver_unregister(&gcc_ipq9574_driver); >>> +} >>> +module_exit(gcc_ipq9574_exit); >>> + >>> +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. GCC IPQ9574 Driver"); >>> +MODULE_LICENSE("GPL");